From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1DB1EC47DDB for ; Fri, 26 Jan 2024 21:02:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A19216B0075; Fri, 26 Jan 2024 16:02:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9C9F66B0078; Fri, 26 Jan 2024 16:02:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 892F76B007B; Fri, 26 Jan 2024 16:02:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 785006B0075 for ; Fri, 26 Jan 2024 16:02:39 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 45544120946 for ; Fri, 26 Jan 2024 21:02:39 +0000 (UTC) X-FDA: 81722686038.25.BC45B1B Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by imf05.hostedemail.com (Postfix) with ESMTP id 0AE7B100029 for ; Fri, 26 Jan 2024 21:02:35 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=d6T7Nwal; spf=pass (imf05.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706302956; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NhbVdYdf9iXK0nhJbVHWyWMtXRTj04J6yLcrgUAT+JA=; b=fv8R9Xy7iIeTHdw+Ws/vYxRZyJJuYBU9mNsJOS6a/A726P5CYpmK77De1G7KZ4UHi2pXBS Oauc1WIqRGZU+WlFxzrLvKa6tDinVN8znLfCPZN45sPG6Q+6JAR/ClZNTIGB/KRIueadN7 qSCYprlRXf4ha6NvCqgpSzIjKEzgraI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706302956; a=rsa-sha256; cv=none; b=rF5hQZsu6nNDdXZjXI9O9OmwLbDfDWgFNDVeDljJ4L+TBTyIs3GY8NJcWe9NGtXfzCfiCv e0qrGwi/hlrKvcXa2reoJBSTVtO/06SmJ+yZuLonM4wYNuxh/FFcNPiWKqj+mGQPV2G3Ln uPhpuIqhvqpJ33N9zp+WdN/yZMks4c0= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=d6T7Nwal; spf=pass (imf05.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.172 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d89f0ab02bso3565ad.1 for ; Fri, 26 Jan 2024 13:02:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706302955; x=1706907755; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=NhbVdYdf9iXK0nhJbVHWyWMtXRTj04J6yLcrgUAT+JA=; b=d6T7NwalN6Y25WVAOPHB6uOYgeaYNHe1oxSpGJrpOMlrzfwGEwB71o3+zpIhfiY0Mr 90xO3lv9LBRDMFETPNqY7LjPorDxtJEszHnOrZFa/Mr3S6LkAuDnYHXp7j25RiW9ifYO S6WFIoJp8fVx2f1PaZnWM0VkH5BbC/Jj87+udMmDN++cg1G1Nx1V7V72BItYxP8MN27T ioGLwGEzPCyWqpZ0Zw3vw4ipagip+nSkB8XfzrOwx3cMPonTgHUYU2F1BKP2nmW3ujGD E1vBm/8W+Hw6TInusMayY+P1wKYNxcVMh0BlOkAfsn9roiBFTeZo1YQsNs8COakAQKMh jQ6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706302955; x=1706907755; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NhbVdYdf9iXK0nhJbVHWyWMtXRTj04J6yLcrgUAT+JA=; b=WBR5e/PJSh76PM0J6DRDLYJp0RYHZ/JHqFiG2eK/52ST+H0eNlRHFRgjT325QRbZrp s8N3J42DPtjNV0uiPZ+rRRmsAseFRk775Vva3Lu6gucL/7roQ9MBNwSR5m+vLXN1oP14 kpgjrGUTXggbYy4ZY8NtG4JeC9wmu531qdsIm2cvkAXoIbK9GdDFCuh6e07sKxkk/UlG uHAIGMsHpRHB+cUJI61AQ4VD1EpoHaOFfLJmnLshpasfgSXYf9s1blPa1Wh/OjRkvxk/ srdfxUbROO12ZUx40/RHxo4J+XTT9+WGNC9fJOybXLQF36JaRkSPJGOwdN7VonvPWCKw s+NQ== X-Gm-Message-State: AOJu0YwzxVdwsjSTEu5GgeBwWftwEO0MoKfnxqEF9FVOnTNI3ByKqVrp CTKbPyiEtWTIwBHVpNOOM6UIgY8Tedzm6sxic4w6C4K9ijae73NQYKWHPyC+7moZRJPODhBMTMh yT/c9mBBFogxY86yLPPcX5tAJyCyNHjJddkzI X-Google-Smtp-Source: AGHT+IEHXifKfydOBlCtNuN8Oq2e9oDoysKPEPKuvtnmdtJeP83zNTX6sEG9mhcN/FZmToVFalnIx8RawAX1m1VVAv0= X-Received: by 2002:a17:902:d485:b0:1d7:3ad7:f23e with SMTP id c5-20020a170902d48500b001d73ad7f23emr294723plg.4.1706302954390; Fri, 26 Jan 2024 13:02:34 -0800 (PST) MIME-Version: 1.0 References: <20240126203353.1163059-1-tjmercier@google.com> In-Reply-To: <20240126203353.1163059-1-tjmercier@google.com> From: Shakeel Butt Date: Fri, 26 Jan 2024 13:02:22 -0800 Message-ID: Subject: Re: [PATCH] mm: memcg: Don't periodically flush stats when memcg is disabled To: "T.J. Mercier" Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , android-mm@google.com, Minchan Kim , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: eh5p4mwoyuk7uwqf3xt763sfoewey56e X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 0AE7B100029 X-Rspam-User: X-HE-Tag: 1706302955-195185 X-HE-Meta: U2FsdGVkX18G/VVZak6WA5WwXrVGF0veHqGZ20IMl/VRJlzGJse1QPjLmGGCku6b4NOczho5X3X3Bf4l0xufxHffBiOR4ZX+FEGSEV41KolhiWwFanRtx4ehTR7Xy8gcYKCQd6drtdddPCM5mmqxybr67/r/Mz+wcxVQBgjyJncfRxCHrBlf5c2eafSuOeXXlICDauy4w3rHa6LwePy9ig/XRlcmgGwlI0m3cpWVPezxM+3RjtPLcc2do1N3bKgXZmLpphNI+uLCyO6GIRzB6/0UG9LfTBk4FXVlihY91uhKO3+UV1w8QdYudzOTKHrDj+hIX9gyyxxQY/wRnoMq0Awy3H/knR26fdPUj99mxhL5W7wBJ0cE9Ji405RNu1cc2vd5tWLgYH3pB4cGLvuEtqOW5D3cgET7iuoTerz06RTnFzkfcB4BZxUPQ/3wEjPiYP1kYcvL+ESTaKZTGYoDTdPC4w7RBiH0B/7162dwee66IGcWHKPoe0pFvBmZkUh/PY6RBhxhGTFkFZVvRkIOKol+5AM7C/DrJBIdEAzRiW4nP2OVMuZusDumYn8A+YwfMFnmlswgYqPwid2BJSAXCX/9zUcRK9gqVGn6XYuFAWqrAJG4UiijFfTT8/8hu48NbmtZBcz5BY4dmk3LRZE2BHWiuIxOZbFTn8mR0lJ79a61lOc88gc1w2dZdoQqGpBLLT6XovGute1pRHykdzTgB75ZyXL3scyOKTCnNm8o3SGzrjHhyAQy1JbvHzHxdq8wtwstY0Qg/BiaSjqf2BHDVUlSuiIzN0eowKCnpQjmUSJwb2F/6KgRm+AR6PZvhwnVmwVFak1HxpGTRQ6eq3LKTvgImg3K88ebAKRBIzyh2WkGgk+Qvga4HgDn1ar626b+fqVGoShDN3EbVtMKjsH2axDmoMJphQGiq8cdj0OGteQYAepc+M4CpIdsGqkHH/kEVa03bxzs0deYmH8PiXl XHkBkHnW sK/J2zDt1m4G3HIgeWS0tQymzN3z7wQxq0Ga2URx8bdv13fdPn4iEISXmkQ+wkuhO/4JlYMgqMeLyN+kr81STNV825BEa6RYe7zI/gXy6V1l3arQMmSfxwct8MuVOTbd22SUqmmB+78gUU904GmUXh8LM/EmQj+1zF1ojP4b3ceQ38tcG1EVW321ijaGNo9DW8A7VWxf9Hadehx15BycITleaefu7lfdDNYaI7ZNRiLL9urqEVKHR3sUdVePtniz3r5qZQkqcvO3icpeIBq981tQmkZq7j/BjsfmCU+jg57hWHVQsvQ2xyuYMeg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000035, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 12:34=E2=80=AFPM T.J. Mercier wrote: > > The root memcg is onlined even when memcg is disabled. When it's onlined > a 2 second periodic stat flush is started, but no stat flushing is > required when memcg is disabled because there can be no child memcgs. > Most calls to flush memcg stats are avoided when memcg is disabled as a > result of the mem_cgroup_disabled check [1] added in [2], but the Remove [1] reference and instead of [2] add the actual commit reference. > periodic flushing started in mem_cgroup_css_online is not. Skip it. > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tr= ee/mm/memcontrol.c?h=3Dv6.8-rc1#n753 > [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/co= mmit/?id=3D7d7ef0a4686abe43cd76a141b340a348f45ecdf2 > > Fixes: aa48e47e3906 ("memcg: infrastructure to flush memcg stats") > Reported-by: Minchan Kim > Signed-off-by: T.J. Mercier Acked-by: Shakeel Butt