From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8757EC47E49 for ; Thu, 31 Oct 2019 19:15:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 329C42080F for ; Thu, 31 Oct 2019 19:15:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="m1JydU/o" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 329C42080F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 937A26B0003; Thu, 31 Oct 2019 15:15:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E0F76B0005; Thu, 31 Oct 2019 15:15:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CFE86B0006; Thu, 31 Oct 2019 15:15:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0122.hostedemail.com [216.40.44.122]) by kanga.kvack.org (Postfix) with ESMTP id 5B7166B0003 for ; Thu, 31 Oct 2019 15:15:14 -0400 (EDT) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id EFCFF52BC for ; Thu, 31 Oct 2019 19:15:13 +0000 (UTC) X-FDA: 76105032906.12.scale89_2da4bba0df206 X-HE-Tag: scale89_2da4bba0df206 X-Filterd-Recvd-Size: 4061 Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 31 Oct 2019 19:15:13 +0000 (UTC) Received: by mail-oi1-f193.google.com with SMTP id n16so6203381oig.2 for ; Thu, 31 Oct 2019 12:15:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eNh+j6pA1KmV8YywH2nQex9CnNTdcwO1xxMow6k+Zbw=; b=m1JydU/odIa+Q+auu5QpdeF+yYeRW+6Fj2x5Qo2bHfYNiNzfKXj9+U/G52wZxzL0b+ pDPOXJ2aq7HAFw3fr0tH7nkyETk9Bl1gW56AxYqb4hH2c963w2db+2RohQggmYOH7hqm hRSehp9Hu2ixU9iISOjGhkTsDD0uL3HOUIVMIVl3tfgEpQv76InKJIdxMHVk4TAySGXV jlkmIxFI2XoyLdEzdz25Yhrbj+qum0vD3XqU2bVIplEr2i0xmzjy4N+ye/SdyGvJ5Qxm o1M/nwZQyg2mRwsWbHtTs40wbgzf3cbFiQci1dY5GXsfHh9kXA2UB+HkJkflCJJcKq0l HJUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eNh+j6pA1KmV8YywH2nQex9CnNTdcwO1xxMow6k+Zbw=; b=CRuyh+yiRWprD7GmNdOse4bdWDvc1q57HavnD8oy6T+4sih7EIB+rME4VKEsJtv8/2 dTFiJGof7gLw0YoF/ZTQBflEDS9TRGv2LlJruawNRYIMdo1mEFh4cXIvLd4ZdO3p3xUL bs0BGkNkYXAx4bUBJb/K7ZJS7DRCfK/7dE/iS9Jqnvjeg9+ubr7FKCg5qDYCju0rpMXX BUWxBUrJ8dBXtTKUQDob37pPBogM0Jyeqi9+Ib96jq+pAl1ZcSdFsYpTvtWbEjhe+rqG ye9G7ITXuhZOtstsjqxTQQY39jjdSNHxqCQsTd0aN8kOH3yngL19ySnQzYVCM/6Bfb/A YLIQ== X-Gm-Message-State: APjAAAWojeh7ZCXD0adnQHzrEHjaHKDae6EwB4zPMxBHewdbOo1GSPdJ DqApaxOAg63TjyqITPY6Tu63TVMKGArm2Idh/OmKYg== X-Google-Smtp-Source: APXvYqz/3RCmY54bYd2Tyj3jL/j3n1V2ZeDMRll4hkTi6GDOn5p7oxA8M3keFDRMqbuQt6q1PC0em3NTyKKS0v+ZXE4= X-Received: by 2002:aca:180e:: with SMTP id h14mr1907505oih.142.1572549312404; Thu, 31 Oct 2019 12:15:12 -0700 (PDT) MIME-Version: 1.0 References: <20191019170141.GQ18794@devbig004.ftw2.facebook.com> <20191024205027.GF3622521@devbig004.ftw2.facebook.com> <11f688a6-0288-0ec4-f925-7b8f16ec011b@gmail.com> <20191031184346.GM3622521@devbig004.ftw2.facebook.com> <20191031190053.GN3622521@devbig004.ftw2.facebook.com> In-Reply-To: <20191031190053.GN3622521@devbig004.ftw2.facebook.com> From: Shakeel Butt Date: Thu, 31 Oct 2019 12:14:58 -0700 Message-ID: Subject: Re: [PATCH v2] net: fix sk_page_frag() recursion from memory reclaim To: Tejun Heo Cc: Eric Dumazet , Michal Hocko , "David S. Miller" , netdev@vger.kernel.org, Kernel Team , LKML , Josef Bacik , Jakub Kicinski , Johannes Weiner , Linux MM , Mel Gorman , Andrew Morton Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Oct 31, 2019 at 12:00 PM Tejun Heo wrote: > > On Thu, Oct 31, 2019 at 11:51:57AM -0700, Shakeel Butt wrote: > > > Yeah, PF_MEMALLOC is likely the better condition to check here as we > > > primarily want to know whether %current might be recursing and that > > > should be indicated reliably with PF_MEMALLOC. Wanna prep a patch for > > > it? > > > > Sure, I will keep your commit message and authorship (if you are ok with it). > > I think the patch already got merged, so it may be easier to do an > incremental one. Oh ok, I will send the incremental one once I have this patch in the mm tree. > > Thanks. > > -- > tejun