From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2057C4707F for ; Tue, 25 May 2021 23:45:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4863B60FDC for ; Tue, 25 May 2021 23:45:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4863B60FDC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A7D766B006C; Tue, 25 May 2021 19:45:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A54876B006E; Tue, 25 May 2021 19:45:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D0166B0070; Tue, 25 May 2021 19:45:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0088.hostedemail.com [216.40.44.88]) by kanga.kvack.org (Postfix) with ESMTP id 516046B006C for ; Tue, 25 May 2021 19:45:42 -0400 (EDT) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id DDE878E70 for ; Tue, 25 May 2021 23:45:41 +0000 (UTC) X-FDA: 78181388082.31.F6BD580 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf24.hostedemail.com (Postfix) with ESMTP id 49FF6A0001C1 for ; Tue, 25 May 2021 23:45:35 +0000 (UTC) Received: by mail-lf1-f48.google.com with SMTP id q3so18543071lfu.2 for ; Tue, 25 May 2021 16:45:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3bWAgXGiiTzRVKYdfnPTxYrHckcttw3uRegUUnWbckY=; b=hhrAWAHsfs4V6Q1rRk+5RzotFe5WWhSfBpNqaVfrq48cm1yZ4mCi/3DHK5lHSGhFsd SmJ1xpnVoC7GwKmpH3GoRruIKeU8Ih6iy6Ws79VyE23+Fo9+g4JbUuKztOnJQ/A75X32 F6tDH6wZDjxQVpUNs2UF0fySZ6sghA7NntIauYgD3MF2VdG4v6OLxVduYDUv5zVgV76d JmwjeX0l2NgUtx/F5ZxGtsUf5xupPKtD5PS/OAlZL4HfxZcTuGUESs0ONaygDVe19cwv FQzPzjRzsZB6Fnrt5Ecm93WJVhOzxD/x/n3M9I7hGisNhSKHzTk/Tm0AJmUjDadrhVhA Z3jw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3bWAgXGiiTzRVKYdfnPTxYrHckcttw3uRegUUnWbckY=; b=eQplRnpwcVCaMVU4P9nno61we/KmullKMh3oGuH51AVAY35uP7e5cu7sg8bhDmw/MF hJdF3eand7TOlOPrPGR3lt4hoasUkJ/yyOSNl/HYnA124XOSLrXfvq3x4TNdEC7vxR5Z 3GH3HAVD9PGi3SkJSaLpmL21dsmGd01iuDfOx/YAmMK5lnqRTxkBNHvlikyb7EY2hDgP W+FR6XzsRWjC5pnOkGcBBHSz7e9DZY+7uO6j4CS+G5vp+DbwFDv3V78wzQjEPewLQD7a 8xmYCstdT+Z/smv57hSO+gpEGJ7ooNOESi2eKbyZ8ICixzWHM/18PRd4mugGKKJXb71l faDA== X-Gm-Message-State: AOAM531uHk9i2OY+4i856n6gdIvW64uJ9/HgChmJdGrdHX4d1m8WvM0L GN1q8a+uCFrioTNE1lcw+ZOdrzXqpoDqBvj5b7LJfQ== X-Google-Smtp-Source: ABdhPJy9hB4q6/cvtU+d+uGxv+1Wbe3+B9NkI4vv8arO0VwtZXiweVdebha1FQ1CcW8CnxfqxV9Z3KwiBdSb7es7wjA= X-Received: by 2002:a05:6512:3da3:: with SMTP id k35mr69007lfv.347.1621986339891; Tue, 25 May 2021 16:45:39 -0700 (PDT) MIME-Version: 1.0 References: <20210524132725.12697-1-apopple@nvidia.com> <20210524132725.12697-4-apopple@nvidia.com> <20210525183710.fa2m2sbfixnhz7g5@revolver> In-Reply-To: <20210525183710.fa2m2sbfixnhz7g5@revolver> From: Shakeel Butt Date: Tue, 25 May 2021 16:45:28 -0700 Message-ID: Subject: Re: [PATCH v9 03/10] mm/rmap: Split try_to_munlock from try_to_unmap To: Liam Howlett Cc: Alistair Popple , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "nouveau@lists.freedesktop.org" , "bskeggs@redhat.com" , "rcampbell@nvidia.com" , "linux-doc@vger.kernel.org" , "jhubbard@nvidia.com" , "bsingharora@gmail.com" , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "hch@infradead.org" , "jglisse@redhat.com" , "willy@infradead.org" , "jgg@nvidia.com" , "peterx@redhat.com" , "hughd@google.com" , Christoph Hellwig Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=hhrAWAHs; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf24.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.48 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Stat-Signature: d6xxbw836pb3r77kfut74zzgbkxo1key X-Rspamd-Queue-Id: 49FF6A0001C1 X-Rspamd-Server: rspam02 X-HE-Tag: 1621986335-49872 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 25, 2021 at 11:40 AM Liam Howlett wrote: > [...] > > > > +/* > > + * Walks the vma's mapping a page and mlocks the page if any locked vma's are > > + * found. Once one is found the page is locked and the scan can be terminated. > > + */ > > Can you please add that this requires the mmap_sem() lock to the > comments? > Why does this require mmap_sem() lock? Also mmap_sem() lock of which mm_struct? > > +static bool page_mlock_one(struct page *page, struct vm_area_struct *vma, > > + unsigned long address, void *unused) > > +{ > > + struct page_vma_mapped_walk pvmw = { > > + .page = page, > > + .vma = vma, > > + .address = address, > > + }; > > + > > + /* An un-locked vma doesn't have any pages to lock, continue the scan */ > > + if (!(vma->vm_flags & VM_LOCKED)) > > + return true; > > + > > + while (page_vma_mapped_walk(&pvmw)) { > > + /* PTE-mapped THP are never mlocked */ > > + if (!PageTransCompound(page)) > > + mlock_vma_page(page); > > + page_vma_mapped_walk_done(&pvmw); > > + > > + /* > > + * no need to continue scanning other vma's if the page has > > + * been locked. > > + */ > > + return false; > > + } > > + > > + return true; > > +}