From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1694C433E0 for ; Tue, 9 Mar 2021 21:16:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2E96165250 for ; Tue, 9 Mar 2021 21:16:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E96165250 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B3C678D0146; Tue, 9 Mar 2021 16:16:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AEF058D012A; Tue, 9 Mar 2021 16:16:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B4DE8D0146; Tue, 9 Mar 2021 16:16:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0157.hostedemail.com [216.40.44.157]) by kanga.kvack.org (Postfix) with ESMTP id 7F1DA8D012A for ; Tue, 9 Mar 2021 16:16:27 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 39551181AF5E6 for ; Tue, 9 Mar 2021 21:16:27 +0000 (UTC) X-FDA: 77901594414.13.6A1752F Received: from mail-lf1-f50.google.com (mail-lf1-f50.google.com [209.85.167.50]) by imf26.hostedemail.com (Postfix) with ESMTP id 61FD74080F7E for ; Tue, 9 Mar 2021 21:16:24 +0000 (UTC) Received: by mail-lf1-f50.google.com with SMTP id f1so29727138lfu.3 for ; Tue, 09 Mar 2021 13:16:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=9PsluCVuRlwvVpNmgjT1JznCkDbja9NK57IpaWk5p74=; b=s9lSAd8/iLOVzNXJ7+zZuVfjKgIHufi60spr/JHD99zdcQQdCEksF2j31Dx6t/wwuP 1wrCwtpVz1KdKPmmrFOO1CKrycTKe56F/duuPJGBV/Vp2CC8N9rrrYTEgB/CHKP9zYCh vDo0AEVMlM/0FzE6O3FCardeV9kZo+0kCYcBsBywe4XgaB4L7ooh+MumK5xlMyFG1BrF HNMLfOtoqAx6uzYa3aJu6VMtoQZp8qmkXTSFA2y2bjngSrrUZw3gBANXnNbsrBBL1pb5 MHEZbKMnKFF1HArMQmutIp1QsEC6mFU7A0Wo5hSkFpky5oPudWVAvLqxTmRLbZ2GwnAx e5Ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=9PsluCVuRlwvVpNmgjT1JznCkDbja9NK57IpaWk5p74=; b=So5P63Cc7AJuJBJD9ZYGy8MQcNi7tkGoiSefvV/DVRMQCupQwKRb2VuBRBZzG5egPh g0YIlVAnS5dU83TuvrneuVAxZ30Q0L2/kLzolBHnvXB5DofKh2Wn1M07opJhyEPLb+MJ dlVq2al1GkicyfkYLrtjN509DduMEoa2Ojwv5E87QYlpqT3yOqwrrxMDRJZPqTnmI2fU Phfz9Fc1AAjuIX6yBOMcA3vrkwdfBet/8auz6zrfCbTidrSWw/hRI3ZomBavlQNPLRm7 7safxESNdgKFuSTM1eoW6oF84fpbj9fi6EqM1G7uQsojejsUZjVuNOE6CAtUZPZICq+K pymg== X-Gm-Message-State: AOAM533vVc5l/dLRnEgqyKOXWH+9GzKIWBTcsghwbwtrmpNS5lvWNgQB 6wQQbjaI5JzSdNag9slSfKxvWYUJzGdH8DYQOeKYUQ== X-Google-Smtp-Source: ABdhPJwfdlXSlduZFjgFKGttJiSWF9iGYdLHN3WPCGkZM9CjZYvnf8hd9rHsiDNOZSL65l+JAzSlmNr/+Wa3/sB5CUk= X-Received: by 2002:a19:ee19:: with SMTP id g25mr18074769lfb.83.1615324585083; Tue, 09 Mar 2021 13:16:25 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Shakeel Butt Date: Tue, 9 Mar 2021 13:16:13 -0800 Message-ID: Subject: Re: [PATCH 2/9] memcg: accounting for fib6_nodes cache To: Vasily Averin Cc: Cgroups , Linux MM , Johannes Weiner , Michal Hocko , Vladimir Davydov Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: jzs79fpkhguxqjgcdbhndqg19ut4yhra X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 61FD74080F7E Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=mail-lf1-f50.google.com; client-ip=209.85.167.50 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615324584-345923 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 9, 2021 at 12:04 AM Vasily Averin wrote: > > Objects can be created from memcg-limited tasks > but its misuse may lead to host OOM. > > Signed-off-by: Vasily Averin > --- > net/ipv6/ip6_fib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c > index ef9d022..fa92ed1 100644 > --- a/net/ipv6/ip6_fib.c > +++ b/net/ipv6/ip6_fib.c > @@ -2445,7 +2445,7 @@ int __init fib6_init(void) > > fib6_node_kmem = kmem_cache_create("fib6_nodes", Can you talk a bit more about the lifetime of the object created from this kmem cache? Also who and what operation can trigger allocation? Similarly can you add this information to the remaining patches of your series as well? > sizeof(struct fib6_node), > - 0, SLAB_HWCACHE_ALIGN, > + 0, SLAB_HWCACHE_ALIGN|SLAB_ACCOUNT, > NULL); > if (!fib6_node_kmem) > goto out; > -- > 1.8.3.1 >