From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23FA9C07E9D for ; Mon, 26 Sep 2022 17:33:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 577A28E0074; Mon, 26 Sep 2022 13:33:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 527378E0066; Mon, 26 Sep 2022 13:33:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C7748E0074; Mon, 26 Sep 2022 13:33:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 285E48E0066 for ; Mon, 26 Sep 2022 13:33:02 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B413D8012C for ; Mon, 26 Sep 2022 17:33:01 +0000 (UTC) X-FDA: 79954932162.21.5B39F7E Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf11.hostedemail.com (Postfix) with ESMTP id 3F68840009 for ; Mon, 26 Sep 2022 17:33:01 +0000 (UTC) Received: by mail-yb1-f171.google.com with SMTP id 63so9302807ybq.4 for ; Mon, 26 Sep 2022 10:33:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=TOL7/M5VC7IyaSB3mrG/Ev31pWD9V/lWqppYMcTBfKM=; b=p6wexZ/Y0XqAhWAhWQ77q6u0CZ18nCzFEAe4bvVo7S0nEW6WuU84QbuIrXyLDHCaTI 3KVY8/kPjnuU77CzmlnP2RX4B3VTuD+DX8rWAEp9ezkmsub624war7PTzocq0HhayQIP GMxA2Fj0qaw1SQGShM7S0FWzngjRfNeVBrilh6JsDYrekTU3j+x+9dO9Jg8FhujrX5gZ /TgpCO0SU+Id76XQMhc88uxX0Gxua10lmdNBqa+I4rCCzSzqO6kIbK1MKmXUlUBcdR1P LOKdsKRMbjEv0YfhCObzK+sUJ9DWdA8R5U5Pli/Q77cTZRdgCOChdjHXdIV50NkngFID P8Ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=TOL7/M5VC7IyaSB3mrG/Ev31pWD9V/lWqppYMcTBfKM=; b=y+HqrgTg1tJBpnsj/ofcTMqUZRZFeoO2S0eNFeb69lgtFM7DcwC6gCwQg4pJ7gyiFn RfwnZq1F0TidD8RVStfm2lfyVV1wH9IxsRZsXIndRRMkrHqCRByK9IXfhjm8kXLlwEeG fbXwg3J2xN0TWvYUnX06xxFe56W5USvmKADUIgficd6XghW+6BOCLzbX0NKmM2b5R5uS HCnotnNYkh+ALRC+J62wG21eBpsr97HwGFQgr/Q1atYPRo70W0tu9+vXknvHQGku6m1I P7OHoKkPxjjQ9g8THDYbhqB9BZ90NEZPD7gWx+SUgkM8QtTSYaZcxWx2kYczhrC5OuWS HUXw== X-Gm-Message-State: ACrzQf2jCBVmmX+XZCrpwuTwxRlA8bOhvan9SoLVFJaB5p9/MA7n2316 4heVD3TpckLC+AyUIP2X5CIkw3v1TxFW9Nj6/GvJ0Q== X-Google-Smtp-Source: AMsMyM72814D3Zid3Z4+5u+XXaRlAxLN2FtAB0S1kLY4fcWKgXglodA5Dypmeb7prlduUu0gUuE2/e2P2QvoFQP/RfA= X-Received: by 2002:a05:6902:102c:b0:6b4:86ac:1436 with SMTP id x12-20020a056902102c00b006b486ac1436mr21059512ybt.368.1664213580392; Mon, 26 Sep 2022 10:33:00 -0700 (PDT) MIME-Version: 1.0 References: <6b362c6e-9c80-4344-9430-b831f9871a3c@openvz.org> <20220918092849.GA10314@u164.east.ru> <20220921170259.GI8331@blackbody.suse.cz> <20220926102812.2b0696a7@kernel.org> In-Reply-To: <20220926102812.2b0696a7@kernel.org> From: Shakeel Butt Date: Mon, 26 Sep 2022 10:32:49 -0700 Message-ID: Subject: Re: [sparc64] fails to boot, (was: Re: [PATCH memcg v6] net: set proper memcg for net_init hooks allocations) To: Jakub Kicinski Cc: Vasily Averin , Anatoly Pugachev , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Andrew Morton , kernel@openvz.org, Linux Kernel list , linux-mm , Roman Gushchin , Vlastimil Babka , Michal Hocko , Florian Westphal , "David S. Miller" , Paolo Abeni , Eric Dumazet , Cgroups , Sparc kernel list , Thorsten Leemhuis , Linus Torvalds Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="p6wexZ/Y"; spf=pass (imf11.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664213581; a=rsa-sha256; cv=none; b=C6D3i7ubFZV4M1JHM97/8z8598EfhfAi0iyDK0CbpX/Y7z0d4ObrwVpKXucIvGGRJPxuLk zw/LTDX4aMdOnRTGgSPQE4SMI92ckyusn8NAgpLV0caXO53QcvkpyoYTXDewPzKvA7pzqR ZbSOqw0eGNYs08ZW9orPTxf3G4HsW9Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664213581; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TOL7/M5VC7IyaSB3mrG/Ev31pWD9V/lWqppYMcTBfKM=; b=HPbUxjKQxoPywgLTbs2h1hFVasm26P0A1rKU1RWTBjz2Y3WpakMijMgcUOwuk1NcFfXNpy jmaod2M9BNBj7kApLQUc2DLqGI7sNeCt/QGK9PUY7GaF+dq77q0mv+MvzU7afM9rclVVfd T1tFqJMapKBTqfhv/HCnpyTECcXegRM= X-Stat-Signature: w6xoh63hwc6wqrmcgndwx3n4ubuz4mcy X-Rspamd-Queue-Id: 3F68840009 Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="p6wexZ/Y"; spf=pass (imf11.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.171 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-Rspamd-Server: rspam07 X-HE-Tag: 1664213581-3326 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 26, 2022 at 10:28 AM Jakub Kicinski wrote: > > On Mon, 26 Sep 2022 16:06:08 +0300 Anatoly Pugachev wrote: > > On Wed, Sep 21, 2022 at 8:03 PM Michal Koutn=C3=BD w= rote: > > > On Wed, Sep 21, 2022 at 05:44:56PM +0300, Anatoly Pugachev wrote: > > > > reverting this patch makes my sparc64 box boot successfully. > > > > > > The failed address falls into vmmemmap region (per your boot log > > > output). It looks like the respective page/folio (of init_net struct)= is > > > unbacked there (and likely folio_test_slab fails dereferencing ->flag= s). > > > > > > Would you mind sharing your kernel's config? > > > (I'm most curious about CONFIG_SPARSMEM_VMEMMAP, I'm not familiar wit= h > > > your arch at all though.) > > > > mator@ttip:~/dmesg$ zcat config-6.0.0-rc6-00010-gb7f0f527dc3c.gz | grep= VMEMMAP > > CONFIG_SPARSEMEM_VMEMMAP_ENABLE=3Dy > > CONFIG_SPARSEMEM_VMEMMAP=3Dy > > > > I do upload config and boot logs to > > https://github.com/mator/sparc64-dmesg > > > > building a new kernel version/releases as 'make olddefconfig && make -j= ' > > current version of booted 6.0.0-rc6 is available as > > https://github.com/mator/sparc64-dmesg/blob/master/config-6.0.0-rc6-000= 10-gb7f0f527dc3c.gz > > Forgive my uniformed chime-in but Linus seemed happy with the size of > -rc7 and now I'm worried there won't be an -rc8. AFAICT this is a 6.0 > regression. Vasily, Shakeel, do we have a plan to fix this? I was actually waiting for Vasily to respond. Anyways, I think the easiest way to proceed is to revert the commit 1d0403d20f6c ("net: set proper memcg for net_init hooks allocations"). We can debug the issue in the next cycle.