From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1637C433EF for ; Tue, 19 Oct 2021 05:33:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5EAF66115B for ; Tue, 19 Oct 2021 05:33:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5EAF66115B Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 97FE2900002; Tue, 19 Oct 2021 01:33:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 92F2D6B0071; Tue, 19 Oct 2021 01:33:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7F67A900002; Tue, 19 Oct 2021 01:33:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id 6E60D6B006C for ; Tue, 19 Oct 2021 01:33:39 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 302948249980 for ; Tue, 19 Oct 2021 05:33:39 +0000 (UTC) X-FDA: 78712069758.17.DD0CFB4 Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com [209.85.219.182]) by imf20.hostedemail.com (Postfix) with ESMTP id EF42DD0000A6 for ; Tue, 19 Oct 2021 05:33:35 +0000 (UTC) Received: by mail-yb1-f182.google.com with SMTP id r184so1701014ybc.10 for ; Mon, 18 Oct 2021 22:33:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=C7/p+vFvGASSiKGffZhdGt/JdSw4hI/EUKyQnYFmEkw=; b=R8AfSmX79UsAfHg1g2OmvvNlzzAI+3R1AunnM0Qd9AaY4W4mCP+OnI1q/Y1SOS+amL 4tYtrwcUCTiXH4srQCq0AHRjIJTcYDiIR/6J3DIDup7Cjf9RkGzF/DCrqzqq3qhi1gFJ 1vrHiFTCvwfIgK8uuyo+64h58L0TycsJfWW3IwgaJfGm4H3PhM5YlXETYZtBNrRj0OmG N1MuNqzyVCe/HfolLlUm0PSkqgoV5vS6m4Alp3OgKK14xLR3/jOeqEraYWCSTlMsTnPx mjsW1egWTUuhKT4dkM7NatNC8k1ft80SHBtPrgEbaM42exrExjdvWMlSsqthwIyx20q7 FgXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=C7/p+vFvGASSiKGffZhdGt/JdSw4hI/EUKyQnYFmEkw=; b=mMnxHgvUCtimVXIMXku4HFPPYYm5SLe7VmNCXAtHW9xacrNhtxd/hwhHAdtaVTgfwY t5DCOPt/EragdWtvafjGkTCnfIfe8HS1dMcIFzNMBxVZhi/jK72EzL2PP+oXaVpzNC5P io7xku4NwwlUwhcbhJ5JDtmsNT1o3Z0MeUITlBdgVk+c+hkGW2J29VY7TT7/mau6Dctb mMIje3GYZAnSnBAiMBt3ho7hdxTs+PoLqyC2NYiDORotSz75QVhnA3O1FkbiqQEASUNu ITQFH/bNi6jae7VSBnNkOz2/AbKAkYlBSIgzgpwuz9nx2YRufGLNhCKUKJ0BczmaeDER HZBg== X-Gm-Message-State: AOAM530lw0Z2SMQeMoAgfhYXg06B/cYZRtBnspV6cIMUnegNhaXPWpv3 17DAv6Zx+I5Ws1Dxi/FOnGZzHWqcdmXqDpR1kkzJ7w== X-Google-Smtp-Source: ABdhPJxt4GTR5JrDEaV4ulWRIivaZMkeRJT6tNSWwwTVpjf7Di5+t/4A4DPVYsi5GRmjL2KD5x2mTPnJunwpg3wKM2w= X-Received: by 2002:a25:e809:: with SMTP id k9mr36301806ybd.104.1634621616929; Mon, 18 Oct 2021 22:33:36 -0700 (PDT) MIME-Version: 1.0 References: <9d10df01-0127-fb40-81c3-cc53c9733c3e@virtuozzo.com> <6b751abe-aa52-d1d8-2631-ec471975cc3a@virtuozzo.com> <27dc0c49-a0d6-875b-49c6-0ef5c0cc3ac8@virtuozzo.com> <153f7aa6-39ef-f064-8745-a9489e088239@virtuozzo.com> In-Reply-To: <153f7aa6-39ef-f064-8745-a9489e088239@virtuozzo.com> From: Shakeel Butt Date: Mon, 18 Oct 2021 22:33:25 -0700 Message-ID: Subject: Re: [PATCH memcg 0/1] false global OOM triggered by memcg-limited task To: Vasily Averin Cc: Michal Hocko , Johannes Weiner , Vladimir Davydov , Andrew Morton , Roman Gushchin , Uladzislau Rezki , Vlastimil Babka , Mel Gorman , Cgroups , Linux MM , LKML , kernel@openvz.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EF42DD0000A6 X-Stat-Signature: x4mgxxh8wyffqb6x8doeyue59y546mxg Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=R8AfSmX7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.182 as permitted sender) smtp.mailfrom=shakeelb@google.com X-HE-Tag: 1634621615-760048 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 18, 2021 at 11:52 AM Vasily Averin wrote: > > On 18.10.2021 18:07, Shakeel Butt wrote: > > On Mon, Oct 18, 2021 at 5:27 AM Michal Hocko wrote: > >> > >> [restore the cc list] > >> > >> On Mon 18-10-21 15:14:26, Vasily Averin wrote: > >>> On 18.10.2021 14:53, Michal Hocko wrote: > >>>> On Mon 18-10-21 13:05:35, Vasily Averin wrote: > >>>>> On 18.10.2021 12:04, Michal Hocko wrote: > >>>>> Here we call try_charge_memcg() that return success and approve the allocation, > >>>>> however then we hit into kmem limit and fail the allocation. > >>>> > >>>> Just to make sure I understand this would be for the v1 kmem explicit > >>>> limit, correct? > >>> > >>> yes, I mean this limit. > >> > >> OK, thanks for the clarification. This is a known problem. Have a look > >> at I think we consider that one to 0158115f702b ("memcg, kmem: deprecate > >> kmem.limit_in_bytes"). We are reporting the deprecated and to-be removed > >> status since 2019 without any actual report sugested by the kernel > >> message. Maybe we should try and remove it and see whether that prompts > >> some pushback. > >> > > > > Yes, I think now should be the right time to take the next step for > > deprecation of kmem limits: > > https://lore.kernel.org/all/20201118175726.2453120-1-shakeelb@google.com/ > > Are you going to push it to stable kernels too? > Not really. Is there a reason I should? More exposure to catch breakage?