From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AF08C433E2 for ; Thu, 10 Sep 2020 16:02:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A1A6220BED for ; Thu, 10 Sep 2020 16:02:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="i6hq+vV9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A1A6220BED Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DCC076B0002; Thu, 10 Sep 2020 12:02:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D54296B005A; Thu, 10 Sep 2020 12:02:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1C1E8E0005; Thu, 10 Sep 2020 12:02:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0099.hostedemail.com [216.40.44.99]) by kanga.kvack.org (Postfix) with ESMTP id A99636B0002 for ; Thu, 10 Sep 2020 12:02:52 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5CE0D82499B9 for ; Thu, 10 Sep 2020 16:02:52 +0000 (UTC) X-FDA: 77247620184.25.bean59_3b0c9ca270e7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id 615A61804E52C for ; Thu, 10 Sep 2020 16:02:45 +0000 (UTC) X-HE-Tag: bean59_3b0c9ca270e7 X-Filterd-Recvd-Size: 6537 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Thu, 10 Sep 2020 16:02:07 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id y4so8844453ljk.8 for ; Thu, 10 Sep 2020 09:02:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gXFL8zxGAkEAFklyf5PNn/rioB+MLXLEPv+A6IYV3Is=; b=i6hq+vV98YA8q8Wcq6doLG+y5wjiyjWWL96kdQw0H+jDMxeA9Mj+NVqTkSuQ8Cvuzi 66mGBRjmRbCe9uCMwVNKAt1PgIRZYmt68YEjOSvJPvvH8zdiyELwSOGs7GgYgWzw54ws MC8K5MYJ8ipMU0WZOqCAicBPqNbNhDMXRBDNFnCsWb6RoO0DyJQhfzijsLqCQrq9YBtU TATSHj1U8l9J2pHnmzcIKjevg8aAQtqDezGDeSRun2tajWl072+qD4mHPnB/Uk28jBej gD8NcxlU7ER8jI+FCE4AYxqnIymDHUbxmHzJfKUTcK43WNeC0qU86q+M9AU+YtZ2sYec 4pBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gXFL8zxGAkEAFklyf5PNn/rioB+MLXLEPv+A6IYV3Is=; b=IP9fyhLl9JBMJsmxfTmLQek5MU4iiQzr+IsviLr5zIbNDOGNpbfeEmRM4fStvfWIFz HoNbGj6RK1b1IHSDsbzBP/wMfry9zy57spGqu//lkPzKBWzwZF/2TKQbGSWPifRyvJYV EV1iMSa72ISS/2EP+AawhqvhA26arWddxl6tOIyhD9LPG0EWA1r6xGWm10YVR0BZ8+KN wGBTBwfqWe7ZoN+F9OuyHah3+DpTHTOsX5JuvKOR1NIvqpIlJdOIHYFnW2hbEtHX5Q1K ZylSK2AL5zqnKZXbU4AWm8Kc9OBKr0Oc7DvOcGKlT72IYwwoDx9XBGZ7bdt9VxPwbFB/ andg== X-Gm-Message-State: AOAM532kdkwImnrynl0bJVJQEGbvFkuWwiBMUiCtmjQshUFzzUI+aDdl 7O9lu1s42Bd7daT2J3pYM7m8u4JQgIkKSTIkSSs8+Q== X-Google-Smtp-Source: ABdhPJz54WOPqVjLoiOAMEPFyivI7Bk2NO3KuFh9RoqJBEjdb4PNOM4gxm78bc2Klo+DIfoL656LWL7Khq/ccs7aPG0= X-Received: by 2002:a2e:92d6:: with SMTP id k22mr5137971ljh.332.1599753725639; Thu, 10 Sep 2020 09:02:05 -0700 (PDT) MIME-Version: 1.0 References: <20200910084258.22293-1-songmuchun@bytedance.com> In-Reply-To: <20200910084258.22293-1-songmuchun@bytedance.com> From: Shakeel Butt Date: Thu, 10 Sep 2020 09:01:54 -0700 Message-ID: Subject: Re: [PATCH] mm: memcontrol: Add the missing numa stat of anon and file for cgroup v2 To: Muchun Song Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Cgroups , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 615A61804E52C X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 10, 2020 at 1:46 AM Muchun Song wrote: > > In the cgroup v1, we have a numa_stat interface. This is useful for > providing visibility into the numa locality information within an > memcg since the pages are allowed to be allocated from any physical > node. One of the use cases is evaluating application performance by > combining this information with the application's CPU allocation. > But the cgroup v2 does not. So this patch adds the missing information. > > Signed-off-by: Muchun Song > --- I am actually working on exposing this info on v2 as well. > mm/memcontrol.c | 46 ++++++++++++++++++++++++++++++++++++++++++++-- > 1 file changed, 44 insertions(+), 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 75cd1a1e66c8..c779673f29b2 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1492,10 +1492,34 @@ static bool mem_cgroup_wait_acct_move(struct mem_cgroup *memcg) > return false; > } > > +#ifdef CONFIG_NUMA > +static unsigned long memcg_node_page_state(struct mem_cgroup *memcg, > + unsigned int nid, > + enum node_stat_item idx) > +{ > + long x; > + struct mem_cgroup_per_node *pn; > + struct lruvec *lruvec = mem_cgroup_lruvec(memcg, NODE_DATA(nid)); > + > + VM_BUG_ON(nid >= nr_node_ids); > + > + pn = container_of(lruvec, struct mem_cgroup_per_node, lruvec); > + x = atomic_long_read(&pn->lruvec_stat[idx]); > +#ifdef CONFIG_SMP > + if (x < 0) > + x = 0; > +#endif > + return x; > +} > +#endif > + > static char *memory_stat_format(struct mem_cgroup *memcg) > { > struct seq_buf s; > int i; > +#ifdef CONFIG_NUMA > + int nid; > +#endif > > seq_buf_init(&s, kmalloc(PAGE_SIZE, GFP_KERNEL), PAGE_SIZE); > if (!s.buffer) > @@ -1512,12 +1536,30 @@ static char *memory_stat_format(struct mem_cgroup *memcg) > * Current memory state: > */ > Let's not break the parsers of memory.stat. I would prefer a separate interface like v1 i.e. memory.numa_stat. > - seq_buf_printf(&s, "anon %llu\n", > + seq_buf_printf(&s, "anon %llu", > (u64)memcg_page_state(memcg, NR_ANON_MAPPED) * > PAGE_SIZE); > - seq_buf_printf(&s, "file %llu\n", > +#ifdef CONFIG_NUMA > + for_each_node_state(nid, N_MEMORY) > + seq_buf_printf(&s, " N%d=%llu", nid, > + (u64)memcg_node_page_state(memcg, nid, > + NR_ANON_MAPPED) * > + PAGE_SIZE); > +#endif > + seq_buf_putc(&s, '\n'); > + > + seq_buf_printf(&s, "file %llu", > (u64)memcg_page_state(memcg, NR_FILE_PAGES) * > PAGE_SIZE); > +#ifdef CONFIG_NUMA > + for_each_node_state(nid, N_MEMORY) > + seq_buf_printf(&s, " N%d=%llu", nid, > + (u64)memcg_node_page_state(memcg, nid, > + NR_FILE_PAGES) * > + PAGE_SIZE); > +#endif > + seq_buf_putc(&s, '\n'); > + The v1's numa_stat exposes the LRUs, why NR_ANON_MAPPED and NR_FILE_PAGES? Also I think exposing slab_[un]reclaimable per node would be beneficial as well. > seq_buf_printf(&s, "kernel_stack %llu\n", > (u64)memcg_page_state(memcg, NR_KERNEL_STACK_KB) * > 1024); > -- > 2.20.1 >