From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F262C433DB for ; Tue, 9 Feb 2021 19:14:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DA5A864ECB for ; Tue, 9 Feb 2021 19:14:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA5A864ECB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 46BB76B0005; Tue, 9 Feb 2021 14:14:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4418C6B006C; Tue, 9 Feb 2021 14:14:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37F4B6B006E; Tue, 9 Feb 2021 14:14:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0004.hostedemail.com [216.40.44.4]) by kanga.kvack.org (Postfix) with ESMTP id 2317F6B0005 for ; Tue, 9 Feb 2021 14:14:28 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DEA371854AEA2 for ; Tue, 9 Feb 2021 19:14:27 +0000 (UTC) X-FDA: 77799680574.22.soap07_5b0daa927609 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id BD0691807F1E1 for ; Tue, 9 Feb 2021 19:14:27 +0000 (UTC) X-HE-Tag: soap07_5b0daa927609 X-Filterd-Recvd-Size: 3662 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by imf33.hostedemail.com (Postfix) with ESMTP for ; Tue, 9 Feb 2021 19:14:27 +0000 (UTC) Received: by mail-lj1-f182.google.com with SMTP id f8so14162276ljk.3 for ; Tue, 09 Feb 2021 11:14:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QiJbgc9uHQ4f7W9ot8GPf8bOPMHTjKS9chqsEgTJBXQ=; b=aNt936Uv5Pvb6XQyxVTyRfAnfZ4ie1FmlBY1FQeJsxtYKLmNSiV6vXfHjBBMUbV1TF vAdVGuFF2gxHUeArYS7K5dGfF5h9bjgRekHi6vlCTWcU3fPjS+U2MHDsHr+ozwL7SaEr D0tJffRY9XfrfIe6l7575nvi9Us1sSmKobpXfhcU7+t4peARscWC84AkXKcgs7uKjTRs 0SSxSTq1Wo7YMDuK44FS1hFJ5EyTt3oI1Ts4V2szLeRF7iP95Q1cbNDBlzrDeEwzzBNt yTBDNRbD8kKBKhH68sI9SGjK+ZZFSclPWx4KvW2I5tXDqVTZEUP3nC4Gufdt6z9QnDO+ f9pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QiJbgc9uHQ4f7W9ot8GPf8bOPMHTjKS9chqsEgTJBXQ=; b=LqNv08juRCOOZGITEeBsmNXiYgC1gIDzHYoHw9NcLxsG4/b7N6w6XZc5x1GQcU5Hlr hwApwqz1f6GV3m5jHVa9n3hxjNXTQk/YQjoSGYrfPhnSbW6v7Y6acnobVxW4mSPfxPdI pDdgBIstDCYj+7GzV/8tpVm/NzNFkj9HHSix4kMiiOaJDO7IURVtnthtBjHMt4mo3J60 ChIpa1ZdXNKlKbRWxMFV2NXOuTizRPO4QOU5aTGBjW4/5vyJSXO+R8RcIP9DVJoF4wpX M7WspDkPKsyPj77spSiHUxzil7+O1K4ECHVbQRT9MZe30WTG2o4HNvLBqXLHP2s8Bxk4 bqVA== X-Gm-Message-State: AOAM533yisNEGecTBC0Ejwp6X58Bt7uaA8ssyqr3oha1GqqqA3Z2vrkT AerR8q30TAKtcECAkCov8ayUIyfO3Bg/q+Chhi76SQ== X-Google-Smtp-Source: ABdhPJxA1PuqJnhzJJquwIJYOw1w6vzUPL6lOhcqipVzLiGXTT0J1IbS4/X7mBrqEmgsqlRWSB6ZGIU8jyhW4WcwhSQ= X-Received: by 2002:a2e:9801:: with SMTP id a1mr16086206ljj.122.1612898065894; Tue, 09 Feb 2021 11:14:25 -0800 (PST) MIME-Version: 1.0 References: <20210209174646.1310591-1-shy828301@gmail.com> <20210209174646.1310591-2-shy828301@gmail.com> In-Reply-To: <20210209174646.1310591-2-shy828301@gmail.com> From: Shakeel Butt Date: Tue, 9 Feb 2021 11:14:14 -0800 Message-ID: Subject: Re: [v7 PATCH 01/12] mm: vmscan: use nid from shrink_control for tracepoint To: Yang Shi Cc: Roman Gushchin , Kirill Tkhai , Vlastimil Babka , Dave Chinner , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , linux-fsdevel , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 9, 2021 at 9:47 AM Yang Shi wrote: > > The tracepoint's nid should show what node the shrink happens on, the start tracepoint > uses nid from shrinkctl, but the nid might be set to 0 before end tracepoint if the > shrinker is not NUMA aware, so the traceing tracing > log may show the shrink happens on one > node but end up on the other node. It seems confusing. And the following patch > will remove using nid directly in do_shrink_slab(), this patch also helps cleanup > the code. > > Acked-by: Vlastimil Babka > Acked-by: Kirill Tkhai > Signed-off-by: Yang Shi Reviewed-by: Shakeel Butt