From: Shakeel Butt <shakeelb@google.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>, Kernel Team <kernel-team@fb.com>,
Tejun Heo <tj@kernel.org>, Johannes Weiner <hannes@cmpxchg.org>,
Chris Down <chris@chrisdown.name>,
Cgroups <cgroups@vger.kernel.org>,
Michal Hocko <mhocko@kernel.org>
Subject: Re: [PATCH mm v3 3/3] mm: automatically penalize tasks with high swap use
Date: Mon, 18 May 2020 18:10:33 -0700 [thread overview]
Message-ID: <CALvZod5G=ZG2DeGGxPD8vhqmeLz4_cxS5GUaTdOiGKLkgk9s6g@mail.gmail.com> (raw)
In-Reply-To: <20200518174249.745e66d1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
On Mon, May 18, 2020 at 5:42 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Sun, 17 May 2020 06:44:52 -0700 Shakeel Butt wrote:
> > > @@ -2583,12 +2606,23 @@ static int try_charge(struct mem_cgroup *memcg, gfp_t gfp_mask,
> > > * reclaim, the cost of mismatch is negligible.
> > > */
> > > do {
> > > - if (page_counter_read(&memcg->memory) > READ_ONCE(memcg->high)) {
> > > - /* Don't bother a random interrupted task */
> > > - if (in_interrupt()) {
> > > + bool mem_high, swap_high;
> > > +
> > > + mem_high = page_counter_read(&memcg->memory) >
> > > + READ_ONCE(memcg->high);
> > > + swap_high = page_counter_read(&memcg->swap) >
> > > + READ_ONCE(memcg->swap_high);
> > > +
> > > + /* Don't bother a random interrupted task */
> > > + if (in_interrupt()) {
> > > + if (mem_high) {
> > > schedule_work(&memcg->high_work);
> > > break;
> > > }
> > > + continue;
> >
> > break?
>
> On a closer look I think continue is correct. In irq we only care
> about mem_high, because there's nothing we can do in a work context
> to penalize swap. So the loop is shortened.
>
Yes, you are right.
prev parent reply other threads:[~2020-05-19 1:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 20:20 [PATCH mm v3 0/3] memcg: Slow down swap allocation as the available space gets depleted Jakub Kicinski
2020-05-15 20:20 ` [PATCH mm v3 1/3] mm: prepare for swap over-high accounting and penalty calculation Jakub Kicinski
2020-05-15 20:20 ` [PATCH mm v3 2/3] mm: move penalty delay clamping out of calculate_high_delay() Jakub Kicinski
2020-05-15 20:20 ` [PATCH mm v3 3/3] mm: automatically penalize tasks with high swap use Jakub Kicinski
2020-05-17 13:44 ` Shakeel Butt
2020-05-18 19:42 ` Jakub Kicinski
2020-05-18 19:58 ` Shakeel Butt
2020-05-19 0:42 ` Jakub Kicinski
2020-05-19 1:10 ` Shakeel Butt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALvZod5G=ZG2DeGGxPD8vhqmeLz4_cxS5GUaTdOiGKLkgk9s6g@mail.gmail.com' \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=chris@chrisdown.name \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=kuba@kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox