From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 601DDC28CBC for ; Sat, 9 May 2020 14:07:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1D5C32072F for ; Sat, 9 May 2020 14:07:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="uF4uQoe+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D5C32072F Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9F738900007; Sat, 9 May 2020 10:07:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CE688E0003; Sat, 9 May 2020 10:07:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 90B0A900007; Sat, 9 May 2020 10:07:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0044.hostedemail.com [216.40.44.44]) by kanga.kvack.org (Postfix) with ESMTP id 771CC8E0003 for ; Sat, 9 May 2020 10:07:02 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 350F32DFD for ; Sat, 9 May 2020 14:07:02 +0000 (UTC) X-FDA: 76797357084.22.tree64_2045d92b46b46 X-HE-Tag: tree64_2045d92b46b46 X-Filterd-Recvd-Size: 4519 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Sat, 9 May 2020 14:07:01 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id g10so3670009lfj.13 for ; Sat, 09 May 2020 07:07:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Jc93T48//PCz7sdPyS0gIAsQLpsU+tV5Kt0CzqYwNik=; b=uF4uQoe+Y/Rjx41fEplRhUf+B9x5B5F/LKDeKQu+D8rktHPDMcvcrKJ2M9QRQslZfS pxpEfjWspPHF07KZa4jVhaeDrW9r2+L6O38kBjVzIONl+siiFRvZHre6UUqVfO5njY4B dclVPiAKKVgD9sk/qgxT+kxi1bWfRfD1eDSbafMPpBgtnE3jIzAu//+1lQ4e92NmJfmj LCTOgnamNTrgmOw5HmZ+CAhGi7SIJy6XSOZNlSbK8eezV94DWGSsmsC1Idq4uY50QrbP w0b4AnWsem9n7jdd6EvNgGuGM5FgnEYGAQe4NPYrBycRSJed3lj+S+y6HdS2UnvQtkqG 9oyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jc93T48//PCz7sdPyS0gIAsQLpsU+tV5Kt0CzqYwNik=; b=gqh69DT+KJtW4WIJr/sZfOF7Psqe9VAqM5sVmG3b2eM1kzhXtM7pbL5BEaL3Pl33Vo TRjYMvzATiLcJtFu7dCzRXLHMFHRBpR4/+bEQsK60wJ8vJemYv2fyjZ8GhEHhG7CM+lH AUbAWQwblpA07uRSGNj+c5tAxjfbMieKopTuVTdL5IizYDzxCXuxyan0EBIzxKyVeuDf C4M67SvfjyVBCQmRjeEZiWtfRh3ZPgk3nRW3ZkggyPfOSuwdbCF2pQda0D2w5TZLukT9 C8vtf6xxC9MSSMZGxRkOU/dGfejLH2o+4Utb6ZuzdMDHeeYp0U0Nk0KwLeysszdl3e6b d8Kg== X-Gm-Message-State: AOAM53049nwT/dSHRjcEg+EyJEKl0uR/QZwghTK94qtML9/oIj0d+7wn BmySnlQt5JPFtOuzyk4n31+iDyb+FyYwefd5iIixLgRp X-Google-Smtp-Source: ABdhPJwjPYzDPcoNKv0FtPPZDg27RvRDPPE/INXsZ6+T0TDBOd40qBSDRRPucaEnBz644KrZdQwsAsrxFNOD5b1wI6g= X-Received: by 2002:a19:f512:: with SMTP id j18mr5027730lfb.33.1589033220016; Sat, 09 May 2020 07:07:00 -0700 (PDT) MIME-Version: 1.0 References: <20200508212215.181307-1-shakeelb@google.com> <20200508212215.181307-3-shakeelb@google.com> <20200508215122.GB226164@cmpxchg.org> In-Reply-To: <20200508215122.GB226164@cmpxchg.org> From: Shakeel Butt Date: Sat, 9 May 2020 07:06:48 -0700 Message-ID: Subject: Re: [PATCH 3/3] mm: swap: fix update_page_reclaim_stat for huge pages To: Johannes Weiner Cc: Mel Gorman , Roman Gushchin , Michal Hocko , Andrew Morton , Yafang Shao , Linux MM , Cgroups , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 8, 2020 at 2:51 PM Johannes Weiner wrote: > > On Fri, May 08, 2020 at 02:22:15PM -0700, Shakeel Butt wrote: > > Currently update_page_reclaim_stat() updates the lruvec.reclaim_stats > > just once for a page irrespective if a page is huge or not. Fix that by > > passing the hpage_nr_pages(page) to it. > > > > Signed-off-by: Shakeel Butt > > https://lore.kernel.org/patchwork/patch/685703/ > > Laughs, then cries. > What happened to that patch? Fell through the cracks? > > @@ -928,7 +928,7 @@ void lru_add_page_tail(struct page *page, struct page *page_tail, > > } > > > > if (!PageUnevictable(page)) > > - update_page_reclaim_stat(lruvec, file, PageActive(page_tail)); > > + update_page_reclaim_stat(lruvec, file, PageActive(page_tail), 1); > > The change to __pagevec_lru_add_fn() below makes sure the tail pages > are already accounted. This would make them count twice. > Yes, you are right. I will just re-send your patch after rebase. > > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > > > > @@ -973,7 +973,7 @@ static void __pagevec_lru_add_fn(struct page *page, struct lruvec *lruvec, > > if (page_evictable(page)) { > > lru = page_lru(page); > > update_page_reclaim_stat(lruvec, page_is_file_lru(page), > > - PageActive(page)); > > + PageActive(page), nr_pages); > > if (was_unevictable) > > __count_vm_events(UNEVICTABLE_PGRESCUED, nr_pages); > > } else {