From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 431B7C001B0 for ; Mon, 14 Aug 2023 20:18:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B060F6B0081; Mon, 14 Aug 2023 16:18:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AB49F900006; Mon, 14 Aug 2023 16:18:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92EB58E0001; Mon, 14 Aug 2023 16:18:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 807316B0081 for ; Mon, 14 Aug 2023 16:18:39 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 518D0160317 for ; Mon, 14 Aug 2023 20:18:39 +0000 (UTC) X-FDA: 81123823158.19.84197A2 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf08.hostedemail.com (Postfix) with ESMTP id 8CDAF160027 for ; Mon, 14 Aug 2023 20:18:37 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=updUYgXL; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692044317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LFWKye89AohEqYgCuqyO0wjrP9O8bS1Mmve3otWwOUQ=; b=fiaM2jpXroh5Fc0gH8tDs/bLvKZ40YspfmS8gOgwrXMLZQm+JAgoH6BdBhnIWAfMBJjLi4 91dBnsbB6m58I1R96F2z8YZ+PEIp6Hh7uZA6GOlGUV578hqKpYm1GrMyrWtXIODUXxQltK W1X45byxtdPV6OPdBndfK5qVV1bXwqU= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=updUYgXL; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692044317; a=rsa-sha256; cv=none; b=8IXTAKLT08s5iaW17MAH30p8MABIdlMyltDJgEtWG1/XOnvG1l7doGK+YLBsdYvFevuORb dNDCDvDl7PIylmQKfx15/swobSnRmSpRlYnE+RDkrYYOSum8mm+PFY0v7WiZysVJdaih8s nPWkwi8+utm66FH0B8QBrtthxEfPpgs= Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-407db3e9669so17831cf.1 for ; Mon, 14 Aug 2023 13:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692044316; x=1692649116; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LFWKye89AohEqYgCuqyO0wjrP9O8bS1Mmve3otWwOUQ=; b=updUYgXLDGG4jlzZd5VTLcn4ck7IV7JsmtsFDKY3gGoK8cHcDcVAF65Px8wrcx4Rpw 5aeohd2TIc+lBdHaUcKOLojjvG5i1Sjtomi5Efvu9HKhrYtbkVsFBJQDc/gXDZXhrqDd BTw7bVAxF4h6WbITliiLtT4buweGCJUSmaTwZQspzLmIKsmCe14t6a9HVIWT6YKlLvDV mNs74AwJ0zU0/tetCBfCfSp0XcnRJ1m3IpOmybV/upnND0Ytv7jyrvl1TXrF9NGHKWnc ExRJysByXqm0J8czAGmplNNLUBdHGyai37qngjYtFkqBvNbS/eLxW99NXQ+KREqbFOkq +u2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692044316; x=1692649116; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LFWKye89AohEqYgCuqyO0wjrP9O8bS1Mmve3otWwOUQ=; b=kSy+a46/Iv+JZupIeNc4K0ynGnwYehqnw+AkjGqivS5svvWSPVOgKasSh/ZmjKuGhh 4afYkRmOD/5Jl5y7e4QragKazVVsFg8J97yQigNVuq4tuhp6pcxM7p+ARVoMPD0QkB/u rB1vhmQf4HkRVeNf8anmWXtsiFTXw2dnU8m6ZLE9zzOYRJfB0/+mL4qDqzLf3CtPu2JS ItwYDF7sTfWercoFnFHLTWZeAVhm2uGkHhSTNJopl+l2Hr1Y9k1pjuAE/6PwMZ9rBlpv Ct7R7BLKe9C7PKkldo4hdIaABJfMobfz07w7HNATQoFnr8aQjo70e7KEavE5PmcLyuGU 6IOg== X-Gm-Message-State: AOJu0Yw/SALGdE5lU5xEOK5D7L53IsD2dq0xLtGy3721dax74U7iyCkX w2nOQp9lRxxjbL2TV6a/DET68h2rNMw0w/ItReL08A== X-Google-Smtp-Source: AGHT+IEFdGrDQ4Nwqtzcf6NqnLR2GAMh5mfN76hFiLoqG57pskcDNdbraJUTBqKQzWqKSGAdkPmPVqBGYqsl0XuRfHo= X-Received: by 2002:ac8:7c50:0:b0:40f:db89:5246 with SMTP id o16-20020ac87c50000000b0040fdb895246mr696564qtv.21.1692044316493; Mon, 14 Aug 2023 13:18:36 -0700 (PDT) MIME-Version: 1.0 References: <20230814070923.35769-1-wuyun.abel@bytedance.com> In-Reply-To: <20230814070923.35769-1-wuyun.abel@bytedance.com> From: Shakeel Butt Date: Mon, 14 Aug 2023 13:18:23 -0700 Message-ID: Subject: Re: [PATCH net-next v2] net-memcg: Fix scope of sockmem pressure indicators To: Abel Wu Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , David Ahern , Yosry Ahmed , "Matthew Wilcox (Oracle)" , Yu Zhao , Kefeng Wang , Yafang Shao , Kuniyuki Iwashima , Martin KaFai Lau , Breno Leitao , Alexander Mikhalitsyn , David Howells , Jason Xing , Vladimir Davydov , Michal Hocko , open list , "open list:NETWORKING [GENERAL]" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 8CDAF160027 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: oac97fi37uop9w5knmhco6fwmtrsa3nc X-HE-Tag: 1692044317-32865 X-HE-Meta: U2FsdGVkX19swnENgOQtNS2rZtlxKD3IirpPDKKjSPLoO+nCLCrvobYpDnceBhwjbNYxWFsPSf2SjnIsMOdgFpBgGAjdRjNlzRmrRvHouMO5sBqV1r0MgosdjNrMVnNeKjivFl0vUUEHDnScocCk7qF7rHfZ2v7AxvCYbjZ1eBBazfH0I6oySHwMdI1yqeF9N1YEL+wgE39FlYzxycs+Dgm1wY19aDFQb/WK5ltdNLs/bHFMn8YZTFJEtH/GyvynGyQ7Z1aegdVkNJh4ofId5ExizowTweP/74oZVabLQjl3+aQqxttHN3ISvVsN96a7M7s+YVm911nQigWkU6S4BR7SLLOVKcu2J7tln2pPdBLGm8yo6nHKnKBRAVsETkv1e32NmAUSJycYmbg4AFNWntqbBGyxd9knFGmG3SQQF6vNskHelOZ+LDBYWgbRmC5gNCxPxgkJPJKl9Nw2CJKjbeC2j0ZCWMtLOOPgV2/0batmHp6MonlL/tpYoPMRhrWLy2ChCY/5TN0PHWXWxJ3XnmwTGbt/ihSKZKRQZmGmu0wmjos3v6Ghk0Ku36dBvIZTuJLOtfAs6QhY+1jOxMytE4ZMQ2EoDhJDd5ako9a291Ij2Z4qCWEUch0eWq6K5qRjD5FVvRK3Ex7C4Y/EPu9fip5vOEb2eg4ngcM8jB0ACJurkAMJibuTTkbqQ+dli2nV77wb+r/BzX5a3RJinx6UKhcq2Ut64Irw/AQ0FwJjXBSqRqU9MbvDo8Nsk1KbwnkLpenWrR21p33n5UoeA/S8Bj0odc10gLOzGfuT8G6EJhZtHAJdCAiCO281hR9V7NMM2agE6w/5qczSvrDI6H93c/Df4Vt+MRV0akcHdU3nixsVngBOGnKWilyrA14illBpW1qFo4BA5LmjIP1twenKRxaLqS199n1KtssZ0ajd4sLJ2WA6LqH3tCCd9wb8FJReZXReNyqPrE6eKdTa3/S C3eF4LF1 MOprG24pR+IQ9257HEneh8Pxm9fiUholkQw+had5Q9eYA7HL5WhSVSjbfBb5HPlfaEaOrMIAZhxNKbOoqVs8pNpO2pkDjv5RqiGaghs6qSE4DwE7Wv11aNAntEneb5ybgl4g9L8+uI9q0NBKeIwJtciBOT0SBcxmhvx8fZa8dVOUGwI9EgnzetAUisSxntL+0yFt2aBY8mLm1jWpssyuVP6JEF+v8IiCgDvsmyUrYiM2JHPdXjQ8qGr7bLbbhdkbr874cLTZeoY3v60PwmtFjaDl6yCyWMQHPKE3WcUH2p9ay8Zd3crz2Ku6tJ8UWaDjmnc/qO8BpNjg4D08lA7YuQl1TKSWSV0MyoMBgWI/W30dY/feReQMYnaoheDO0dhrqVxTR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000006, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 14, 2023 at 12:09=E2=80=AFAM Abel Wu = wrote: > > Now there are two indicators of socket memory pressure sit inside > struct mem_cgroup, socket_pressure and tcpmem_pressure, indicating > memory reclaim pressure in memcg->memory and ->tcpmem respectively. > > When in legacy mode (cgroupv1), the socket memory is charged into > ->tcpmem which is independent of ->memory, so socket_pressure has > nothing to do with socket's pressure at all. Things could be worse > by taking socket_pressure into consideration in legacy mode, as a > pressure in ->memory can lead to premature reclamation/throttling > in socket. > > While for the default mode (cgroupv2), the socket memory is charged > into ->memory, and ->tcpmem/->tcpmem_pressure are simply not used. > > So {socket,tcpmem}_pressure are only used in default/legacy mode > respectively for indicating socket memory pressure. This patch fixes > the pieces of code that make mixed use of both. > > Fixes: 8e8ae645249b ("mm: memcontrol: hook up vmpressure to socket pressu= re") > Signed-off-by: Abel Wu So, this is undoing the unintended exposure of v2 functionality for the v1. I wonder if someone might have started depending upon that behavior but I am more convinced that no one is using v1's tcpmem accounting due to performance impact. So, this looks good to me. Acked-by: Shakeel Butt I do think we should start the deprecation process of v1's tcpmem accountin= g.