From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FF1DC433EF for ; Mon, 6 Dec 2021 06:07:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7CFF66B007B; Mon, 6 Dec 2021 01:06:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 77FC86B007D; Mon, 6 Dec 2021 01:06:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6484B6B007E; Mon, 6 Dec 2021 01:06:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id 5175F6B007B for ; Mon, 6 Dec 2021 01:06:51 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1932B8848F for ; Mon, 6 Dec 2021 06:06:41 +0000 (UTC) X-FDA: 78886335402.10.84AD518 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by imf25.hostedemail.com (Postfix) with ESMTP id BECD9B000181 for ; Mon, 6 Dec 2021 06:06:40 +0000 (UTC) Received: by mail-lf1-f42.google.com with SMTP id b1so22591438lfs.13 for ; Sun, 05 Dec 2021 22:06:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vv0znKZkXJZMzsECckGi47A2Z/lLUzawdx8IEXbnGWk=; b=YsEjqepZeQvUbFx/aqXDHvbDkAi16fxHMOFnyDNfNhyWoBQvVeaAjLcoFIxE4ZFE6r e0yQfiOvKFKism80QUNMHwZJ/aTzVLwEFwZDAcQPSazF2BXWGCty9K4kE/czm/gV7K2b EDOROzNqqQ8qBhibAUtJLEvyY41oVBjI+P1L2+9UXkZ2DCdoXFZKq1ZOfD4Kf8h/dVZM qrCUT+zK0Tv6UuPUZOdNPB6trOKeGiPcBuTHEiSqIX6vKVgROLoDvg0UYEzkiE60Gb8g sHVTe99J9n1ZhiZsQ2Zy53UpR3egvHVWiTHfjNrcDWwqID3ak8hZG3fO/BVdjAuQWo/5 8x6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vv0znKZkXJZMzsECckGi47A2Z/lLUzawdx8IEXbnGWk=; b=yot38FzVuTtwl6WJYmIeKV0o6R2VMljA83gYIxSqFs8X31JPc1sWhb6iCCUsOhi4Z6 Od0EmmtG/JdxYRLVEisM31FbSXttMyN+VFAfmgLlp4lp6ClHMJHf+avHbRXkIBQt61SG ViDpMESVakLD47bdPkCKN0YkDrAx4wLaS/j1cwTKp/FBYApCjglnNCViEfPF/7xOuuNx QTeFpDDbtzlI26u9gr6+kNoJSIix5qu/ePiMPnI9LCcONi3aAICUEaC7DstYhogywz5O nFaXDEUIujNNMrqIc23UG9VhMpbFoGyuEvLZzVLsw4g6uzceTD6qUju+g2RiVv4DE1VM zgkQ== X-Gm-Message-State: AOAM530buroRsmZExLBuP6ag9HWfiavRMzw4mkH5LFjTElRVY6Wk3YVs 8f4jJwozRHz+3JSMZUX9fx1TMqjyf6W/lXGecJUbzw== X-Google-Smtp-Source: ABdhPJzDUE/FOglwH1X1yflrVsaHq5ki2OSiI7rH+J6rd9KuybYkMfGkVUfJ+ZsNJDQKf6M+bs18NYyHI8A9InkI0es= X-Received: by 2002:a05:6512:1113:: with SMTP id l19mr33552043lfg.184.1638770798873; Sun, 05 Dec 2021 22:06:38 -0800 (PST) MIME-Version: 1.0 References: <20211202150614.22440-1-mgorman@techsingularity.net> <20211202165220.GZ3366@techsingularity.net> <20211203090137.GA3366@techsingularity.net> <20211203190807.GE3366@techsingularity.net> In-Reply-To: <20211203190807.GE3366@techsingularity.net> From: Shakeel Butt Date: Sun, 5 Dec 2021 22:06:27 -0800 Message-ID: Subject: Re: [PATCH v4 1/1] mm: vmscan: Reduce throttling due to a failure to make progress To: Mel Gorman Cc: Andrew Morton , Michal Hocko , Vlastimil Babka , Alexey Avramov , Rik van Riel , Mike Galbraith , Darrick Wong , regressions@lists.linux.dev, Linux-fsdevel , Linux-MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: BECD9B000181 X-Stat-Signature: xzj7qamqm9gbrbbhi5ci3qfj1q7jqdbf Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=YsEjqepZ; spf=pass (imf25.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.42 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1638770800-781004 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 3, 2021 at 11:08 AM Mel Gorman wrote: > [...] > > I am in agreement with the motivation of the whole series. I am just > > making sure that the motivation of VMSCAN_THROTTLE_NOPROGRESS based > > throttle is more than just the congestion_wait of > > mem_cgroup_force_empty_write. > > > > The commit that primarily targets congestion_wait is 8cd7c588decf > ("mm/vmscan: throttle reclaim until some writeback completes if > congested"). The series recognises that there are other reasons why > reclaim can fail to make progress that is not directly writeback related. > I agree with throttling for VMSCAN_THROTTLE_[WRITEBACK|ISOLATED] reasons. Please explain why we should throttle for VMSCAN_THROTTLE_NOPROGRESS? Also 69392a403f49 claims "Direct reclaim primarily is throttled in the page allocator if it is failing to make progress.", can you please explain how?