From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34CEFC47096 for ; Thu, 3 Jun 2021 16:53:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C561A613F1 for ; Thu, 3 Jun 2021 16:53:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C561A613F1 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2658A6B006C; Thu, 3 Jun 2021 12:53:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 216306B006E; Thu, 3 Jun 2021 12:53:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 041096B0070; Thu, 3 Jun 2021 12:53:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0243.hostedemail.com [216.40.44.243]) by kanga.kvack.org (Postfix) with ESMTP id C48E16B006C for ; Thu, 3 Jun 2021 12:53:30 -0400 (EDT) Received: from smtpin38.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 55ACDEFF2 for ; Thu, 3 Jun 2021 16:53:30 +0000 (UTC) X-FDA: 78213008580.38.1D4A53F Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) by imf21.hostedemail.com (Postfix) with ESMTP id 721EBE000240 for ; Thu, 3 Jun 2021 16:53:11 +0000 (UTC) Received: by mail-lj1-f182.google.com with SMTP id m3so7955350lji.12 for ; Thu, 03 Jun 2021 09:53:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=t0rBINIjyYVjiWlKA6CZdf8Cu1m85/b95NW0HipMWEw=; b=RT6DDw3hX0Vd0D9y8P1+wlBANWRsJKcOTL5XNuqjuoqdcO+eVWb3h5lPuPBdWbpXRP qS7RpEK9U4hewHkB9ReHFH0CpGE6xxnLud53HxAhqun48esVrJ2Tsyp+XW2wrFLkrwHK lH/KFiL4LHRVHxBi+EJaxQ1OcbONA/XKS1BDaSuddZH/u57dzNoDmqyVp/ACKK8Zo9xA GYN86bl7bcGB1HAkjN9u3Li/fE5sVQbAL/zx25EkFYVTSn2KJIenbUvhjj/7OSdYsqOj aF8pnMaxmokmARnSb/3P9IcKdc1ySVi+6IVr0FK6l431NPIU5pv9T8uTmzgRjZmKVxX7 SuIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=t0rBINIjyYVjiWlKA6CZdf8Cu1m85/b95NW0HipMWEw=; b=pGCjJlDbgLVPOnt+wPX7kimzCdz0OEnvTfr2oPPqCyvDxLFfqHmWo/PHVwBIxgqWoB oHDy8XLDRhrL/8XyX2IwH3w16be+VEpSkc0yaubzK8/Uqvsu0E6XmhMMb0cUQ+W4nSvS kDeIgCBlKqOvmWeRl3fa5BrWXnbCrxA+cBt5OMIS4KSJ/hEXXRvkH0jWuQmCbMg78nx8 ESk/h7rWRQJjVycPI0FanAwM5G23dD4xbQfuJ40S9v+vll8TPgQ6VtqWH/+Wsjsuo18J q/kdgeGd8rpcU4RmiBtt0/GJxcaeqYx01DOu/pYNUtj/8k1uVcFeD/P/j0A9hN1CtlYp mDQg== X-Gm-Message-State: AOAM5303idd3ZV9MoGGkYQ2/ybnIkT/ZBooalpRdpFdjTj7D+ZXiz5xY iruERllCBjTJeSwm8vV/zGu2mMQSOpkOWi/LMZeoWg== X-Google-Smtp-Source: ABdhPJzeDeSBqXYAQ4z4rfvcdsvKYnRBUfk/V02cbzoITVb8r8bIa3oFG903QpB57v+azcbplWWae+BaY+2ulj+HrVI= X-Received: by 2002:a05:651c:210f:: with SMTP id a15mr235460ljq.160.1622739208042; Thu, 03 Jun 2021 09:53:28 -0700 (PDT) MIME-Version: 1.0 References: <20210603145707.4031641-1-schatzberg.dan@gmail.com> <20210603145707.4031641-3-schatzberg.dan@gmail.com> In-Reply-To: <20210603145707.4031641-3-schatzberg.dan@gmail.com> From: Shakeel Butt Date: Thu, 3 Jun 2021 09:53:16 -0700 Message-ID: Subject: Re: [PATCH 2/3] mm: Charge active memcg when no mm is set To: Dan Schatzberg , Muchun Song Cc: Jens Axboe , "open list:BLOCK LAYER" , open list , "open list:CONTROL GROUP (CGROUP)" , "open list:MEMORY MANAGEMENT" , Johannes Weiner , Tejun Heo , Chris Down Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=RT6DDw3h; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of shakeelb@google.com designates 209.85.208.182 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Stat-Signature: g37kpimspa8w6mtpdmdi55yq51pyogyp X-Rspamd-Queue-Id: 721EBE000240 X-Rspamd-Server: rspam02 X-HE-Tag: 1622739191-213638 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 3, 2021 at 7:57 AM Dan Schatzberg wrote: > > set_active_memcg() worked for kernel allocations but was silently > ignored for user pages. > > This patch establishes a precedence order for who gets charged: > > 1. If there is a memcg associated with the page already, that memcg is > charged. This happens during swapin. > > 2. If an explicit mm is passed, mm->memcg is charged. This happens > during page faults, which can be triggered in remote VMs (eg gup). > > 3. Otherwise consult the current process context. If there is an > active_memcg, use that. Otherwise, current->mm->memcg. > > Previously, if a NULL mm was passed to mem_cgroup_charge (case 3) it > would always charge the root cgroup. Now it looks up the active_memcg > first (falling back to charging the root cgroup if not set). > > Signed-off-by: Dan Schatzberg > Acked-by: Johannes Weiner > Acked-by: Tejun Heo > Acked-by: Chris Down > Acked-by: Jens Axboe > Reviewed-by: Shakeel Butt Can you please rebase over the latest mm tree? Specifically over Muchun's patch "mm: memcontrol: bail out early when !mm in get_mem_cgroup_from_mm".