From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CFD8C43461 for ; Mon, 14 Sep 2020 15:37:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 10734208DB for ; Mon, 14 Sep 2020 15:37:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Afg6QaB+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10734208DB Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3F3FF900003; Mon, 14 Sep 2020 11:37:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A45D6B0068; Mon, 14 Sep 2020 11:37:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 292C5900003; Mon, 14 Sep 2020 11:37:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0207.hostedemail.com [216.40.44.207]) by kanga.kvack.org (Postfix) with ESMTP id 0F92E6B0062 for ; Mon, 14 Sep 2020 11:37:10 -0400 (EDT) Received: from smtpin01.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id BA8A5180AD804 for ; Mon, 14 Sep 2020 15:37:09 +0000 (UTC) X-FDA: 77262070578.01.love63_3214f9e27109 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin01.hostedemail.com (Postfix) with ESMTP id 879E41005078E for ; Mon, 14 Sep 2020 15:37:09 +0000 (UTC) X-HE-Tag: love63_3214f9e27109 X-Filterd-Recvd-Size: 3413 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Mon, 14 Sep 2020 15:37:09 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id r24so79232ljm.3 for ; Mon, 14 Sep 2020 08:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mzx2NgkB1nDMETbz5EDQ8LndFJVrNLUdv8ics0I+18I=; b=Afg6QaB+BSz1GeEiUUoLpaauFp1bmrgB23nL8XxTsNnVonXaOkJFrJd6jdtjqTM1E2 7JlIwQwEe60FXwjMxUkjaSxnOKit5jPzs29jiYrCp0OR+JKTLAZo2LshQdwhiYtmKoC8 WdYvMRlhRTD1XtrcSb9ed/dvOLW8xcU2pbsNRaRZCUaWe5ylREbLDrsLZAWV5/qDGTtF 8tAyWxeapw0IfCZ42u/fmSTmHadUVsc2vCUD+EZtcKzXLTyAwFLHIzvaf/tr6Jml2BQF yU66ii6gQB4gOrHvnkv3KMBogvEKNyK99/NQLkPQtMVgWL47x9DfvCXSLlzYAOF6WuxX bPlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mzx2NgkB1nDMETbz5EDQ8LndFJVrNLUdv8ics0I+18I=; b=Kzx8kHv0W45PLMxZeKC4m7aTeQhpVw/Ucb0FT3mr9wIMdjcxNyXn/RH16MlBmmH7r1 vEzmxdxvm3BSKT3ho4hv119ZquVNf0zicIg/ww+1bDBohQgQ337NY7iJywCeGXE7htTB Ku/m1MZEhqTEmxex6ATPsV75i2gseU+wq3XS6q+MOChkKT3E2yuLHL7hbZ1wiEYm/yrs OGQRfDjuoO8B7a3o3Nh7l9wirEv5FDH292oqf8KI8ZQFzB1A17De/xTxB9tFqqT1ihpZ rMWgRksXc724uiVy2SMhXNH7XOhfjB0m2vgfEhkrhN+NlHWMMv8j3Bw1SYzcP0C/hT2a i3jA== X-Gm-Message-State: AOAM5337yg5rn99Th2kTZebEJDJkmycPktrDdyF/PftVW7XpRa0CXi9l VmkxKVdw9P6fzbFuWSjW+alAUUhW01DIlkoFriMoVQ== X-Google-Smtp-Source: ABdhPJxoCOS6P041CkwHWmWs49WLL5Tsg/V9xbDyqYe8Aj0ctcgkfx7sQ26IixpG8vthsak05IPxPNQff5X8ZJ1S6Yg= X-Received: by 2002:a2e:3511:: with SMTP id z17mr4982462ljz.58.1600097827616; Mon, 14 Sep 2020 08:37:07 -0700 (PDT) MIME-Version: 1.0 References: <20200914024452.19167-1-longman@redhat.com> <20200914150928.7841-1-longman@redhat.com> In-Reply-To: <20200914150928.7841-1-longman@redhat.com> From: Shakeel Butt Date: Mon, 14 Sep 2020 08:36:56 -0700 Message-ID: Subject: Re: [PATCH v4 2/3] mm/memcg: Simplify mem_cgroup_get_max() To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Tejun Heo , LKML , Cgroups , Linux MM , Chris Down , Roman Gushchin , Yafang Shao Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 879E41005078E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 14, 2020 at 8:09 AM Waiman Long wrote: > > The mem_cgroup_get_max() function used to get memory+swap max from > both the v1 memsw and v2 memory+swap page counters & return the maximum > of these 2 values. This is redundant and it is more efficient to just > get either the v1 or the v2 values depending on which one is currently > in use. > > Signed-off-by: Waiman Long Reviewed-by: Shakeel Butt