From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CE26C28CBC for ; Wed, 6 May 2020 15:32:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DD0EC20575 for ; Wed, 6 May 2020 15:32:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="ALZxy6RW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD0EC20575 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 632528E0005; Wed, 6 May 2020 11:32:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5BC238E0003; Wed, 6 May 2020 11:32:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4844D8E0005; Wed, 6 May 2020 11:32:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0062.hostedemail.com [216.40.44.62]) by kanga.kvack.org (Postfix) with ESMTP id 2CAE58E0003 for ; Wed, 6 May 2020 11:32:47 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E62DE180AD80F for ; Wed, 6 May 2020 15:32:46 +0000 (UTC) X-FDA: 76786686732.06.frog42_1840c26cb0e21 X-HE-Tag: frog42_1840c26cb0e21 X-Filterd-Recvd-Size: 3512 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Wed, 6 May 2020 15:32:46 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id j14so1706370lfg.9 for ; Wed, 06 May 2020 08:32:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=l6InfsiUZfGB2r4wRIjhLaI99Wwv9S34rDqGFlXWBAI=; b=ALZxy6RWLNT6U1ToT9ReCp0HQTLyZb/Q8UteKXoS0ZzKVBKom8hZ6WE1ZzpANM0PQO ArjAZ5VQ9n+1A6eZsRobbVXp0FSa8pfvW3U/WQOIhM79Ruq3WG09BXuyC+xK9EdSe6iD 7n2L3ddAw2xSZiEISI9Fcb3fthxl1kCve3gLqkdaaQQclby1rI8vr0H4giI/qdJiokl1 Enk0ON+s4zpE8OQAS3YYp4ptgCIMEM23zdBHKDcAUG/LZ+0WnOpoiOxRHZHwE6t9+SRW ifj7OXQ9/ZCdD14Boz6GwS3PEriGQTsn7R7BMfxhmC1qP3VNVMUBYXcl8SSTRmZHbdma SSNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l6InfsiUZfGB2r4wRIjhLaI99Wwv9S34rDqGFlXWBAI=; b=qE+7PDVt5PwtvXi9vLDSrkp2GT3uSLyQHjZRt3cImHH0F/SXGh6VTrJb+JCZMLjLgx m26f/RHYH3UKCZOGI4P5oFpTAITYiL8ZJ6+74ZFfo3TrF7GdGijgheV7gY6Z+nYEIKyQ 7PHaZaPgZi/3nsKaWSOHRDu+HGgWU5n60xmUUDWoDdwUB7TZ8GbRu5JhQopR6eV9hKrd VUviEMcOvj/CeDQs95H/LGJ0yIfGCVii6kb8Gc0K5Qsr/1Et0j76n68jjuJVB9KkafMj 3kUk8d0lpTP7GLqc/wILgRLQEVFqfYsdhkgc0qlAv4xO0QCW9FiT/wluTQf55zOtEsLC enGQ== X-Gm-Message-State: AGi0PuZBtjnN7FkSckbB4UQGTjj8T6bszxorl3hfBXpENebn40IWkSj8 PuWuKi+dx8MAnUyiUAf6IC4wz+gbu2/fFMJQASd2sg== X-Google-Smtp-Source: APiQypLmhMPecLqOOLK8r/IY58+D0n5DO3ezO73Wkeomi5c2qL8vxGn+Rg5LjeqRtsOQoaM9YNO/q3vruzrKPciqDDg= X-Received: by 2002:a19:3f57:: with SMTP id m84mr5501725lfa.3.1588779164692; Wed, 06 May 2020 08:32:44 -0700 (PDT) MIME-Version: 1.0 References: <20200506151434.GB4687@carbon.lan> In-Reply-To: <20200506151434.GB4687@carbon.lan> From: Shakeel Butt Date: Wed, 6 May 2020 08:32:33 -0700 Message-ID: Subject: Re: Query on PGREFILL, PGSCAN and PGSTEAL To: Roman Gushchin Cc: Michal Hocko , Johannes Weiner , Andrew Morton , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 6, 2020 at 8:15 AM Roman Gushchin wrote: > > On Wed, May 06, 2020 at 07:34:16AM -0700, Shakeel Butt wrote: > > Hi Roman, > > > > The commit 2262185c5b28 ("mm: per-cgroup memory reclaim stats") added > > the memcg reclaim stats. However for the global PGSCAN and PGSTEAL > > counters it restricts them to be updated only for global reclaim while > > the PGREFILL global counter is updated for both global and cgroup > > reclaim. Is that intentional? > > Hello, Shakeel! > > It looks like it was so long before 2262185c5b28. And I don't know any > particular reason for it. I guess it was unintentional. > Indeed it was done in 904249aa6801 ("mm: fix up the vmscan stat in vmstat"). I think we should make them consistent. I will see if these global reclaim checks should be removed. thanks, Shakeel