From: Shakeel Butt <shakeelb@google.com>
To: Roman Gushchin <guro@fb.com>
Cc: Michal Hocko <mhocko@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>,
Linux MM <linux-mm@kvack.org>
Subject: Re: Query on PGREFILL, PGSCAN and PGSTEAL
Date: Wed, 6 May 2020 08:32:33 -0700 [thread overview]
Message-ID: <CALvZod52znaX6_OSBE72GjrycuXS8ZXxt6FP=hh91OOFRKpxTg@mail.gmail.com> (raw)
In-Reply-To: <20200506151434.GB4687@carbon.lan>
On Wed, May 6, 2020 at 8:15 AM Roman Gushchin <guro@fb.com> wrote:
>
> On Wed, May 06, 2020 at 07:34:16AM -0700, Shakeel Butt wrote:
> > Hi Roman,
> >
> > The commit 2262185c5b28 ("mm: per-cgroup memory reclaim stats") added
> > the memcg reclaim stats. However for the global PGSCAN and PGSTEAL
> > counters it restricts them to be updated only for global reclaim while
> > the PGREFILL global counter is updated for both global and cgroup
> > reclaim. Is that intentional?
>
> Hello, Shakeel!
>
> It looks like it was so long before 2262185c5b28. And I don't know any
> particular reason for it. I guess it was unintentional.
>
Indeed it was done in 904249aa6801 ("mm: fix up the vmscan stat in
vmstat"). I think we should make them consistent. I will see if these
global reclaim checks should be removed.
thanks,
Shakeel
prev parent reply other threads:[~2020-05-06 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-06 14:34 Shakeel Butt
2020-05-06 15:14 ` Roman Gushchin
2020-05-06 15:32 ` Shakeel Butt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALvZod52znaX6_OSBE72GjrycuXS8ZXxt6FP=hh91OOFRKpxTg@mail.gmail.com' \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=guro@fb.com \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox