From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C737C77B61 for ; Tue, 28 Mar 2023 13:25:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CF6EE6B0074; Tue, 28 Mar 2023 09:25:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CA7376B0075; Tue, 28 Mar 2023 09:25:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6F976B0078; Tue, 28 Mar 2023 09:25:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A54BF6B0074 for ; Tue, 28 Mar 2023 09:25:27 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 624AC120272 for ; Tue, 28 Mar 2023 13:25:27 +0000 (UTC) X-FDA: 80618378694.11.0737FA4 Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by imf07.hostedemail.com (Postfix) with ESMTP id 7342540022 for ; Tue, 28 Mar 2023 13:25:25 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=i9jvfdCe; spf=pass (imf07.hostedemail.com: domain of shakeelb@google.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680009925; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aKr9MaZxGZc9u8ZhIE9so1jdgqHxAOgc8JTrWbL9sqY=; b=dHlFCaC82hELuVmPFgB9KY4oqtJSrrRpBZ25hQourCZpkPz9Vz/AlfBAWaZ++jmWNZOVbm y3uie+5ZhAG9xCNXhECt7EmqvucoAP5Z78mHG3nfqgyQ3KZQiiEopC+b2mhLbzh5CwdS4U ql7m5fjW4RsZVqpyVf4ka/V7a9r1gSY= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=i9jvfdCe; spf=pass (imf07.hostedemail.com: domain of shakeelb@google.com designates 209.85.128.174 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680009925; a=rsa-sha256; cv=none; b=IvuU49XLnb30/tsk6XbJ63urjvBtelYxntC47cLnpPlw5gK2sKjYIrZR+1JFwLchvbf/um 8g5B+4MVSW0xI+rPCEiIdPXVwg0rKXgck32JXfiMtN9FrWJcDnw+51op8ZdsFTXkxCNmCE E8db9wTu4mPof3GZCDXSzF13gsa3AYY= Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-54606036bb3so63723137b3.6 for ; Tue, 28 Mar 2023 06:25:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680009924; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=aKr9MaZxGZc9u8ZhIE9so1jdgqHxAOgc8JTrWbL9sqY=; b=i9jvfdCeB9SsJnyBiAbhdPLhoxjsfRopr7eARS5rGyPO0aOs26naUPy0TOlNDXReWF R5Ea79kbAr+glBAXFOfEsjm49+Nm5fB3G3LIqw9DO4pIhWqBfQICEKbBtdAas72TZMRa 2naeIrUIfdDmFPzU0ieyV8VHQOarplR5OZFhsLhdFTJ17Qsili22215RkxE3w61P7NqR QN1VePuwazlq07Mx1/r+u1FhPyrqxDDF2mBmsHwUrqWufwHsPj0sdlguYWltwhWjNVjP 5VKvQ0LXJosLvebPB+Yu1xwBQd5x8bAJlaPp08d3BXWvpGTaWuuE3u78gHSrMcThnKrJ Ve5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680009924; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aKr9MaZxGZc9u8ZhIE9so1jdgqHxAOgc8JTrWbL9sqY=; b=wp7uI7B8O9vh1vAyX09GzvrkIP2E+k7C7cBOguK+Hue6A3iKUvcR7mkItdmJmT/NZf u1f0k+NOXUX7bMDw7QI7Y2gbWxORZ9oBmoTdfiPMzre3gi4VPp2ECZqLf0z98AFLmSq2 xJuTmTc9XFP5LVyJ/sG0rBrZIP0ZlsMEZwvAxNP9Dwp9TryD1YTw9AOaPponZKXk569E xmNjr8a89WeyuAJHzwj+ISngjPgmOyW/Pf91eKqznF1JYJp10zKq4BzBwc2PYpVxanTn bLRbcEw0RJAKfpq7nkyB8T6KIS4hTJE17kqQizElYqOnOoaWt2MnWz4J5t3SLpYRrQTj P3ew== X-Gm-Message-State: AAQBX9eN2IWoCnlSVV1Eunrk74JZGifkGbWTnRqqvblcS1s5lVsZkDIf IBiOJ6xtwtREu8HPHk8A+T9DSbRuw/TrkWkulao3sQ== X-Google-Smtp-Source: AKy350ZqnYLSmT7eJTq65fiNra/60hMVxVRo2NTN5O7ip/pdM6ESKQ/7QeIH3HPcBu0i1k4EPDQhyQj9uL9p9e2MRY0= X-Received: by 2002:a81:e546:0:b0:546:1ef:54f9 with SMTP id c6-20020a81e546000000b0054601ef54f9mr2180958ywm.0.1680009924474; Tue, 28 Mar 2023 06:25:24 -0700 (PDT) MIME-Version: 1.0 References: <20230328061638.203420-1-yosryahmed@google.com> <20230328061638.203420-3-yosryahmed@google.com> In-Reply-To: <20230328061638.203420-3-yosryahmed@google.com> From: Shakeel Butt Date: Tue, 28 Mar 2023 06:25:13 -0700 Message-ID: Subject: Re: [PATCH v1 2/9] memcg: rename mem_cgroup_flush_stats_"delayed" to "ratelimited" To: Yosry Ahmed Cc: Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7342540022 X-Stat-Signature: h8nhkwxxkn1epf9szn35xj6ue5k9dqgz X-HE-Tag: 1680009925-229056 X-HE-Meta: U2FsdGVkX185twc27eZthYppbKO86Z7Vr9WNNf55kK5BSPvV+TWgGli5FUHO+0RAX/KfOElZxoO+/MxWlKx5KbvaRGgJK87eYsofaIhmJQBTpjpQLr6ykCsYmkbNmBAMtqMk1TNq0OLuD7BP5WGri2JlXP1Cmqk3PIetzke/DzgO4765PkhphVqYKxJOBcb/7mm2ONskKQxfdqI49p+BGHd0T8/sxn3DhUJwkJncIrgYYDveZqM1UzUveAT+N/TIfzIhsgq+CAktCZLB/8xHSMYD8Df065zyZ7BxQR+gr/Y4koLraDlcoOJotBtrXkRq0ltOaBFQ+E7qhQU0Q3GBA+qUJrDFmlGMnOX4NAPkVntfCN/7z3NzKKIOvXXgmTcGwbgh1c4nzjMqy3i+ungewvgSBGdmAZfMm65ExdXnMwzWzuGEqCFAh/G3D5VzAPWkhHl5eLLiVK7IMCArKoVVIwacBdjwEbszeSnCB7QwP0EHpz5pcUSI899SFOxDBOUlGjhh6fdbbS4rs7GCBK8VpWSyvaL7PFTIsAtaFOx6O5ADWURf3oBbkc1F9yDO7mI90UiwV9B58f3CZssTL4HF+9kbJaQbKsXwQV66TRdq3lbHmtRLsp6SzUZEXtKZr9HYVJ3IKKk61gBW+RhGZteZ1/JdRd77ziR+RYL/BcDrXCSvaB/D6achzsjtQIVFTlR5zpWstbTfonyVEuoGGXrJIq8HQWBrHv0ZVcHVnOabQZOuNqa0fli7EA9UUwjIiiz/IiWieGFbthY2wTCWoeJbGdqnfI+mtMILqESGm6HJRC+aRK5Q8VcpYWZs3O9Z9xDq/8ja7iuN5NGNKMtPC1SDDrgkBTHQL9vTM94yo7wtJ0Ry4m8RBRQwNOjxIZjPs1Z0lOegaLEwUBjb/L8EiTzaSfIKbwy2U89sCfQQh+LDfeWsdpIpqYcowPP8oI3b50qb2l+LcuzC3c7q6AxsCJb j+Zj9Zww XSYLiPZZU/y9MYDi/yG8lnneftg6OzcGwDp7fqM7PfkEjxmJQeM6AaGkwjtzAZHdqOwzUU0EM6zX1pBbw+7bL7Xs5fRnCmN3hXrax/K7IIEw3xeiHinP7dxTZoV/imOsRP3tuEwyRyTHKqATLEuSTYjTJOBpfIUEz1opgRfv1fBWc5KzfKDmPiLMfoLuWiBhX+LByXsG0NVaDEDB1LZ6xdV5JIM+HTDvDKwjZehCunYPcaPdGm/Pfbj1jdsQUFxab/jmAy7SYJeIaf0eP2LNbWx/T7cBp08TGczGuMPwYHt6wvkiL4tDIWv5av9FLCN67JF2ncXvG59pzg/7mNNu7tzo9koNwKb93Yj+rYDiAdL3fSiXGAF1WM7ZhDQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 27, 2023 at 11:16=E2=80=AFPM Yosry Ahmed wrote: > > mem_cgroup_flush_stats_delayed() suggests his is using a delayed_work, > but this is actually sometimes flushing directly from the callsite. > > What it's doing is ratelimited calls. A better name would be > mem_cgroup_flush_stats_ratelimited(). > > Suggested-by: Johannes Weiner > Signed-off-by: Yosry Ahmed Acked-by: Shakeel Butt