From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0953AC433EF for ; Thu, 12 May 2022 20:36:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 50DBA6B0073; Thu, 12 May 2022 16:36:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 495A26B0075; Thu, 12 May 2022 16:36:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3107E6B0078; Thu, 12 May 2022 16:36:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1AAA26B0073 for ; Thu, 12 May 2022 16:36:58 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DCEFB325B8 for ; Thu, 12 May 2022 20:36:57 +0000 (UTC) X-FDA: 79458250074.01.079AB67 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf05.hostedemail.com (Postfix) with ESMTP id 6152D1000B8 for ; Thu, 12 May 2022 20:36:38 +0000 (UTC) Received: by mail-pl1-f175.google.com with SMTP id c9so6045747plh.2 for ; Thu, 12 May 2022 13:36:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8iEGBmtJoxRg/w5RBuhSp0K5Od/nybtVVk1rH49oGiM=; b=ixitpKQ3SEMJx6+vyRqfYZFPsTDVscIcPWYVwAot2TlYWB/whS7xd2WA0N3kFVhdWv xykgHSXbXR13UoiVi6kmSmkzX2tfIsv7vsZph7eFSvV1S0D9T3FHIUWA8LMD0Do236on FTisXIdk9sh4KeO0hAlhE0GBNUnBqeKLa0sWqmXuxnr73Xr9DqUdwX/qiP840xQT6KmX vUwaNHv4yq0UjkHIbCtTCBZttGQQrebwZJ05pQro3hanExvUMkgnoB8A3xPfeZTScIFd ifuuI96/H0MEDTv8C00E3fyfMSJ/KwBkl5YM9aUbb9nKKbBlKdnD3y7zJcQs9AzZnuVI uC7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8iEGBmtJoxRg/w5RBuhSp0K5Od/nybtVVk1rH49oGiM=; b=Z5Z6PVFHUXLJgzUS3CMV05Z6IuboRjhb7iqthFfSi2bqQJLyj2YwXExC7MNL6ZrDes s/wugEZ16g8DtOACTIdDC9SpERYphStzRRE9dWOmjushEGKFBLzPlzYCUUZp4MSTbnzK lrZ8u3ylW+a4T4Sr9MVriFFXnpoLUe66SCi39boW4kpsn/acH2o5/9BsQQ4HRgzek9l0 Z7PmvrAWKCWlD25396xagxarBd9jU3fxmDXEjmQp9zaK36f3Y4BcYyT0m51dZZvEOwAk O6MxCtyVlWZcKdBOFU5G0d4ZQI1vS7T2YrhZK9YjlVGwzQl3AD4gRl5iglDt0CJpWUkK /Pzg== X-Gm-Message-State: AOAM530Vlk7j7FF94gPOBrtWYeQX2N/PskGtH4XaT+UJKDF02DE2bFee f71pYPQqY5wx7TuTL1sy9eryIuETQXhBbwJP/zm36g== X-Google-Smtp-Source: ABdhPJwuhYymsZ0StsyNYTXEvlNbykWVyGE1D/eBaulkendPrYdPMp+9LrsPeBKypjw3sXfyHpF2VAkA0+PEtw1SNjc= X-Received: by 2002:a17:90b:1d83:b0:1dc:4362:61bd with SMTP id pf3-20020a17090b1d8300b001dc436261bdmr12577913pjb.126.1652387816246; Thu, 12 May 2022 13:36:56 -0700 (PDT) MIME-Version: 1.0 References: <20220429201131.3397875-1-yosryahmed@google.com> <20220429201131.3397875-2-yosryahmed@google.com> <87ilqoi77b.wl-maz@kernel.org> In-Reply-To: From: Shakeel Butt Date: Thu, 12 May 2022 13:36:44 -0700 Message-ID: Subject: Re: [PATCH v4 1/4] mm: add NR_SECONDARY_PAGETABLE to count secondary page table uses. To: Yosry Ahmed Cc: Marc Zyngier , Tejun Heo , Johannes Weiner , Zefan Li , James Morse , Alexandru Elisei , Suzuki K Poulose , Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , Andrew Morton , Michal Hocko , Roman Gushchin , Oliver Upton , Cgroups , Linux Kernel Mailing List , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, Linux-MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6152D1000B8 X-Stat-Signature: tgmir7exzh7udt4zn1chqshnadc6tztj X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ixitpKQ3; spf=pass (imf05.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1652387798-801055 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, May 9, 2022 at 9:38 AM Yosry Ahmed wrote: > [...] > > > > > > What do you plan to do for IOMMU page tables? After all, they serve > > > the exact same purpose, and I'd expect these to be handled the same > > > way (i.e. why is this KVM specific?). > > > > The reason this was named NR_SECONDARY_PAGTABLE instead of > > NR_KVM_PAGETABLE is exactly that. To leave room to incrementally > > account other types of secondary page tables to this stat. It is just > > that we are currently interested in the KVM MMU usage. > > > > > Any thoughts on this? Do you think MEMCG_SECONDARY_PAGETABLE would be > more appropriate here? I think NR_SECONDARY_PAGTABLE is good. Later it can include pagetables from other subsystems. The only nit (which you can ignore) I have is the very long memcg stat and vmstat names. Other than that the patch looks good to me.