From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42E2FC433FE for ; Wed, 22 Dec 2021 06:06:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B3496B0072; Wed, 22 Dec 2021 01:06:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 963C76B0073; Wed, 22 Dec 2021 01:06:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82BF46B0074; Wed, 22 Dec 2021 01:06:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0057.hostedemail.com [216.40.44.57]) by kanga.kvack.org (Postfix) with ESMTP id 73F156B0072 for ; Wed, 22 Dec 2021 01:06:14 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3295C88CD3 for ; Wed, 22 Dec 2021 06:06:14 +0000 (UTC) X-FDA: 78944395068.26.AB1F105 Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf10.hostedemail.com (Postfix) with ESMTP id EB405C0022 for ; Wed, 22 Dec 2021 06:06:06 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id x7so2923512lfu.8 for ; Tue, 21 Dec 2021 22:06:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JxjacBwjJoYbgzWLXarSAngifcVatMlW+kbmP1VYJ6Y=; b=huVTVo6X+EOszoN9mmNCN7ZejGvAzZ9508W/Gr4LS48mbT0o5rDLAHe46h08zL6q49 4lDB2SD+Msqv8mVvXuVYinRmNCpIlFQ1GknfJ9YHZRj0awyOhswn6S3CdlPRgg2rQ1dp kTD/xxvbNzhIy0QfqIU/T7o1UrRelG+vMypO6y3MZADyFdrITdR3MXamGNkR/p7ui7Tq nLbIQDJLjNnLjX633ifOmbvHnazdtmfaTWV76mozDq3onlBE2Q/MRHVy5rSrbDRZNbrX YgrWMKYKBVg33sQ+HsYaeBIlwQkmjxHD9jeHtmmQf6TArCB4VL/jNTq5Wp1qVo+hEBLs 3TDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JxjacBwjJoYbgzWLXarSAngifcVatMlW+kbmP1VYJ6Y=; b=TCaj6udLzx32TcEUcfuIFUHwIkOHbUMOTaKeKpLcZlivIFeUyk985Zm9Bs8sxBvtp5 TiuDhcf4lzcxl8A3ayN9J/4HpaBdNBwHzYP/HeWfepQRlV2KAAfNYrVFK4cX/ojxl/of yk13qNKG/sXFCpUInfn5kEN4WcoK27HEQObzwdwEn74aN1tp0dX74G5lCnvvODmm9CRf ATlM6U+nFmpH6M/IthR9LCdZfTyX9LWGA5+lN/aMlHD07WioFNUl6h4FP/fZx9TBUP76 JbUlqiYA1MHgVrWj4kqu3Rhsg6h6hAfoQrx9NTBldal6+LvthDYR21+O67Oive1Mo4J4 jZLg== X-Gm-Message-State: AOAM530FM4S0Eo3zBKARe8/XO1mCApkn3X2wD/pU7My1x3pTEU7bawQE K8ALnN3cAVhoA8Uc8STsU+rdzfr+6k6EqCqHYGe/hrtLayI= X-Google-Smtp-Source: ABdhPJz529xFqKPOhLy/leKzNzkzQUFsdZskr38jdM4KpzidFcnr/DXETsbVDjN5mqP6V3AmtWJKVOesfUNLbkZWXLU= X-Received: by 2002:ac2:446d:: with SMTP id y13mr1283045lfl.210.1640153172045; Tue, 21 Dec 2021 22:06:12 -0800 (PST) MIME-Version: 1.0 References: <20211222052457.1960701-1-shakeelb@google.com> In-Reply-To: From: Shakeel Butt Date: Tue, 21 Dec 2021 22:06:00 -0800 Message-ID: Subject: Re: [PATCH v2] memcg: add per-memcg vmalloc stat To: Muchun Song Cc: Johannes Weiner , Michal Hocko , Roman Gushchin , Andrew Morton , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: EB405C0022 X-Stat-Signature: poypfdpyxtxyyqyzubtso837j6gfomxe Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=huVTVo6X; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf10.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=shakeelb@google.com X-HE-Tag: 1640153166-270617 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 21, 2021 at 9:50 PM Muchun Song wrote: > > On Wed, Dec 22, 2021 at 1:25 PM Shakeel Butt wrote: > > > [...] > > @@ -2626,6 +2627,9 @@ static void __vunmap(const void *addr, int deallocate_pages) > > unsigned int page_order = vm_area_page_order(area); > > int i; > > > > + mod_memcg_page_state(area->pages[0], MEMCG_VMALLOC, > > + -(int)area->nr_pages); > > The cast can go away since the type of 3rd parameter of > mod_memcg_page_state() is int but not long. I suggest > to remove it. Anyway Andrew, please remove this cast of the third param when you add this patch in the mm tree. > > Reviewed-by: Muchun Song Thanks.