From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4E50C0044D for ; Mon, 16 Mar 2020 23:47:30 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 945E020674 for ; Mon, 16 Mar 2020 23:47:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="VJRDb5WO" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 945E020674 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2EE916B0005; Mon, 16 Mar 2020 19:47:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2C5E96B0007; Mon, 16 Mar 2020 19:47:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DBAB6B0008; Mon, 16 Mar 2020 19:47:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0019.hostedemail.com [216.40.44.19]) by kanga.kvack.org (Postfix) with ESMTP id E0FBE6B0005 for ; Mon, 16 Mar 2020 19:47:29 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C8047181AEF15 for ; Mon, 16 Mar 2020 23:47:29 +0000 (UTC) X-FDA: 76602864618.23.nut05_416c2cfcfab50 X-HE-Tag: nut05_416c2cfcfab50 X-Filterd-Recvd-Size: 3798 Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by imf40.hostedemail.com (Postfix) with ESMTP for ; Mon, 16 Mar 2020 23:47:29 +0000 (UTC) Received: by mail-oi1-f194.google.com with SMTP id r7so19851165oij.0 for ; Mon, 16 Mar 2020 16:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mttFfSWICKfg0VDWFFFpM6bA1x4vo0nhvLSocXypSiE=; b=VJRDb5WO8N3vm52u9Y7VxkYqd/KhwpCssTVF/UwGUFlYgdoiGLRlnTUYkU9oIQoMQk m8j0d0lURsNmVvD3V1Z1Aoq8rlugoZwTRKdpUND6SgGvq4CnIajRHPg6bsOL1/XgkKzD Pk1/Zs30aVEax2sFOkLTEMZiUf4NPPZSy8ta9mhmquYZB0c9pSUphzMiiEREtt77WooC 6Sr7l50eJdZBYCK2hIN3ti+zO0Nw5bYwmDfBDPpcWq9zfUUnJwtHc7duN2CeM48dCKCn oqF1nho6Yy7VEJIKNvggGf8WA9JuYp9O86nhacVnnp0Y5lIcN5VLRAVlwvZBy8mojr/l pqWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mttFfSWICKfg0VDWFFFpM6bA1x4vo0nhvLSocXypSiE=; b=M6com0I6GLqNBBXqiLHg+B0IGYfYB2vezdLoIRb+hnWO6k05C1nWQnmfMzr4elXvb6 dqTFHoEDzGw9xbl6zMaERodVw7SYTVEW5DY/E6F4BPWaU4XuyDdlNYZULGmqJzJpk5Xm Rbn9Fg9i68xuqKHNhKIKdq1oD6Ucwx+aQ03S9BFoHyh4xPxMhg6sOiR934bj06irkfD7 veLDvrICQQT5mf9/XHGSWfq5T/dfvjq8WWQUanRf1t7/CgS07MhMaHXP/8qXrTm06cN3 WFTF6xO1DpKXq1XxftIQUxBoi5dvhX9I73WMcnRCx1m5G0ElhrWbDJs8tSd+G3EKGSWe 9xoQ== X-Gm-Message-State: ANhLgQ0mJYkJ/ptUbOHwxTMUA2HDmEJ728Ml7MCJmu7nsxZWRF5H71Gp AeI4fKq/3g/L8/hNz9sXomjrLDVVCO6TJGEHyi6/3g== X-Google-Smtp-Source: ADFU+vvf58lvIOAfydJM85FoH4fCfYl73Pwkpod8CRWAMB79NSEFG3mZJIsM7IndHf4CMxqGHbsvsMyMno0Is2Ju4oc= X-Received: by 2002:aca:4b56:: with SMTP id y83mr1554187oia.142.1584402448153; Mon, 16 Mar 2020 16:47:28 -0700 (PDT) MIME-Version: 1.0 References: <1584397455-28701-1-git-send-email-yang.shi@linux.alibaba.com> <1584397455-28701-2-git-send-email-yang.shi@linux.alibaba.com> In-Reply-To: <1584397455-28701-2-git-send-email-yang.shi@linux.alibaba.com> From: Shakeel Butt Date: Mon, 16 Mar 2020 16:47:15 -0700 Message-ID: Subject: Re: [v2 PATCH 2/2] mm: swap: use smp_mb__after_atomic() to order LRU bit set To: Yang Shi Cc: Vlastimil Babka , Matthew Wilcox , Andrew Morton , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 16, 2020 at 3:24 PM Yang Shi wrote: > > Memory barrier is needed after setting LRU bit, but smp_mb() is too > strong. Some architectures, i.e. x86, imply memory barrier with atomic > operations, so replacing it with smp_mb__after_atomic() sounds better, > which is nop on strong ordered machines, and full memory barriers on > others. With this change the vm-calability cases would perform better > on x86, I saw total 6% improvement with this patch and previous inline > fix. > > The test data (lru-file-readtwice throughput) against v5.6-rc4: > mainline w/ inline fix w/ both (adding this) > 150MB 154MB 159MB > > Fixes: 9c4e6b1a7027 ("mm, mlock, vmscan: no more skipping pagevecs") > Cc: Shakeel Butt > Acked-by: Vlastimil Babka > Signed-off-by: Yang Shi Reviewed-and-Tested-by: Shakeel Butt