From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDD19C433F5 for ; Mon, 18 Oct 2021 17:44:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7BB1D610C8 for ; Mon, 18 Oct 2021 17:44:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7BB1D610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 50C28900003; Mon, 18 Oct 2021 13:13:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4BBA8900002; Mon, 18 Oct 2021 13:13:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D117900003; Mon, 18 Oct 2021 13:13:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id 2F18B900002 for ; Mon, 18 Oct 2021 13:13:36 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DB1A818087261 for ; Mon, 18 Oct 2021 17:13:35 +0000 (UTC) X-FDA: 78710204790.20.6C67AED Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf21.hostedemail.com (Postfix) with ESMTP id 14D0BD042B40 for ; Mon, 18 Oct 2021 17:13:33 +0000 (UTC) Received: by mail-lf1-f54.google.com with SMTP id y26so1164964lfa.11 for ; Mon, 18 Oct 2021 10:13:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DyNcrwLKTjtZ0VloCKphs+CNM4GqGJ0HGRhbR/SC9mk=; b=mijnuQhJ93hdYipWZXXygB5cY0SIRliRAWdWH3/kL+XbMVop56Aczh+/fs0SiJ4dTo 1Jzme2KYKdg9zMBZ374t9j+jHm3BDMuePiHsAp43XySR+grbVlX7G+/IxLq8E/VDhRrf WkGghth9kDhfkSTT+6XINlNGdF89J7AvQIyRG4JrsOZcY94WatVDEuPklMLvBOmQGhYE RJbWGCaEyRLuT/L3C2y1WDN9KZe+1+5UKPx4GfqvCY/x1xeRxyXhtIkxYuq3knq0VGsZ okIJhAaFnB1/4Db26FYIwYsIepSIErmBT22pXILJNwPvl5f8TykZ59Qc4bLYd5U+j6A0 fz9g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DyNcrwLKTjtZ0VloCKphs+CNM4GqGJ0HGRhbR/SC9mk=; b=62TR96b1s74fXDbC4k41VapSfVMAeIdByoHWhX11MuLjXR/ujmYTxmdD9k8ihqNJ0W 7yf9BO84D4Zh0pHJxX/i7qLOk/mU1kIpkCM/4QX5YhqL3GJDlvPw9yEvmuovg76dsGXe Yoajn5MIZN6TWVJBF5IDOyx+KxYG61Ha0pqNi0DVO9opUanEyWfzwh39qPbi2Js4jT6N 4d+8IiceiYkqzwXxvHDKYPEPVYA3guOqa/Tyb6OAI/pZNY7XbJWNkxtGYIqCFsC/jexw 8i8OayLe1qgj6d7/2Q3UD3DAbt6r6iZ5+LCwkFaSiuvZXRxeVnzQ4wpYLhnch9yh50GG dlXA== X-Gm-Message-State: AOAM530OSB1LHX64CNdGCSD2HHVPjMg0qrBpCfWvgEesnNYfQiHSPhcC 2v2ifHv0QscRAgK0+RSr2lVt9kyWWPdb3wghCgEtUw== X-Google-Smtp-Source: ABdhPJy9C4YY6DPN5j6xi0NmPgIh1Q/YnUEACZ7btLDN5oJvzX5DpC6/4m/DKieWSXhrrtBlIYIA/sLEylOo4nTj5wA= X-Received: by 2002:a05:6512:3d16:: with SMTP id d22mr964698lfv.20.1634577213797; Mon, 18 Oct 2021 10:13:33 -0700 (PDT) MIME-Version: 1.0 References: <9d10df01-0127-fb40-81c3-cc53c9733c3e@virtuozzo.com> <6b751abe-aa52-d1d8-2631-ec471975cc3a@virtuozzo.com> <27dc0c49-a0d6-875b-49c6-0ef5c0cc3ac8@virtuozzo.com> In-Reply-To: From: Shakeel Butt Date: Mon, 18 Oct 2021 10:13:22 -0700 Message-ID: Subject: Re: [PATCH memcg 0/1] false global OOM triggered by memcg-limited task To: Michal Hocko Cc: Vasily Averin , Johannes Weiner , Vladimir Davydov , Andrew Morton , Roman Gushchin , Uladzislau Rezki , Vlastimil Babka , Mel Gorman , Cgroups , Linux MM , LKML , kernel@openvz.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 14D0BD042B40 X-Stat-Signature: efw97jmy9u3iuszi4qrojedc39a7ztrt Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=mijnuQhJ; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Rspamd-Server: rspam02 X-HE-Tag: 1634577213-478611 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Oct 18, 2021 at 9:51 AM Michal Hocko wrote: > > On Mon 18-10-21 08:07:20, Shakeel Butt wrote: > > On Mon, Oct 18, 2021 at 5:27 AM Michal Hocko wrote: > > > > > > [restore the cc list] > > > > > > On Mon 18-10-21 15:14:26, Vasily Averin wrote: > > > > On 18.10.2021 14:53, Michal Hocko wrote: > > > > > On Mon 18-10-21 13:05:35, Vasily Averin wrote: > > > > >> On 18.10.2021 12:04, Michal Hocko wrote: > > > > >> Here we call try_charge_memcg() that return success and approve the allocation, > > > > >> however then we hit into kmem limit and fail the allocation. > > > > > > > > > > Just to make sure I understand this would be for the v1 kmem explicit > > > > > limit, correct? > > > > > > > > yes, I mean this limit. > > > > > > OK, thanks for the clarification. This is a known problem. Have a look > > > at I think we consider that one to 0158115f702b ("memcg, kmem: deprecate > > > kmem.limit_in_bytes"). We are reporting the deprecated and to-be removed > > > status since 2019 without any actual report sugested by the kernel > > > message. Maybe we should try and remove it and see whether that prompts > > > some pushback. > > > > > > > Yes, I think now should be the right time to take the next step for > > deprecation of kmem limits: > > https://lore.kernel.org/all/20201118175726.2453120-1-shakeelb@google.com/ > > I completely forgot about your patch. Anyway, it usually takes us years > to deprecate something so let's stick with it and consider 2 years as > years ;) > Sure, I will rebase and resend.