From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1C5BC433E2 for ; Mon, 31 Aug 2020 14:40:22 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9D89F20767 for ; Mon, 31 Aug 2020 14:40:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SeXPIm+A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D89F20767 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 260F36B0003; Mon, 31 Aug 2020 10:40:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EC4A6B0055; Mon, 31 Aug 2020 10:40:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 062C46B005A; Mon, 31 Aug 2020 10:40:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0165.hostedemail.com [216.40.44.165]) by kanga.kvack.org (Postfix) with ESMTP id CBFF06B0003 for ; Mon, 31 Aug 2020 10:40:21 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 73BB4180AD806 for ; Mon, 31 Aug 2020 14:40:21 +0000 (UTC) X-FDA: 77211124242.15.straw92_4c11d4827090 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 981711814B0C1 for ; Mon, 31 Aug 2020 14:40:20 +0000 (UTC) X-HE-Tag: straw92_4c11d4827090 X-Filterd-Recvd-Size: 4248 Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Mon, 31 Aug 2020 14:40:20 +0000 (UTC) Received: by mail-lj1-f195.google.com with SMTP id t23so7005969ljc.3 for ; Mon, 31 Aug 2020 07:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uPSqj5hFIPGTyO7lh981GDp+TXnOtHBASn3RvL7Epes=; b=SeXPIm+AHj0Qf+3vNfhXciscqUdpDnei3CTwlmJ3ECw+JJX62FZGyZj34aJbxF7MHT A7t6pHhnVdftJTMq/p3NFn6gNaqNb9bp4eg47QKNZveAf9BB3De0o8nrD3u8FtYU5LwF roK2Zbvn8/jO2c8Wk0lHgVBDxhWFxXS4/8sOU/JXCcI+5QlBrOu0dbKspkGoDqklfmJl OzWlofbJasZYGNIkUZMK6hGOVqYJrjpKx2C/8jOuR91QjD32jia8+NH+cInBQjcWeVMk ogfwev8Aq6R1byneK54x81HVJD0zI6VrtqGL3n4q55KYXjaZtYVSezvabxhm122BhczJ 7dPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uPSqj5hFIPGTyO7lh981GDp+TXnOtHBASn3RvL7Epes=; b=f+T6btpi1BTijWRWuEB0xU6nqwIK34tU6IZNJFoh2lTaHqaY0o4ZP5ylsPkCr2H+7S XKkoJPEwmbR6zqx3N/nV3K2Q0WifNK4t4KNvGo2rk5FfEMk6CUWqWETmY3WkZ5Ev32nv jZ8kzIALeHnzmKk5FyTeh8EsQIjCFRmyQ65S7jslc9NTDhBbwVhxWJ04P6/xdup+m3Oh ZB77znjgXp15Zg0o/VBkL/gU0nALfIAbDbzKmJnRfBTC2QFzSZBJb5K118RmTv8Gjybw ew+x12cTPlZ1ZH6Lxn8fznYsYztjqSPaXLAZncqeXfoCwDJI4tu+eNb42Bnbc2mkiawy tmhA== X-Gm-Message-State: AOAM532TjsDLuw/JtAQdMTJZu+37IMmBI4cauT64oHGaKIBO6ZgbyUdw 1EYQnXnsAhGdhHUPKVdTqrzCaLATFSrDmsMNy2YM+Q== X-Google-Smtp-Source: ABdhPJxKhqneFyPz1YbBKIJfjdrx6iMgdDyxAGp2l4ViVDxHjMNh4ZG4w4LWplUEZzwSRj7P5fWrO5fjBZkCAaIA7PM= X-Received: by 2002:a2e:96c3:: with SMTP id d3mr859612ljj.270.1598884818405; Mon, 31 Aug 2020 07:40:18 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Shakeel Butt Date: Mon, 31 Aug 2020 07:40:07 -0700 Message-ID: Subject: Re: [PATCH 1/5] ksm: reinstate memcg charge on copied pages To: Hugh Dickins Cc: Andrew Morton , Alex Shi , Johannes Weiner , Michal Hocko , Mike Kravetz , Matthew Wilcox , Qian Cai , LKML , Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 981711814B0C1 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Aug 30, 2020 at 1:59 PM Hugh Dickins wrote: > > In 5.8 some instances of memcg charging in do_swap_page() and unuse_pte() > were removed, on the understanding that swap cache is now already charged > at those points; but a case was missed, when ksm_might_need_to_copy() has > decided it must allocate a substitute page: such pages were never charged. > Fix it inside ksm_might_need_to_copy(). > > This was discovered by Alex Shi's prospective commit "mm/memcg: warning > on !memcg after readahead page charged". > > But there is a another surprise: this also fixes some rarer uncharged > PageAnon cases, when KSM is configured in, but has never been activated. > ksm_might_need_to_copy()'s anon_vma->root and linear_page_index() check > sometimes catches a case which would need to have been copied if KSM > were turned on. Or that's my optimistic interpretation (of my own old > code), but it leaves some doubt as to whether everything is working as > intended there - might it hint at rare anon ptes which rmap cannot find? > A question not easily answered: put in the fix for missed memcg charges. > > Fixes: 4c6355b25e8b ("mm: memcontrol: charge swapin pages on instantiation") > Signed-off-by: Hugh Dickins > Cc: stable@vger.kernel.org # v5.8 Reviewed-by: Shakeel Butt