From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F683C56201 for ; Wed, 18 Nov 2020 20:07:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CB4C62225E for ; Wed, 18 Nov 2020 20:07:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="auA3imED" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB4C62225E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1B9566B0036; Wed, 18 Nov 2020 15:07:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 190066B005C; Wed, 18 Nov 2020 15:07:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 080B16B005D; Wed, 18 Nov 2020 15:07:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0021.hostedemail.com [216.40.44.21]) by kanga.kvack.org (Postfix) with ESMTP id CF8696B0036 for ; Wed, 18 Nov 2020 15:07:54 -0500 (EST) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7CEF68249980 for ; Wed, 18 Nov 2020 20:07:54 +0000 (UTC) X-FDA: 77498624868.09.nut70_3e16a052733d Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id 5F4F7180AD837 for ; Wed, 18 Nov 2020 20:07:54 +0000 (UTC) X-HE-Tag: nut70_3e16a052733d X-Filterd-Recvd-Size: 4174 Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Wed, 18 Nov 2020 20:07:53 +0000 (UTC) Received: by mail-lj1-f194.google.com with SMTP id x9so3735568ljc.7 for ; Wed, 18 Nov 2020 12:07:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=yeKLzuYfSfYjwv9jvXe2h8dCQ8PeIQ4687zDP48KQD4=; b=auA3imED+bIoRMFGpqlHbmGJvk5kJIVk9BvJ71Ira2vwQeTwsyJoF2ODXO+9860si8 gGjs0urQ/Cc2ujf7odeViQab+MFQjbKyera6rW0BZgPgDUbpSn4h0vHZ6Mrw7fnkOS4/ kyW9BeyxpySDSnlLImvtf8XWUsJ80qtN+eYto7cHVh8iQ5T8p3mk/aCGOwd2ia2g4Wx2 9WGJTUhcmEpRjMBm7Aboc0RJsXYZVbZpBx4XfjC4B4H3WpCC9/Qp3WdmCbX/du9KoVrC tU0ah1OTAK7NJyi7Q291Mdo/fZ60pSDzMEKHw6I9rXgeJb6DgqSwvz3NX0nMCGEqfyq/ hhCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yeKLzuYfSfYjwv9jvXe2h8dCQ8PeIQ4687zDP48KQD4=; b=uBl6WMzb9BDHo871qprlAM6hkliFyLcv7EhvSdAISvBrBk5IMoTSDJ6U9inMPFLBcX EHBDHTXpNxDHBMnfyv49D6vukH5RYFotv4o0BCpeJUgbfb0WOata7sstOw7omyDg9qLO zVh+maHsIXahVBrXROAzyRA91Bt9eR5KFdfqa3d2CGMXRsmWiy1pNfIX8YprdGJU9+uA 7jFoK8t0MFkr2BBSx1pjIVt8zehrBg/OQlewDnUeJweYlCTR78Qo9ORGbN+vn/zoKMuv cEeQaUALebNBL3Hnm/W9yJO7wPqtkBZXmmHb6IgEpjM/R059lOEM0ui3tgEXgpDotIkL 4kzA== X-Gm-Message-State: AOAM5338N39/i8cCETMiKzubKK37kRQR7XjBF6Gymsi+gyRaxwNxBpiK Mx61z5qdlGaI/V+EBfT9bKefLWtpSYRUZIfe93Rf0A== X-Google-Smtp-Source: ABdhPJwJ18EsoGPbvczbpZK4lj+zDySbnfbpX0LfAcTYVKWWJzj2P1bJUMLF8F/dQKOCRgpXcYsePLJ5tnNGIwss8Jo= X-Received: by 2002:a2e:58a:: with SMTP id 132mr4584575ljf.77.1605730072077; Wed, 18 Nov 2020 12:07:52 -0800 (PST) MIME-Version: 1.0 References: <20201118175726.2453120-1-shakeelb@google.com> <20201118195822.GW12284@dhcp22.suse.cz> In-Reply-To: <20201118195822.GW12284@dhcp22.suse.cz> From: Shakeel Butt Date: Wed, 18 Nov 2020 12:07:40 -0800 Message-ID: Subject: Re: [PATCH] memcg, kmem: further deprecate kmem.limit_in_bytes To: Michal Hocko Cc: Roman Gushchin , Johannes Weiner , Andrew Morton , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 18, 2020 at 11:58 AM Michal Hocko wrote: > > On Wed 18-11-20 09:57:26, Shakeel Butt wrote: > > The deprecation process of kmem.limit_in_bytes started with the commit > > 0158115f702 ("memcg, kmem: deprecate kmem.limit_in_bytes") which also > > explains in detail the motivation behind the deprecation. To summarize, > > it is the unexpected behavior on hitting the kmem limit. This patch > > moves the deprecation process to the next stage by disallowing to set > > the kmem limit. In future we might just remove the kmem.limit_in_bytes > > file completely. > > > > Signed-off-by: Shakeel Butt > > I am not against this. I am just not sure whether one year is enough for > those users who tend to have a more considervative kernel upgrade path. > I am not worried about SLES user base much as we didn't even enable > KMEM accounting when it was still guarded by a config option. Not sure > about others though. > > Considering the code cleanup is not that large, I was thinking of removing the kmem page counter in the followup but thought of sending this alone to see if now is the right time. > I would rather wait some > more. But you can add > Acked-by: Michal Hocko > > Maybe we can ask Andrew to put it into mmotm for few releases. > Ok with me. I will send the full series and will ask Andrew to keep the series in mm tree for a couple of releases.