Re: [PATCH] memcg, kmem: further deprecate kmem.limit_in_bytes

[Shakeel Butt <shakeelb@google.com>]

On Wed, Nov 18, 2020 at 11:58 AM Michal Hocko <mhocko@suse.com> wrote:
>
> On Wed 18-11-20 09:57:26, Shakeel Butt wrote:
> > The deprecation process of kmem.limit_in_bytes started with the commit
> > 0158115f702 ("memcg, kmem: deprecate kmem.limit_in_bytes") which also
> > explains in detail the motivation behind the deprecation. To summarize,
> > it is the unexpected behavior on hitting the kmem limit. This patch
> > moves the deprecation process to the next stage by disallowing to set
> > the kmem limit. In future we might just remove the kmem.limit_in_bytes
> > file completely.
> >
> > Signed-off-by: Shakeel Butt <shakeelb@google.com>
>
> I am not against this. I am just not sure whether one year is enough for
> those users who tend to have a more considervative kernel upgrade path.
> I am not worried about SLES user base much as we didn't even enable
> KMEM accounting when it was still guarded by a config option. Not sure
> about others though.
>
> Considering the code cleanup is not that large,

I was thinking of removing the kmem page counter in the followup but
thought of sending this alone to see if now is the right time.

> I would rather wait some
> more. But you can add
> Acked-by: Michal Hocko <mhocko@suse.com>
>
> Maybe we can ask Andrew to put it into mmotm for few releases.
>

Ok with me. I will send the full series and will ask Andrew to keep
the series in mm tree for a couple of releases.