From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86997C74A5B for ; Thu, 23 Mar 2023 19:09:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 243486B007D; Thu, 23 Mar 2023 15:09:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1CD586B0078; Thu, 23 Mar 2023 15:09:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06EDF6B007D; Thu, 23 Mar 2023 15:09:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E598F6B0075 for ; Thu, 23 Mar 2023 15:09:47 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A8F9C1A07C9 for ; Thu, 23 Mar 2023 19:09:47 +0000 (UTC) X-FDA: 80601102414.07.05BF94C Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by imf21.hostedemail.com (Postfix) with ESMTP id E1F971C001B for ; Thu, 23 Mar 2023 19:09:45 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=iWmN5qdQ; spf=pass (imf21.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679598585; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vLtQVw9Q3r/EIfGHaHQqJXqtgGhueRqlggc/xqxY+5U=; b=3OFRjOHiAI0+4hjEY6ukZZg7qYFK8Ug6KuEeBPz4sXzB4ezt6DtcKzRm+txi8IDFHZRHQ1 rX1/hdaDETZTY8V4dq9Cdi8eu8x4LvBvavOC7RstcYAOWTLPKzE0qwoVQnH/mJHUwfsHLk 7ivUA8sIbxM5kEWFGba6Kcu2148z3Eo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=iWmN5qdQ; spf=pass (imf21.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679598585; a=rsa-sha256; cv=none; b=ADBhLbp6IbEmITEND+67+l0Csb6d5YgKokk+hGFDNn032vDTpPwc0XOmdMBEQ3rtu3y3pc rjv5zj71yuA0S2cdBlis0O0Vc+ShOrnksJxJUIJEuDnDbwFxvj9yPRIJi7SX3gZfJWcDZq artroIvz7q1qMSMq5e7UfnFffNxKNeE= Received: by mail-yb1-f170.google.com with SMTP id y5so26122977ybu.3 for ; Thu, 23 Mar 2023 12:09:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679598585; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vLtQVw9Q3r/EIfGHaHQqJXqtgGhueRqlggc/xqxY+5U=; b=iWmN5qdQNSjpgISH3j2kib5cc+h8AoBaK9c2AaVVVURUW5rI9o8n06FvmV1M+bBFfX YNubq65NBM6w9TNZeohFGxGQHBSYpmJ2MVCGqXlkjI0pG66JFFF6zyIvXaCtVFAsMNFh hXEcIALahsRpm5ULADGvB6dWEK8Cco4UeMk/PeV198/yaHKWNMbjOkpRw/jOeaVEUa88 WYew6Gts30zeIuE6WLRNasfDpPaC4wq9Q+TgniIJZLVp7q+T9A9NqwNBf4mhube6dHtB lKvNpdpZCmdXI0XAsx+tbsEVIpm8bgaFMld59t1NK22AG0oMOtTQgmguJ9Zy1dAlKVSJ vknQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679598585; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vLtQVw9Q3r/EIfGHaHQqJXqtgGhueRqlggc/xqxY+5U=; b=0wCSnWLfOBS2yVp50fmzB5mz5xreCanoKJj62SswBgZDiKu4qX8WUbjK/DPTGAZGxq wewCmwxQQ7eduPApHVSOIc+Rw8rBY9lI2KvTi1/qowbnkRJlcjgwEOGhVqtF2WfqfvoT 6/RE2HLwB5Rr2lnVMygc1fGN5lZVPEkw52JLphFATpiC4IK14p3w1Q0d1G8gVUbAGSw6 6VDm1sVNYW26DfbJ/kBDmpCwxzjYs5a5935Ew5/aOwHFM+Z4HUrhLaTCELntWuSjykp5 dfw3FTeSaOUcnRvNNKecmI9olS9SgMCGMI9dyo6H0f1kcfYUMVlDCwZowV/kkW6FNnSK NbzQ== X-Gm-Message-State: AAQBX9ciQM9yfFIYzeW4TAgkX+zxTVDz5falSWQIW8YxgKOxXJw+17xV Z6LR4sBV49IqMxCLTJ8K99OIoDwk+o0zFBZKA7qG8Q== X-Google-Smtp-Source: AKy350akUM/9iIf8a3thcZVFCFca2DEXgqBqR2kjsnCDm5WKBJDwjnFCzpyD3JyTXxOLuZxXO5ARoUIWjEn4MKy8lr8= X-Received: by 2002:a25:a28f:0:b0:a99:de9d:d504 with SMTP id c15-20020a25a28f000000b00a99de9dd504mr2809088ybi.12.1679598584842; Thu, 23 Mar 2023 12:09:44 -0700 (PDT) MIME-Version: 1.0 References: <20230323040037.2389095-1-yosryahmed@google.com> <20230323040037.2389095-2-yosryahmed@google.com> In-Reply-To: From: Shakeel Butt Date: Thu, 23 Mar 2023 12:09:33 -0700 Message-ID: Subject: Re: [RFC PATCH 1/7] cgroup: rstat: only disable interrupts for the percpu lock To: Yosry Ahmed Cc: Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E1F971C001B X-Stat-Signature: bh6spptisabd5d79fjbgk4uw45s3ixis X-HE-Tag: 1679598585-484551 X-HE-Meta: U2FsdGVkX19P60hFUCO40w7yIV/vOBNForxVJ+Ur6PAp3BlXbCzBdCpWSGC39lofHEThOD4hsBEeIBnwqc977gKn6m3+1kwMVzSSzhAv+MC35APcoerl3GN1WPqCTLrx2EodeSXwdGNd+hySlx0BO21a7MfynMXGA/93GEzVr0LDGElsOa95lf5EGOyJH176xkZaOSPbOsQT0DZvt5boKYFoPXYxByXLf+Q/MeJXp1QIC4YPmuDIT1meAPVzglW62zfRItrFMBCawRIqpGAE14WCXTQ/rQvZkOGCsiHcIuvsxTY5v1IOBla/suSWIKtPDVIlUm0aQz1xqN64YF30cdlTjEBlgoiD1w314gMcfJ0srnzfFqqXYqcMVY6252efr+p4iMr68hPM8P9zwvqkhc4OzIX4f4VWR0dcVSJMWNyRn2SOqzscSxC+Fr/gT9BhPQtB0UBajMLgkweR9OZbPTw3IIpLuETgBOutlrN/zfdGactEQuPtV6mD7QbI7ImhsQVC+1pUtIWwz/r9JdD3EScoOAGB3d0lXPFNfoQaN/voaV+IGaE/jdF2pI9WORWnMtY8DE4sxifBs2sTRoltfHfOtxaC52A84Wk01dig0MqKa5XzE2neiwAPyNB6t4KOjuyBcxotvDg/knK6ViMvDrFY/bPwxLxpPfT0Wj3ZJTzgom7Bkqj+952MdPaMofe/lxMk7hoVzvDRzAwwuurlceAaHlna8VinGhwBTFI6xgpGP1yt2GMaDyqpk2cele3bqsTWmWRUXRnnhzR/P2sZJ5azqwJwb5Du7DibONKb2kmmiV3vXa5qlkxLRa+WuSO1ieCdlEr2wwBLsjN2KD8xWeew4YHoqyoeSSTU8sG3vSdphmHsr9UTOAigrQnNIXMRK7bvxkG5+0nblg0EbgN0NLJhfAZq7CL3nOXQya5aOauDq0DZhXjO+CYNOumeADezLE+QJN0MbOufNGftXCn f2PdmS3h pS14nNQPqVc+SLyCV4aoMnEbeBCMNQRPxXH+TDsklbixawtmU1Wg+LhUUKjTiYv8PvOQArwK/iuWlQby8rbTDpSeZMF0TKDuS48UPFmDQTawbQfZ6Tde4TvHLUMuHWA7/yHtw2SQKhX/OdhRrS4Ql82Jlq1CrGXX5l3YL+o3yJf9GJwM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 23, 2023 at 9:52=E2=80=AFAM Yosry Ahmed = wrote: > [...] > > Sure, I can do that in the next version. I will include a patch that > adds an in_task() check to mem_cgroup_usage() before this one. Since > BUG_ON() is discouraged and VM_BUG_ON() is mm specific, I guess we are > left with WARN_ON_ONCE() for the rstat core code, right? > > Thanks Shakeel. Any other thoughts I should address for the next version? This is all for now (at least for this patch).