From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D557CC7EE22 for ; Wed, 10 May 2023 19:00:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 05ADD6B0072; Wed, 10 May 2023 15:00:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 00CF76B0074; Wed, 10 May 2023 15:00:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E14BA6B0075; Wed, 10 May 2023 15:00:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D1DC86B0072 for ; Wed, 10 May 2023 15:00:19 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 96BEB120B19 for ; Wed, 10 May 2023 19:00:19 +0000 (UTC) X-FDA: 80775260958.12.7D42BF0 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) by imf23.hostedemail.com (Postfix) with ESMTP id 66417140034 for ; Wed, 10 May 2023 19:00:14 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=BvJIvdH3; spf=pass (imf23.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1683745215; a=rsa-sha256; cv=none; b=hVO59SusLyQ9Bbr31yYEJstcnX0nXiZ84CF3qMFMh/DE0tZ4vUniQKnTIpV663s+7H86TE ZWffQY6X4k3QuiJ5VUMTSGzVDfbcslpkk3n+PH8opokt3dbFNegT3ZkD5wDoCy/+p/qxxy 30WXHM7EfRZ/Q40fdn0dspC7evrsCZM= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=BvJIvdH3; spf=pass (imf23.hostedemail.com: domain of shakeelb@google.com designates 209.85.160.169 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1683745215; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xKsdgPcqj7KmYQZqWilT9rwcetEcIXv94yhUAf7G1sA=; b=r42NhNetFWHChHaTH2srOb9iI0qQ8MNkN2euVsG3CWCOQjKTLJ36pp+YD1LwB40Y/5ubef s0cL8XM8GathqZstI+w24ReueQ1Nr8wMKSxLoO4fnW/JCmRh1H9WNaaPpURNZGXNPzF9Bc tbP9aEwKuE08hDwQLadgegCWWV4Xt7c= Received: by mail-qt1-f169.google.com with SMTP id d75a77b69052e-3f38824a025so574401cf.0 for ; Wed, 10 May 2023 12:00:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1683745214; x=1686337214; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=xKsdgPcqj7KmYQZqWilT9rwcetEcIXv94yhUAf7G1sA=; b=BvJIvdH3Wybsgy9FE4pyTQfaOjRyNKOOtwD8AxKBkOLwQnEb8UA1Ez5R0nRn2CFFBL BXgoH7pw0kursav4wE2lwTrsKDnbBpwm7XG4ro5lrOuMCnNM9OqssguSNAUo7HbNaWwC j40w6tVnkluvyUchlgU8rYyRRcEQwmE3Zpnbh6RscDtfNz10rYG0KfpUKVd8wmoNZj9I vTdcpjPoxtgDsptCivj+6K0OgYH6Bcgllqe2Y3mDvoTxA67v54GNd+C7Q5M4TB3/70n0 h5NlSITmtP1wgtX8LZtx21dkK0mPYkk0oTPqWfrXi9seT6ecC66ADSSg2marBGDzT/7q kIZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683745214; x=1686337214; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xKsdgPcqj7KmYQZqWilT9rwcetEcIXv94yhUAf7G1sA=; b=eNPNdXZyLQl/GdVtJQI2PtSmbEppVATbmPZEzIIQpBCy4QooWztUm/WpOuvbfX04/4 cDOMorONDbgBv4CNKDZB3fqYikVpRfuKQDB/4bMP0842HN4OEbrGCxu2VjbT8e5OgF68 RswiYpzyrXWM+Eg2B5oTroSXbjy0t5tfi9Fn/fbfAWvLmpleJBfLFVA4uMVCN5Igue0w OG4BouwDzvuHsDlR3sHPvMuCWDFC3eAMOTKsLBXwHFdexTdFi1Wr0Ikh9wOGybzRP55W n/j/BxBwKyDYwQbEDpWrfIwoznhvsvkQ7U+gC5mWWiOwoWgCiYAPPmE6uWFuTZIKD8fj 02JQ== X-Gm-Message-State: AC+VfDxiJpdRnVGHWOaa8YEx7VkRdC6UoddICBQsswdwu97ZtEVICjwx gbKNskD+jJfBtlGioTYlcH8uYAMGokgdVApH7VwEOQ== X-Google-Smtp-Source: ACHHUZ6rnfauvJlvb1mwzzlT8g0GY54+NROCZwvEmL9WYPQejz5W4eVK9gMe7CWqWbMSgLrgOf+zP9SLEfzjAsntQys= X-Received: by 2002:ac8:7d11:0:b0:3e6:81be:93b3 with SMTP id g17-20020ac87d11000000b003e681be93b3mr25392qtb.5.1683745213654; Wed, 10 May 2023 12:00:13 -0700 (PDT) MIME-Version: 1.0 References: <20230508020801.10702-1-cathy.zhang@intel.com> <20230508020801.10702-2-cathy.zhang@intel.com> <3887b08ac0e55e27a24d2f66afcfff1961ed9b13.camel@redhat.com> In-Reply-To: From: Shakeel Butt Date: Wed, 10 May 2023 12:00:02 -0700 Message-ID: Subject: Re: [PATCH net-next 1/2] net: Keep sk->sk_forward_alloc as a proper size To: "Zhang, Cathy" Cc: Eric Dumazet , Linux MM , Cgroups , Paolo Abeni , "davem@davemloft.net" , "kuba@kernel.org" , "Brandeburg, Jesse" , "Srinivas, Suresh" , "Chen, Tim C" , "You, Lizhen" , "eric.dumazet@gmail.com" , "netdev@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: qj5zw7oxa834rjbhxzxsd5qkrkhznugn X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 66417140034 X-HE-Tag: 1683745214-851490 X-HE-Meta: U2FsdGVkX1/R0kSd6At8Rr6QenO0kn3C/3IR9jA0hHIvLlZ8B7/SNIWgIgwP4eVNHCqgu//HRIfBso1Pq11m3M1FR0da9rSSaSBvTlBJAPy6P1AFHrFwKX/8qItpDKAkmqO7R0g4J6fyxUHfwYc1txBoFL70/PP7tIrw4YJZPHU32vEQuY4yWpOKskVSjsIfXtw3A9lXIoOAOcZiTivZsTBPSGX9DSq/lUcu4JyFPkOBveI6E9K4+QOMy4ONt+WcjkVYcEmCvBKIwruLQo3dj2zBfjZSaZg+npXzqScBBOy+ndtpym0bFeBrm1mqFRu/MgnzasZG+GuQxYDC/T5ht3gohw91hIZ0RTvI7ES7EsZ9hv67+KVqvGpal9oJiSEN2j844xzZG2KLKu2BmuFE+1qwUbWQclEEc7un3lboCsLDG2aEBEjvJuaixUm/T/zxKG4ZnvKeJpnr9X210B6VqkDNNq9VLXaeDz7YnPXETdVhZhD2/PvfaPUZD/HbN7EIrj15BP07v1y7t5YwiXQrr6lYY7reo2Du2XFu8pfKO27HCCPH2DNVm03AdwMeRZctClcZwUhOrFinjachhJEzNRYU8d8fNxr0U5c6STx16p2OvP9/W9b6NoXGbgmliUE+8J1nZXVVrCli34E3bSgLWxJv7FGLkZEPUYdJiXoUG4Ll0EQ5WtNIE7+taEO7XpT2q1ZxGEcLNfEyemuRPr/Ylv3blLzDpqRwctaNbm2Gwdj87p9d7f066dLDF8WRiJdMM8NIh9HhwfXuY5OhIT4VBwwfq6sreF06dyzzr7cXpOMG58f94a3CSsHrdD8BH4HwGCaaXCyvvrNkhLa7/NsMQ8mpNmVHZYpmWajstccK16WucSPu9Xss61UMvd9l6Ftz/HlD8saL3VZZkDpxfSUZNUQdljTRn+/3Gs4GLqc63Qn8i/r4F8EkzyGPdBoPoDnlAKY8f3avxhH/NSbqyFO gT7QsL+2 qlwa8ZbbRhAfb9n7D2cb3fIxm+YHh/dOKxu+r2SeD4oXuQX1xH9VSi8NtgGCbaEXGpe9DeRFDnHWz6TdsUW1Vff/8K+ickg8RYyCcHTnKg4D9KgnOvcBSoOeUcy2BQ8nXc6KC6aew+0X7a569P58dr4llucZRAnF4p5kshGxMKO89uqSDo0NZhwxnZk21H0EABng690A/BI8CwGqSdC95Q6rMICNrxX1kcYyWFbQbEFdKYg6BJT2tOeWTbdEQeupkVn8bA41NYHLtxb/PbNvW65uSTKbb27jSGu7l0KPq+oN9rU3L0gMP39xXYzadjobBW7eYb73Of4pclOOc2v67IngQHueLe9jJ5NJIpGDihBw2NJiCl1sBQrcK14WbarVtKHQ7vTdPeco1sWsABdkedeqHDA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, May 10, 2023 at 9:09=E2=80=AFAM Zhang, Cathy wrote: > > [...] > > > > > > > > Have you tried to increase batch sizes ? > > > > > > I jus picked up 256 and 1024 for a try, but no help, the overhead sti= ll exists. > > > > This makes no sense at all. > > Eric, > > I added a pr_info in try_charge_memcg() to print nr_pages if > nr_pages >=3D MEMCG_CHARGE_BATCH, except it prints 64 during the initiali= zation > of instances, there is no other output during the running. That means nr_= pages is not > over 64, I guess that might be the reason why to increase MEMCG_CHARGE_BA= TCH > doesn't affect this case. > I am assuming you increased MEMCG_CHARGE_BATCH to 256 and 1024 but that did not help. To me that just means there is a different bottleneck in the memcg charging codepath. Can you please share the perf profile? Please note that memcg charging does a lot of other things as well like updating memcg stats and checking (and enforcing) memory.high even if you have not set memory.high.