From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ACE9C388F7 for ; Tue, 10 Nov 2020 19:01:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5839820780 for ; Tue, 10 Nov 2020 19:01:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="YutSGkcI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5839820780 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id BCC616B0036; Tue, 10 Nov 2020 14:01:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BA1E06B005C; Tue, 10 Nov 2020 14:01:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A91016B005D; Tue, 10 Nov 2020 14:01:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0230.hostedemail.com [216.40.44.230]) by kanga.kvack.org (Postfix) with ESMTP id 7A6196B0036 for ; Tue, 10 Nov 2020 14:01:21 -0500 (EST) Received: from smtpin12.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 161A9180AD822 for ; Tue, 10 Nov 2020 19:01:21 +0000 (UTC) X-FDA: 77469426762.12.laugh88_26174d8272f7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin12.hostedemail.com (Postfix) with ESMTP id 5E73F18014B77 for ; Tue, 10 Nov 2020 19:01:16 +0000 (UTC) X-HE-Tag: laugh88_26174d8272f7 X-Filterd-Recvd-Size: 3311 Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Tue, 10 Nov 2020 19:01:15 +0000 (UTC) Received: by mail-lf1-f66.google.com with SMTP id v144so19046864lfa.13 for ; Tue, 10 Nov 2020 11:01:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zKnP0UjT9/41FW96welsKE4nmHYtePDjICGtIuKNYDE=; b=YutSGkcINLiH87RXw6H6GyKh691g0QzbgNl7CF4HK08iAClCp9ea/n89O0RSe2aNmb Ur9I2aaz3qjCQ1CVxCZrwzro/3uPHPE6hLU5TegLPUTE8LAEjX+1RA2mh0uC0hjT0Kdk fTH/PUwuj5ZMwRxfryXySmYoQNPa9wkVclmN7xSW8RrTkWvPkVVkKpuA9LINs0tIxKSt JKlFHkT2+IU19ecYwZqiIwautQRIPzJSwOuf75WjGxwS1MyrSoJ6T0PZBnWP5SVdxgNF IIJBz79fOk2GKvBzFDx4hlJhjrYkiGpocwnWXRpSEUgRPfbXcDJU/dNbK2CVKDm296Wa SjlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zKnP0UjT9/41FW96welsKE4nmHYtePDjICGtIuKNYDE=; b=B/1Ny23W+lg8mpiOCqlUEUgPyIG3YskfOAPWNZpc6yDqY6JE4Af9kFSGRQ0l76erpE +4pckmsV1kUE8MhFCqCuKsPFRg5Xpa+KVKBS82ewD5tKrAeAP1ljEFRNhQkZyuktmXPm rcYLBrfXm9dcAbE3bDT7Evs9xovPFa9IhkgUkLDV9Qj8vka3bS5qOL1uDnMJKIQeNG6E k6I82re5zFklmo3aseYIiJf1eIvBh3gTQKEsa8ZEfl+IDq/lJScBcshOb+sXlJviOmkF f5K02vD75dddFYKwcfANZQr9di9jDgun/1aUqFAN1VfDbGY87iQVeEHgwKD0uv8zJKHq NxSg== X-Gm-Message-State: AOAM532e3DaMkxXfk7e4t0+5qvyb1Q3zPr7sSItlQ73TAJFqFJYHQleM DiIvVmvFlQcMiCw9mA9NNLG7VD0Juz07Lbk/5yqYug== X-Google-Smtp-Source: ABdhPJyODxBXTvRgxgz8DW1RA9365vP/o33VJ8YR44Ees8mNhL+3QyMtohiO6gQ6QFgjuCrW3qonmeZ6hyDThXC14rY= X-Received: by 2002:a19:85c2:: with SMTP id h185mr8571397lfd.494.1605034874125; Tue, 10 Nov 2020 11:01:14 -0800 (PST) MIME-Version: 1.0 References: <20201110184615.311974-1-guro@fb.com> In-Reply-To: <20201110184615.311974-1-guro@fb.com> From: Shakeel Butt Date: Tue, 10 Nov 2020 11:01:02 -0800 Message-ID: Subject: Re: [PATCH] mm: memcg: fix obsolete code comments To: Roman Gushchin Cc: Andrew Morton , Linux MM , Johannes Weiner , Michal Hocko , LKML , Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.001876, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 10, 2020 at 10:46 AM Roman Gushchin wrote: > > This patch fixes/removes some obsolete comments in the code related > to the kernel memory accounting: > - kmem_cache->memcg_params.memcg_caches has been removed > by commit 9855609bde03 ("mm: memcg/slab: use a single set of > kmem_caches for all accounted allocations") > - memcg->kmemcg_id is not used as a gate for kmem accounting since > commit 0b8f73e10428 ("mm: memcontrol: clean up alloc, online, > offline, free functions") > > Signed-off-by: Roman Gushchin Reviewed-by: Shakeel Butt