From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AE62C433DB for ; Wed, 10 Mar 2021 21:08:40 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D0D5C64FC8 for ; Wed, 10 Mar 2021 21:08:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0D5C64FC8 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E54808D020E; Wed, 10 Mar 2021 16:08:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E2BE08D01ED; Wed, 10 Mar 2021 16:08:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CF3AC8D020E; Wed, 10 Mar 2021 16:08:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id B617C8D01ED for ; Wed, 10 Mar 2021 16:08:38 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 6FA1C180ACEEB for ; Wed, 10 Mar 2021 21:08:38 +0000 (UTC) X-FDA: 77905203516.03.0F4230C Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf26.hostedemail.com (Postfix) with ESMTP id 7EA2B407F8F7 for ; Wed, 10 Mar 2021 21:08:35 +0000 (UTC) Received: by mail-lj1-f177.google.com with SMTP id t9so27472538ljt.8 for ; Wed, 10 Mar 2021 13:08:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cACQQWqG6uSUB0AGVgSEUJ4B4wJ68O5aodDpa+9zBtE=; b=TD528uq6ivKl36WWTHHJw/09uqZOROwIWdNmdS7C/SQIUBmkTfKhrO3WhbTLpi33Yd vuzVI3zn01/vbNvVSS7s3JCGNhdSLUnX4pS92ZzArfy2HjSDolAGYai4Jowj8xedrtfs eitt16XYmZB2QuyFScmS+Csnw4EKgfOJHbj1r3zXYVHmlKWe1KBfJuluPCM6x6k7jZeq lgJmr+miho41dvdhpIhRa74hCa1QCr43YSd3z2Y3mnLiQwIidUERKBWZ+yb/ADP6nUrs wAcohDBJp8TJG4bfM3LEzMEhLB6H+lFG2/I4WxbkON4RTUt5666MAekU7kQdmpUNO6Yp nhyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cACQQWqG6uSUB0AGVgSEUJ4B4wJ68O5aodDpa+9zBtE=; b=IWKcZelVcQbI077rRi87EtzeVStZIto917Wnqb9rAM8CR1R+MPb1ioiCrLUA5f4xcE ot8bbUdlkMVLAjLA9dTRa9LUNoXwg1srWveklhu8hJnXYFGtKGuwfYFaPHvuyQTQY9sW H/TJrc0jzgtSO3Dpdie/Lcchkm8zBQtrudXmjIk6VzD/5lLleTz55a/eTx6ZJG1nQXiV rViQZSRHQiXzv/pAnct+AtFGPgJFBEVPpnbfH8OSP2rfnIIPN3rJ4HC6YF5SoXvtG4fZ yzXU4nYaqRJldP2LVZLycU77IciQEHBtYNUoFqdJQD5fcdV/Gp4nAKBZAiHFHUEr8S7N FrAA== X-Gm-Message-State: AOAM5317/44QUL1H4U13P7WBf+6huADfigF8G0rAVJPHXey+wIvd6qMs SjrUhcCVWI77uYSdCzgVGGoNgN17DMxzrHPG/K2Lug== X-Google-Smtp-Source: ABdhPJziZrjBJ9Z8nbqy4riATwMtJzR2H3vO3xCUy6/+X/e3KusmZB2RF4BFcfabm3GgOq/lDz2ZuH4ze1WXtxxMN9U= X-Received: by 2002:a2e:8984:: with SMTP id c4mr2796500lji.456.1615410516228; Wed, 10 Mar 2021 13:08:36 -0800 (PST) MIME-Version: 1.0 References: <20210310174603.5093-1-shy828301@gmail.com> <20210310174603.5093-14-shy828301@gmail.com> In-Reply-To: From: Shakeel Butt Date: Wed, 10 Mar 2021 13:08:24 -0800 Message-ID: Subject: Re: [v9 PATCH 13/13] mm: vmscan: shrink deferred objects proportional to priority To: Yang Shi Cc: Roman Gushchin , Kirill Tkhai , Vlastimil Babka , Dave Chinner , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , linux-fsdevel , LKML Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 6akcnkgpzwu6ebjgrktorp1z4oza4soa X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 7EA2B407F8F7 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf26; identity=mailfrom; envelope-from=""; helo=mail-lj1-f177.google.com; client-ip=209.85.208.177 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615410515-9011 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 10, 2021 at 10:54 AM Yang Shi wrote: > > On Wed, Mar 10, 2021 at 10:24 AM Shakeel Butt wrote: > > > > On Wed, Mar 10, 2021 at 9:46 AM Yang Shi wrote: > > > > > > The number of deferred objects might get windup to an absurd number, and it > > > results in clamp of slab objects. It is undesirable for sustaining workingset. > > > > > > So shrink deferred objects proportional to priority and cap nr_deferred to twice > > > of cache items. > > > > > > The idea is borrowed from Dave Chinner's patch: > > > https://lore.kernel.org/linux-xfs/20191031234618.15403-13-david@fromorbit.com/ > > > > > > Tested with kernel build and vfs metadata heavy workload in our production > > > environment, no regression is spotted so far. > > > > Did you run both of these workloads in the same cgroup or separate cgroups? > > Both are covered. > Have you tried just this patch i.e. without the first 12 patches?