From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F579C433E0 for ; Tue, 23 Feb 2021 15:22:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9219C64E4D for ; Tue, 23 Feb 2021 15:22:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9219C64E4D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 1A45B6B0006; Tue, 23 Feb 2021 10:22:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1558A6B006E; Tue, 23 Feb 2021 10:22:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06BA46B0070; Tue, 23 Feb 2021 10:22:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0041.hostedemail.com [216.40.44.41]) by kanga.kvack.org (Postfix) with ESMTP id E66AD6B0006 for ; Tue, 23 Feb 2021 10:22:14 -0500 (EST) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B406A8248047 for ; Tue, 23 Feb 2021 15:22:14 +0000 (UTC) X-FDA: 77849898588.05.DA546EE Received: from mail-lj1-f171.google.com (mail-lj1-f171.google.com [209.85.208.171]) by imf23.hostedemail.com (Postfix) with ESMTP id 9104DA0002CF for ; Tue, 23 Feb 2021 15:22:10 +0000 (UTC) Received: by mail-lj1-f171.google.com with SMTP id a17so63503357ljq.2 for ; Tue, 23 Feb 2021 07:22:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XGL+ZEl1VxWchCvh5LCCnMOsswk/yP/QAWF1B7tp0PE=; b=Wy4BbxDEhgR4O7gMewi35UNKdoIq+5jPJHkEkUPI4l+zHkf/xvB3AtgtOh0iXos53O Zk5wGQPK48Zhpdf64dMiDAILYpmCATxqBwyi0OlNqSYSwz+hK+/9WNhp8lMNLJqBX99c wK4rGFVCouTcrfF/JOUpofuiPJ8fF49tqSkBBrTFMUmEw9nAgfPYyBuuln6d8YW5I8Vc keqpKNlB6pCw7G2BICq8n+GOkqOstBrhwKcOBIXQybErStqxgPXeiIgiNLY1VeybMdgO kzt0LAl78laUJAX1afg+UQPm4iS7baqN1P55qK5me5WGklMBebxv6wW+nN/50r8akgA1 a/dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XGL+ZEl1VxWchCvh5LCCnMOsswk/yP/QAWF1B7tp0PE=; b=C2bbsdAf/QGG/9Z/VqlRk9D9NnoSIP/dFgay1P+dnMvZPAeiTufxAM91BpkXd2E7B+ 9GqbjK4czPDb9NW9m1J6SCyM9rPG3yo4mAZdutZtSzl8tXX5k4tXJBNpv1aUb1jmz/1C XJp2PZINIUG1CGaJnpz3Dpq3IlXvcZBBu+Ed05uwjzDXROLeE+XDaidSWZAeRPS1wCD4 VOfwWADgOjK6EF6gOLe+7zpIJMIt2OIKwRcIPMmSTNL1dSEjvJihEbo6hBRwq01jUH3N p60oOHtWocS6nOHrah1Z9p5MOibFJCBb0MRkpe7inrp8SgVNvNZN+Rx299Da9vWFuvds ir5A== X-Gm-Message-State: AOAM532JogsNQDlnS0v5iYCrJEQDLO+p0LoVgxm0HwwQOCs4quZ7vh/W oVHZpL7VmVlrUNJurBXU/SD7DosdBMcIy3PX4CQcRQ== X-Google-Smtp-Source: ABdhPJwIlmw07SdzqXAyuw6LI5ynN6o9c4dTEnBt/ZtckCdCovwV8lO7Org5W5KV9NSnIS4DjO6/q9OP4G3TRBtQBhw= X-Received: by 2002:a2e:b4e8:: with SMTP id s8mr17816849ljm.34.1614093728978; Tue, 23 Feb 2021 07:22:08 -0800 (PST) MIME-Version: 1.0 References: <20210223092423.42420-1-songmuchun@bytedance.com> In-Reply-To: <20210223092423.42420-1-songmuchun@bytedance.com> From: Shakeel Butt Date: Tue, 23 Feb 2021 07:21:58 -0800 Message-ID: Subject: Re: [PATCH] mm: memcontrol: fix slub memory accounting To: Muchun Song Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Roman Gushchin , Cgroups , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 9104DA0002CF X-Stat-Signature: k47ccdsd31k4s71f48qpayz3ya7icatf Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf23; identity=mailfrom; envelope-from=""; helo=mail-lj1-f171.google.com; client-ip=209.85.208.171 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614093730-163083 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 23, 2021 at 1:25 AM Muchun Song wrote: > > SLUB currently account kmalloc() and kmalloc_node() allocations larger > than order-1 page per-node. But it forget to update the per-memcg > vmstats. So it can lead to inaccurate statistics of "slab_unreclaimable" > which is from memory.stat. Fix it by using mod_lruvec_page_state instead > of mod_node_page_state. > > Fixes: 6a486c0ad4dc ("mm, sl[ou]b: improve memory accounting") > Signed-off-by: Muchun Song Reviewed-by: Shakeel Butt