From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86F41C07E99 for ; Fri, 9 Jul 2021 16:05:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0B963613B7 for ; Fri, 9 Jul 2021 16:05:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B963613B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id ED7616B0074; Fri, 9 Jul 2021 12:05:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EAE9F6B0078; Fri, 9 Jul 2021 12:05:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D4F9D6B007B; Fri, 9 Jul 2021 12:05:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0129.hostedemail.com [216.40.44.129]) by kanga.kvack.org (Postfix) with ESMTP id AC5F36B0074 for ; Fri, 9 Jul 2021 12:05:38 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id EBB6680E1C6F for ; Fri, 9 Jul 2021 16:05:37 +0000 (UTC) X-FDA: 78343524714.21.A6D1CFC Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf29.hostedemail.com (Postfix) with ESMTP id A4FC290001BC for ; Fri, 9 Jul 2021 16:05:37 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id f30so24241364lfj.1 for ; Fri, 09 Jul 2021 09:05:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=m82zfd87YF9+QrBUW0hwMZ+ldgr97m1MRGrpxVJ55ig=; b=H5fHo8SPL71odXGzixPW0kCw6NiwaVT7YekDy7mWtP12kM6qvdkO0rJHFh9Xzg2X+o wqTB190SjORxzPvu03czb/qvq+FR044vOHsTqZaX9FiFyaVTMSgBNPOGSlA/y8rfObys R2HYTiOrK6UO9LVmWTkQfjUfWoO1MkA6NPH008Z7zZDst5wFZSzGua/8Mq+vra8Qe8aC J1MhWoTcHKGt0IkMmUS5wZ2Zs1p4NKQ3ngltBMY/xQQGjSqKyl9zhI7nVPOU/KxpJc85 ciTN8Du8hEzPC5pmqUNYCC7T1IRgQfuSN6D3zEhMzil1V4u5QvmSQo8UAoz7K+wKl4jg d02w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=m82zfd87YF9+QrBUW0hwMZ+ldgr97m1MRGrpxVJ55ig=; b=j9X3CD03W4CV2dlIn0Fgu2cbvKqKm41PfQa2EJUQF9RMVn/hsbjpc1YlA6RlZchE0A Yiz+typdp3l4X3Q99PsUn6XMDuIpz9bRvLReBpfU91/QEJMX8osfvSDQytTZUwDkx/ke 0G6MKNfP/YUfF0ANs+SHdT8KOLpYAzJTKKCUfuRnEBAIHLtHCrdFSQM006nhwuHvKClz WlCxeH+5psHgvAb51e+oonC0rBYk+0zmegp6oPQKJi+z23vMrG6tK2k/JxEq322kkNsX cJaLnTPYQ8K+avg3CgMNxd+toQw+72qIBpmlYfXRS6dKW2bVTKG16g6V7QToGGLk4BeH vM5w== X-Gm-Message-State: AOAM531zhVLGZqk6xrn+M8vO8IjMdDWRsGaucq9hfK+fTaOWxOxy1CbV 67AB9FI+TnUrIziipT3YMrX8WXzl75aoIndXDFz71A== X-Google-Smtp-Source: ABdhPJxnyX6S5tO2WlFgPLsi+dNAp9f8ZYhuS54Td/FdvGB8rNsN/P9JGyEFXWL5ODPoy7CSxjdg935moUJOQKUs1+Q= X-Received: by 2002:a19:7418:: with SMTP id v24mr29655054lfe.117.1625846735856; Fri, 09 Jul 2021 09:05:35 -0700 (PDT) MIME-Version: 1.0 References: <20210709000509.2618345-1-surenb@google.com> <20210709000509.2618345-4-surenb@google.com> In-Reply-To: <20210709000509.2618345-4-surenb@google.com> From: Shakeel Butt Date: Fri, 9 Jul 2021 09:05:24 -0700 Message-ID: Subject: Re: [PATCH 3/3] mm, memcg: inline swap-related functions to improve disabled memcg config To: Suren Baghdasaryan Cc: Tejun Heo , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Roman Gushchin , Muchun Song , Yang Shi , alexs@kernel.org, Alexander Duyck , Wei Yang , Vlastimil Babka , Jens Axboe , Joonsoo Kim , David Hildenbrand , Matthew Wilcox , Alistair Popple , Minchan Kim , Miaohe Lin , LKML , Cgroups , Linux MM , kernel-team Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=H5fHo8SP; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: A4FC290001BC X-Stat-Signature: zr3tkk865wb3opanut7ugukkznpx4nt9 X-HE-Tag: 1625846737-710898 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jul 8, 2021 at 5:05 PM Suren Baghdasaryan wrote: > > Inline mem_cgroup_try_charge_swap, mem_cgroup_uncharge_swap and > cgroup_throttle_swaprate functions to perform mem_cgroup_disabled static > key check inline before calling the main body of the function. This > minimizes the memcg overhead in the pagefault and exit_mmap paths when > memcgs are disabled using cgroup_disable=memory command-line option. > This change results in ~1% overhead reduction when running PFT test > comparing {CONFIG_MEMCG=n} against {CONFIG_MEMCG=y, cgroup_disable=memory} > configuration on an 8-core ARM64 Android device. > > Signed-off-by: Suren Baghdasaryan Reviewed-by: Shakeel Butt