From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D234CC76196 for ; Tue, 28 Mar 2023 15:20:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 648386B0071; Tue, 28 Mar 2023 11:20:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5F8AA6B0074; Tue, 28 Mar 2023 11:20:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C0CB6B0075; Tue, 28 Mar 2023 11:20:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 3AE356B0071 for ; Tue, 28 Mar 2023 11:20:29 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id ED925160A42 for ; Tue, 28 Mar 2023 15:20:28 +0000 (UTC) X-FDA: 80618668536.10.4A022B7 Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by imf20.hostedemail.com (Postfix) with ESMTP id 0BAF11C0021 for ; Tue, 28 Mar 2023 15:20:26 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=c8ynwXPs; spf=pass (imf20.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680016827; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ONZYLiGDk21RMFgMpaXH7s4UWxHkNsJ+wUGHRFEkuCc=; b=AZQ2MImcN541QUWmdPR7cchWfIS+mFjDT5snpFQC105A1zfQLieF5PV2O2rXmHwUyhulUs eDZf1JR0MBJaSzmByAaQ047ZVro1BdfpPpPFoaSz0dmbFGv0PvuLjJYzKpQoOAxjvGHrN9 uxIuBkdU5b/0ZLwZ6TqROnO2TXD6zZc= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=c8ynwXPs; spf=pass (imf20.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680016827; a=rsa-sha256; cv=none; b=m9zdhzQv106jdNlBZk3Zm9wUliwFATx6XLSgPN1rZOrMu1XD0YaAsMA9sMpJuoqBmHJ1Bp allrjC1LhaPPEwgdVD8Rb5PwQqJkYure8JDxF5R1n+KqRd04YTqo0f9aVFYHFk9cuBSXXg DhccY5esb5/Bhc9XA0gbFbPDqk9XEDA= Received: by mail-yb1-f180.google.com with SMTP id y5so15538883ybu.3 for ; Tue, 28 Mar 2023 08:20:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680016826; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ONZYLiGDk21RMFgMpaXH7s4UWxHkNsJ+wUGHRFEkuCc=; b=c8ynwXPsqcK1BZ6E1vrYfDJcqWTKC225pVcmZQQIcGa+4WzKkC/FwoXCPTIZP0uqNW jalQxGai5+TUgtreV4lGVmixYr6hAEF97bJP6udFm1yicUDr3KPFXDmLE2aJHchJhqAj 7J4XebvBwK691HXXFYm5J21xAY8msOd5k/OOZSjNYpGC2QnLfu+09Jc4Pbhux+Hpz5l/ 35fyjYPGGFQ/WwDLWWO9LuBpYSShrGA9j+zLmlaXc44UkvAaGsRQX8zqrH4aOojgeFnH DBkes4tXkEWXNeFd/n9ARofjF5njrlz0PZjoz9j8BGF67LqPGhfa7EH16H69NZfFsNx5 Xcaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680016826; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ONZYLiGDk21RMFgMpaXH7s4UWxHkNsJ+wUGHRFEkuCc=; b=omlbj6brsgC/qShk8UIn3o9Q4q+z4LROjGcGLRY4og6KtnN+YRSaBL5vEj2sfwMLFf 9xm7QhfpKOLgKEQchXsJAxn0ztFSRxRcAa9fJe+5rR98E8DagE02g8HBR0A2Rb6yTdx5 pRvlPEW7Xqr+d1YBLEZk+HdWQqpfttbNfOQL5FUB+oShyCDpEJAEJmbP4I7ghG+GOQrz Zf8+Hf5hi6DdvFlWazivWKJUWx3fspwQF53mkOTq3mWtzd5jnjpDZsdPgyVm1YohLlaD dQ5AeyAjyT905L4ZiB3HKRy2PUCEG4jKy3qVu03AgLuTAqS9QnF1faUTMCF8YuMoB6SA erZA== X-Gm-Message-State: AAQBX9fxxQ9lYE2w69Ba6H0Y2pmX1BjoT2E+2kDma5TaCzWnIHWnbWjk mNu+70UL69fZ0hAM8KUkqYyfkA6fz4I3k/5+aqb4ow== X-Google-Smtp-Source: AKy350Z1lvsH1c3O1jHKo+DM2HBpLRhmt4Hwp7gRiZRJb5+27sNfylAL7/FK3qaRf4mMZ9UmJB/3uw0wBUSKxNqtrno= X-Received: by 2002:a05:6902:154e:b0:b77:d2db:5f8f with SMTP id r14-20020a056902154e00b00b77d2db5f8fmr9838517ybu.12.1680016826025; Tue, 28 Mar 2023 08:20:26 -0700 (PDT) MIME-Version: 1.0 References: <20230328061638.203420-1-yosryahmed@google.com> <20230328061638.203420-10-yosryahmed@google.com> In-Reply-To: <20230328061638.203420-10-yosryahmed@google.com> From: Shakeel Butt Date: Tue, 28 Mar 2023 08:20:15 -0700 Message-ID: Subject: Re: [PATCH v1 9/9] memcg: do not modify rstat tree for zero updates To: Yosry Ahmed Cc: Tejun Heo , Josef Bacik , Jens Axboe , Zefan Li , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Andrew Morton , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Vasily Averin , cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: ofpqp7fnq3wtbio4y767dqpuhz46bz1r X-Rspam-User: X-Rspamd-Queue-Id: 0BAF11C0021 X-Rspamd-Server: rspam06 X-HE-Tag: 1680016826-781300 X-HE-Meta: U2FsdGVkX18OLGOCQn29B2okrU8UC8f2Jk0JGxja21aI2KX9W01M3Fm9vDBUPS0eh/20TaNXAzCPptudrWJB66nvYJAr5vyJ6yg5UwHRCyYZfldDMvjeZpOZH2kEIra2XqX0M2TAYkLIlb7du7/kp3cUqbkOVqY1ykYdv2k8b8aH+K3lIpLH3t/SFrA6CPeDrTqIUKpfTJTRAf0iH9znxmb2nx9LiKlDn21t89IvpSrv69uAqNQcbrcA7d3D72LLb+G2Ev3GAtJ8nhC1I1seEjDjsUGjDPKEJcwRSyK0yZImez5aHrDWDOsoaorif41Eokt4GFTVbhp7E+YjSSzgg/MBOWi1abLw00qaxXrHXehFSCLNFaa7l0H1hLHQeMQ76snpUZYLBIrS6Ebjl+aSdnuHx2u1pcBD3atL/rMVQLC14JwODQXPN08gjHwoq2mFjWGj4KyfCT/wpPXveI2Pcf82J8WnfdPcYpR8heGJRBMpjuxoBqIv/ISDHe3vmsEWLTMMGcWQRnteBcgnUhaUUJ6UtHLkXww/aBMQtEQNMEiegFk4n+Pm8WAj/tlTyDfWHj3fLKmKftVpbsyi8BsrdaMOl3uKhYDTryYKRjqn1E5OXvxm02tJSX+58QnMuTqbZ525r8IOVrJPY43s2D5SQhsjjUYvAuoqWqAJEnTrEqGPG17MQCXWccWC1CcKwCoXrOemowcMY1UgGxNlaEeZssz+iY6MXqNVLsHb1yiAT3mOMGlNTYMlL721EyXA+5yR9a6WA5b8hOBSFSmRehgl2uO8KDeyuL8dvTfzNLdBRd9B6hEpsXg29Ud9oyEj+3v2nPxp9BPhPgxWKjPVaS3WrMFNLz7XOUCMX95z+fMeJlGFLZDTNLY8ILxj9ez+5kqcI2YVlOPBnC9uy+hLWoUOsEwrI4aqCbDuEry/J18y3Pk0V2whH9j7EqbzXxr89Tb5lP32ZuAS5sa8DXSqIrr ybqUAs5x N3ux3vpnnXCakQ+Gdtb+eUNt4LPbrNu5RCj86kwDYDs0tSQcg08D4qa99fxDbDjVJ+Xs6K8KtLYFD46vIpxzn35zsRZ85UKzMNxPl+ERN6jtW2+MG+adT46d9nWux2JLll0li0xIXJdjNu05CE1JLI3DEAaF0l79U84rwo2xl6PAo/XtbyRn9OmvQ9BAxHAvQBbDX7+SzmzqbqbNtgN6pfyRee7UyhkqeDnm/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 27, 2023 at 11:17=E2=80=AFPM Yosry Ahmed wrote: > > In some situations, we may end up calling memcg_rstat_updated() with a > value of 0, which means the stat was not actually updated. An example is > if we fail to reclaim any pages in shrink_folio_list(). > > Do not add the cgroup to the rstat updated tree in this case, to avoid > unnecessarily flushing it. > > Signed-off-by: Yosry Ahmed Acked-by: Shakeel Butt