From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8235C64E7B for ; Wed, 2 Dec 2020 23:24:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4CB062222E for ; Wed, 2 Dec 2020 23:24:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4CB062222E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6D1C16B005C; Wed, 2 Dec 2020 18:24:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 65D726B005D; Wed, 2 Dec 2020 18:24:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4ACA76B0068; Wed, 2 Dec 2020 18:24:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id 322676B005C for ; Wed, 2 Dec 2020 18:24:12 -0500 (EST) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C0864181AEF0B for ; Wed, 2 Dec 2020 23:24:11 +0000 (UTC) X-FDA: 77549922702.21.pump24_5413278273b7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 8A9D2180442C2 for ; Wed, 2 Dec 2020 23:24:11 +0000 (UTC) X-HE-Tag: pump24_5413278273b7 X-Filterd-Recvd-Size: 4849 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Wed, 2 Dec 2020 23:24:10 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id d8so5367lfa.1 for ; Wed, 02 Dec 2020 15:24:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=krM5ZtArJDh4CBdMqAGvzuDAxuZaaWPVN3dbTakwoQA=; b=rW70B6hJvfsQzem9DjSh5wXLcOFYSU1woEDzJDe+sxe/DK7kyOs4BekSpMmQdoqloC jII3L3g/91M0Il5/MoHlo5S1zYd1n0wjyH20YW2AQgoZERWxzDAIUjM2zu0cUwwT+a1w viw4Aq0NPxeNj4A/P0AQ6mKnU59maVXiyq/Tg8WiOnxWpJ6h2GxjUkv53DcRPMqy40au KVuTreXa3FHXocfjD9aI2HkDh7bkptBrrD/MQaKzGjktMHr3/gdoRjhw8eVZdfKB5lR0 6R8Hy2YixzwGYH9GIRFDetJa8BTgN0xLRWFJWkdRp7tUhR7hxOYqcDCmSAm3MlvYmM/P nPbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=krM5ZtArJDh4CBdMqAGvzuDAxuZaaWPVN3dbTakwoQA=; b=EzPE/ifjI8CMw/Mlde4YY2v/o+YE3av7d4YXmj+eTiYYz/sUthgDttYKQc32btfc6Y nq4T9kI0TNwoWEhN9aDqXQvuYgCbzlkaXfoWsnmk7aUyLZfTwSzrBIb5PKIsDwzp2Jx6 QV3DX4iNVLW5ZqRL8teUR0oRn7FUQ9VpNreIrsBT5Tz9jbSFS1b2p1Xh1kcJKMIMPMDw 7H7KA7D7XSwVmYQLwq2lgc70CK7GUxkdlbbbhUctNZtU65oyCQFOPGh6GY+HkGGQsFKu GoBxDFHgZ+KuL7udGWzTnc9rfO0RM5evSrcIxk4DlwjaofvAm0C098eXOeubidPvGFCP F3wQ== X-Gm-Message-State: AOAM533hamfEB6rm6PHlKr0YZh339MWzqS3cUOsWxaOuetlrihj1AEqE Yc5Qi/CYoMv/T3fMYUNQMnN3uQs44joRl6uMUyhtvw== X-Google-Smtp-Source: ABdhPJxEYAINYZmZJ8fCk9T3f9H7hIO21axcvhlNaEHyk4FC9gVxHTTZh/IgVa5ILT91KDY0+vhFH1bSsRswiwCQl3I= X-Received: by 2002:a19:be4a:: with SMTP id o71mr167981lff.494.1606951449214; Wed, 02 Dec 2020 15:24:09 -0800 (PST) MIME-Version: 1.0 References: <20201130233504.3725241-1-axelrasmussen@google.com> In-Reply-To: From: Shakeel Butt Date: Wed, 2 Dec 2020 15:23:57 -0800 Message-ID: Subject: Re: [PATCH] mm: mmap_lock: fix use-after-free race and css ref leak in tracepoints To: Tejun Heo Cc: Axel Rasmussen , Greg Thelen , Andrew Morton , Chinwen Chang , Daniel Jordan , David Rientjes , Davidlohr Bueso , Ingo Molnar , Jann Horn , Laurent Dufour , Michel Lespinasse , Stephen Rothwell , Steven Rostedt , Vlastimil Babka , Yafang Shao , "David S . Miller" , dsahern@kernel.org, Greg Kroah-Hartman , Jakub Kicinski , liuhangbin@gmail.com, LKML , Linux MM Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 2, 2020 at 11:01 AM Tejun Heo wrote: > > Hello, > > On Tue, Dec 01, 2020 at 12:53:46PM -0800, Shakeel Butt wrote: > > The writeback tracepoint in include/trace/events/writeback.h is > > already using the cgroup IDs. Actually it used to use cgroup_path but > > converted to cgroup_ino. > > > > Tejun, how do you use these tracepoints? > Thanks Tejun, I really appreciate the example you provided. I do have one query. > There've been some changes to cgroup ids recently and now cgroup id, ino and > its file_handle are all compatible. On 64bit ino machines, they're all the > same and won't be reused. On 32bit ino machines, the lower 32bit of full id > is used as ino. ino may be reused but not the full 64bit id. __kernfs_new_node() is using idr_alloc_cyclic() which will return 32bit ID. If I am understanding this correctly the full ID is generated similarly for 32bit and 64bit machines but for 64bit machines the whole ID is inode number while on 32bit machines the lower 32bits contains the inode number. Is that correct?