From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71903C47DAF for ; Mon, 22 Jan 2024 18:19:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A43666B0080; Mon, 22 Jan 2024 13:19:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CCA66B0089; Mon, 22 Jan 2024 13:19:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 846196B009A; Mon, 22 Jan 2024 13:19:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 72BCA6B0080 for ; Mon, 22 Jan 2024 13:19:25 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 40BD9A0A1F for ; Mon, 22 Jan 2024 18:19:25 +0000 (UTC) X-FDA: 81707759490.26.5605B57 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf15.hostedemail.com (Postfix) with ESMTP id 7A2D6A0004 for ; Mon, 22 Jan 2024 18:19:23 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3CxDeSsn; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705947563; a=rsa-sha256; cv=none; b=mGml9gn3Ehlnfkbg2FR5FLhYLrZwRBkye/oscu7+RQ8X4rcaJSTq77CP1jmhKVEf4uQKaZ yFRQN9gfl0B/a9N2aUTRBmczt8AYe9oQLFbfRNWGu/9xULl4YAqFf9ql3C+NM4lCA7ZuWO fgFc5wA1a4AC6jEcqaHX1wFw32/H+Nc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=3CxDeSsn; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=shakeelb@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705947563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p0Y9E+3pzP2s+EQdBjSE77FjET8jy9DFccLp3B3IzFI=; b=XclJ3jitoyuQCR3PAGOHBLv86S5OqnxvSsomIwmJpNI5/sDMVmGdU6iuGKnrMLtPnYYyxn pbmLZO0umGRljvRaEA+w6ROZ2MvwIzrtrVgv+pSmkVpb09toZQ/phQ1CATS6MwguDzTUgs l9YyWIiv7eFEJ8tQtcZnhGCzshwhUp4= Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1d72043fa06so5485ad.1 for ; Mon, 22 Jan 2024 10:19:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1705947562; x=1706552362; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=p0Y9E+3pzP2s+EQdBjSE77FjET8jy9DFccLp3B3IzFI=; b=3CxDeSsnOFtat8I9xJ1B0tS6SSLpNUINOTAaNr4aQwvDDLB1KApj4SJte2p7OPx2md weCG7mhDmnMPapxe5r24Rj/9OEsVUdoyuRgtpcdWeXie5WQt0EgJAa0EeAKGW593LsCS 0ohb4zSflGHDfgsNEi+q7iQHVIBxFxUbcuWfGc6lfsUJIc56372dxqmjU6gWRyGYrXL1 BxTYK7sEcoqEkPQhS8AHxJ4T86TILyhdOVatvJV5oJtThgAL2SNxa9xeaW5/kBpV89Xk sqcpggS7awpC1XLDvgFIth2XY0gPL0Z/v1R7f0oU1P1HKu7YUPIKEGEK7ZLo3A9gu8K0 VnrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705947562; x=1706552362; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=p0Y9E+3pzP2s+EQdBjSE77FjET8jy9DFccLp3B3IzFI=; b=VL5z1cQS+KQjSP8qkcI6Zk5cvu4cz0Ur5e6sDLstUUNdP4gwkjEzAoVoLqt2it4Wd3 Is8uXfedfbQBYdNXVdp95JW2ugVjA1Q/P8iZfGrCUEqEvfczOCAvs09yKlSf78173dwl Fyu4XOLmaXgrDUrpRxaVyyx1VwG5FW0+FKWiGwIG65mGd2wXOTtsf3e2WJIyoSIpz7G3 DzAXsAFQw4/Ne7yuH9+N1+hQ59vlakVuKFA0dD93nfZPTfl7Mj8+kTki4W4O/v6pp6Q0 CPEV4gPpNZ1OBdngW8KLbditz32OAAQ42C/cCHv7sXwjWd5wxzcB1/JIQ0PnJLGE4HnV pLbA== X-Gm-Message-State: AOJu0Yyl6Y5zoL/bfXD3XZVtrD3jEiul5wtukirA7cFIdz507wDRhMqm gHLmQbNLWGQs0NPc1mxSWeblHzWVVMu7X5jjHOru61qH3etZ X-Google-Smtp-Source: AGHT+IFeVSUQFJ2B79/oJNPkrOM8pRveuwd/OkPvv+mFDyuckhWdMgfmz1t4fln+zp+sRW8MxNoLyC5nZnyI1h1DfJY= X-Received: by 2002:a17:902:fb46:b0:1d6:fb94:10d5 with SMTP id lf6-20020a170902fb4600b001d6fb9410d5mr10331plb.27.1705947562078; Mon, 22 Jan 2024 10:19:22 -0800 (PST) MIME-Version: 1.0 References: <20240118184235.618164-1-shakeelb@google.com> In-Reply-To: From: Shakeel Butt Date: Mon, 22 Jan 2024 10:19:10 -0800 Message-ID: Subject: Re: [PATCH] mm: writeback: ratelimit stat flush from mem_cgroup_wb_stats To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Andrew Morton , Jens Axboe , Johannes Weiner , Tejun Heo , Jan Kara , Roman Gushchin , Michal Hocko , Muchun Song , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 7A2D6A0004 X-Stat-Signature: a46s5r5isq8azxkf6tgrhrthnxpimxqn X-HE-Tag: 1705947563-642505 X-HE-Meta: U2FsdGVkX198drTmhOTngSrXO243XQB+o0d6qe4iVP85pO1PSFo/6ORv+ngyiqBn5vP1AcRpTUwydaMtVoxjCneAfVBZQldfCtTR4y3T1ZAKjx83dHckyk/JvmtdFYAB+gXcUf+OdOEOjOdCTjFRU+vuRt1PdgM6hl/Txb06uG+Uy1YgWDgY+yrYNIuEf2jDJZfj6H/hDCBovxfk94+zGUeNqj0No7pzj9JGTqVknXiO3bn4CuCkAAH1f3liFyVcg6K7KPfqnvSz6/T+5pOLZBDichxWaWA0xvR5sXUk/TTZ4s/AbeBAJ8Xo3/RA4JAiBin+Mr1cb7DYphuDIG95WDsW2BETc0jzsECz82s5sUSDkRQ8cg1TYtHgZZQdiQ+BGOXA/8stYuu1A7eR9VNiJHrwvLGSTBSFBod7l/1p0yxML7g6SgLmkgsBm1iXDa1Flt9XucfaQufkWjrq5pjDXv5Vxb5dHOEwXMuOkeZTitc7ocBnJAbEXfcPvAVMmUyMhXoLpYtnvWdILBvNyJoZiBlXhY3lqwbC9W6rzx7KeH7ZgpfbIS3BZhSQbcuVzfHS42TCrAq/83T8wfe7SEqRJtGtxUfY1J6DsK50FKyC6Tj4uYUEynpqilCEba7TJri91qci5/sH7wYQdEo4eIkC7iTnGrZH+CfSWtU7yq+cCgJ6LcYU1TBsq4b7/dlzLyRUE1VMs/L6ELtrUUGMrD5e1nBXh/gsjF+FuXTnmUXA9z0AJiRnUyqGRzoN6SHuFgH+4n9nKCL1B7atHqrvhuV8Lnb+9z8Rgo1UGf3UsJJlkeX7HxFo3Kd0HSARzQWhmTSRQQa0ZjsLM9pHfeFPqhgXqVGcDvWfRJs6mhvJne4zLwyVB7k8bCAiSkxxqy1wFTQJVadBunYZFo+FC8RlxfbZutjA/GQUK1JTLEUqJn2OYjBdM4u6oZ/P+9LuaJz141LIkqrCu9v0g/r15rSKhLv C1Uh5zDq bBXYkEISY6nySmx+Ok8bYFhQ2NhlAowheqcCCtBAsSJPq5eZxh9gG/bYTu2A1BGCVTp55i57mf2mH9YOa4TS5a/oiciLJ1xX9cK/GTF/7fiO6jZco8tjFNymzeGFvXT9wBlw5ZyPt+GP/Cel+SD8G9nCkoIgh98HA7qf1dKCBSzQ815mcUBOWSewbzXk8TKoNpeCJmYvr4AR2iIb4vsYtvWMv+dFB8Ov8GoAOvvcwAYHidap3EoKd6v59D5cQhLQMyOpwinAWuu/lXLeW/e7337t3hBcDLhbkvdUZhbOB4aab/u8s5ifpWBRof4m8MmAEr+ckZQpnkbTO8m4Ku4Dk5WgYlVnQ2VOw8oWo7iPDrADFjNs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Jan 22, 2024 at 7:20=E2=80=AFAM Michal Koutn=C3=BD wrote: > > Hello. > > On Thu, Jan 18, 2024 at 06:42:35PM +0000, Shakeel Butt wrote: > > One of our workloads (Postgres 14) has regressed when migrated from 5.1= 0 > > to 6.1 upstream kernel. The regression can be reproduced by sysbench's > > oltp_write_only benchmark. > > It seems like the always on rstat flush in > > mem_cgroup_wb_stats() is causing the regression. > > Is the affected benchmark running in a non-root cgroup? > > I'm asking whether this would warrant a > Fixes: fd25a9e0e23b ("memcg: unify memcg stat flushing") > that introduced the global flush (in v6.1) but it was removed later in > 7d7ef0a4686a ("mm: memcg: restore subtree stats flushing") > (so v6.8 could be possibly unaffected). > Yes, the benchmark and the workload were running in non-root cgroups. Regarding the Fixes, please note that the regression was still there with 7d7ef0a4686a ("mm: memcg: restore subtree stats flushing"), so I would say that our first conversion to rstat infra would most probably have the issue as well which was 2d146aa3aa84 ("mm: memcontrol: switch to rstat"). So, the following fixes tag makes sense to me: Fixes: 2d146aa3aa84 ("mm: memcontrol: switch to rstat")