From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 995B1C433E0 for ; Wed, 13 Jan 2021 19:13:09 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0E96C22DFA for ; Wed, 13 Jan 2021 19:13:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E96C22DFA Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 291DF8D008A; Wed, 13 Jan 2021 14:13:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 24A6D8D006A; Wed, 13 Jan 2021 14:13:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 12FE68D008A; Wed, 13 Jan 2021 14:13:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0152.hostedemail.com [216.40.44.152]) by kanga.kvack.org (Postfix) with ESMTP id EA95D8D006A for ; Wed, 13 Jan 2021 14:13:07 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id B58E71F10 for ; Wed, 13 Jan 2021 19:13:07 +0000 (UTC) X-FDA: 77701699614.22.sky27_360eb3e27520 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id 99EFE1802E2A8 for ; Wed, 13 Jan 2021 19:13:07 +0000 (UTC) X-HE-Tag: sky27_360eb3e27520 X-Filterd-Recvd-Size: 4302 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Wed, 13 Jan 2021 19:13:06 +0000 (UTC) Received: by mail-lf1-f51.google.com with SMTP id 23so4374258lfg.10 for ; Wed, 13 Jan 2021 11:13:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=U+qn9UKmISGqyuqrg148xyc55NGo3+P99P9eHwbXFks=; b=e1lWlrbSHGOadgLWl4yAg0TYAsrtiz9LRHk6SRNsnzPtIQqCuldKL1eq6Ryfk62/Lg HEqxNPjNuL2uJVZgjTuNsDb3sRYrPCu72vDogxVGm1xalOh7So+npokdRFzfAUgnxAKI AEGDGxQdnSMCtU3fAmR8N+90S/reL47zvPBpePRxPQuiI06xFzleYXPqhT+rhuSF3dgA ETEpN/5TZwmad6T52YfZbwSX1fyfEZV5qQKrSSED8hhFjuxq2Fy9krdE2ErAcGtjNIjX wuxVEABsyP1pJu1+J559gEfq3GbRwgFPWvEJE2wCGyS9M+Kt1lbDJmn5bvFmgBUXJsO1 KUWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=U+qn9UKmISGqyuqrg148xyc55NGo3+P99P9eHwbXFks=; b=jXpysU9/Y1Yzt4x85aiK505u9RIv4WzlezlUPeO045LnqfSGxG3BalQTaGt68KZeWZ gUuxn2W0r9L6O+qUt+ZQTKGPcwiltl2tjH5Y+DRD11w/DH0oVF13jhKLTcSMsJz9BluO xn8e7OI43KQ+KMl4alKD1nzNMTPIntYibdXepsbUqcB1+nFgNrtphOiDzMsHeeKkPl4H +KxqrNgmNb0uS3WvTNFax0mDweAZ5Xec3sdH5Mf+p5TAxbqvp6MebfM1G/S4SFRXR+5e 7zbyMhajnDFHzpOLCFV64vhWa1Mwp3qur1DDBxY6s9A51BPc5gpyScffKUXnNKBWoTMQ xcOw== X-Gm-Message-State: AOAM53370zvLzRtiejzLpHNjnCcxzWgRRwAGzP71lpBOEdt3RFhh6A8z Blzv39KHwu831f1D3BG0TmqbjPYbfbkJDAvDCcPWeQ== X-Google-Smtp-Source: ABdhPJy1Lbe6OSS5ubzI/FRHddg/ikE95Xpjjl+xZ7EMAS2W+qa33nEmxdNWb04+aJ3xO8fbHolzl54KJqiQ2OZdZbw= X-Received: by 2002:ac2:47e7:: with SMTP id b7mr1499438lfp.117.1610565185286; Wed, 13 Jan 2021 11:13:05 -0800 (PST) MIME-Version: 1.0 References: <20210112214105.1440932-1-shakeelb@google.com> <20210112233108.GD99586@carbon.dhcp.thefacebook.com> <20210112234822.GA134064@carbon.dhcp.thefacebook.com> <20210113184302.GA355124@carbon.dhcp.thefacebook.com> In-Reply-To: <20210113184302.GA355124@carbon.dhcp.thefacebook.com> From: Shakeel Butt Date: Wed, 13 Jan 2021 11:12:54 -0800 Message-ID: Subject: Re: [PATCH] mm: net: memcg accounting for TCP rx zerocopy To: Roman Gushchin Cc: Arjun Roy , Johannes Weiner , Michal Hocko , Eric Dumazet , Andrew Morton , "David S . Miller" , Jakub Kicinski , Linux MM , Cgroups , netdev , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 13, 2021 at 10:43 AM Roman Gushchin wrote: > > On Tue, Jan 12, 2021 at 04:18:44PM -0800, Shakeel Butt wrote: > > On Tue, Jan 12, 2021 at 4:12 PM Arjun Roy wrote: > > > > > > On Tue, Jan 12, 2021 at 3:48 PM Roman Gushchin wrote: > > > > > > [snip] > > > > Historically we have a corresponding vmstat counter to each charged page. > > > > It helps with finding accounting/stastistics issues: we can check that > > > > memory.current ~= anon + file + sock + slab + percpu + stack. > > > > It would be nice to preserve such ability. > > > > > > > > > > Perhaps one option would be to have it count as a file page, or have a > > > new category. > > > > > > > Oh these are actually already accounted for in NR_FILE_MAPPED. > > Well, it's confusing. Can't we fix this by looking at the new page memcg flag? Yes we can. I am inclined more towards just using NR_FILE_PAGES (as Arjun suggested) instead of adding a new metric.