From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED338C74A5B for ; Sat, 18 Mar 2023 00:58:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 10B1E6B009F; Fri, 17 Mar 2023 20:58:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0BB956B00A0; Fri, 17 Mar 2023 20:58:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F135B6B00A1; Fri, 17 Mar 2023 20:58:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id E2C2F6B009F for ; Fri, 17 Mar 2023 20:58:39 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B2C241604DE for ; Sat, 18 Mar 2023 00:58:39 +0000 (UTC) X-FDA: 80580208758.18.911B8D1 Received: from mail-yb1-f180.google.com (mail-yb1-f180.google.com [209.85.219.180]) by imf30.hostedemail.com (Postfix) with ESMTP id E7F1E80011 for ; Sat, 18 Mar 2023 00:58:37 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=JVXYvxAJ; spf=pass (imf30.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679101117; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qjzUh8wvEqOhjDa9bqpHAUbvJHT68H6FHaSidqfbom8=; b=IDnd3jSRqNhvx0aK1XojmLAE9zgykINju+TPRv3g+QUrflRIcILUtH+jsSlLfNNycmvzhM FLTkC0tflo/5TfFpmrCWD2pTsEnn8cWoQ/NT9KgaJLY0vDKcUkLUqILKwDzOIqi7YBWqj2 UxttciY/2m+UT0w+MOccW7JsaSrd75M= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=JVXYvxAJ; spf=pass (imf30.hostedemail.com: domain of shakeelb@google.com designates 209.85.219.180 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679101118; a=rsa-sha256; cv=none; b=TJHk2kueKHbmll1gGhUK6ptMbH9C0DyDaR0cn2IWmlsGPaWF5xE2KbsFYmFnTQWJNYuKTu kW2T3XIXDteA0gL0OIMIThAR1D09t+bTgSSvGNm4AEoAJ78OqRsk9hvRLpiovwVgLqzZVI iWoIc0TABfjg65ZKazSKj0GVp/VDBgE= Received: by mail-yb1-f180.google.com with SMTP id i6so7513148ybu.8 for ; Fri, 17 Mar 2023 17:58:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1679101117; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=qjzUh8wvEqOhjDa9bqpHAUbvJHT68H6FHaSidqfbom8=; b=JVXYvxAJeUXHaKDbRodHwwtH7IQbXLRoiZr3q/I9SA2PCpkS1A7jED2SYMDkJTLBLv LBkOeMxmB5abOcyMXF5T1ALdKfk1bSw5BQEvIilpvJs77fL+HDTEDX9+gKH3RtDieSKP vbfLPrrOBKZOzx73nkbbXIjbsv8pRnYEwsIr+/yjETCCg+eYwK/QWp1+WAx+ALkV4MvY /VivS/YbrC2rsHalrhTI922KgXxyVaQsQu7kjf3zjmGU6o512Et9PEi0irT3IVbpQEcV Tu1TX0cyiKBZrpslrzTS6GopLi8jnKqRS6ssSqutjLuhZ4Hz7QuXjUdKltEvKgtRTueB NIow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679101117; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qjzUh8wvEqOhjDa9bqpHAUbvJHT68H6FHaSidqfbom8=; b=dmR/eGjRdXjcgGkwmzjjcdUNov7elQGFJf2D1SPGJzk4M2kBSnFTBRxtPS81QxsjdJ re4vZw8jwCN9sosjj2g/TAydacJioCucxDGo6SlCXbNVlbk2Dtp1KMRx+DNE8aJRLMRA PFjqg7hjrsDIzYFsZNj1I1I7xGH9lUIocBh9nR94hhKHtOyLAzwGt04GdwIuAziz2uuB x4JxsMGlpP9ncvxM8ggYVfsA4mMgKU3mKWYpnY9yWsWTre9cyDCF2QY/gj/NKg4cXN0n 4LbXDFTuEYnu4N9pImPasJ5Knncv7PS4MoY2eZDK8d8t00rRzTy44+k6eUdEMDCdN5RB Aw0Q== X-Gm-Message-State: AO0yUKXTuCWI9K3wFxQE9j1yUVYyKQVOJ+by89Wcb2W8v5L5XJIJhAIk I4o+cwx83qQpdbR622cvalC9fDIljobQ98ejA8AAPQ== X-Google-Smtp-Source: AK7set8rZKyofT08VT/4toGO7Bnz9V/ECQUG2scWBzJIC/cG94HLuywYF5c0qXC+TDUhfbx0tdvYog1tKPp9+MZE+U0= X-Received: by 2002:a5b:c47:0:b0:b56:1f24:7e9f with SMTP id d7-20020a5b0c47000000b00b561f247e9fmr280644ybr.12.1679101117000; Fri, 17 Mar 2023 17:58:37 -0700 (PDT) MIME-Version: 1.0 References: <20230308162555.14195-1-findns94@gmail.com> In-Reply-To: From: Shakeel Butt Date: Fri, 17 Mar 2023 17:58:26 -0700 Message-ID: Subject: Re: [PATCH v3, 0/4] mm, memcg: cgroup v1 and v2 tunable load/store tearing fixes To: Michal Hocko Cc: Yue Zhao , akpm@linux-foundation.org, roman.gushchin@linux.dev, hannes@cmpxchg.org, muchun.song@linux.dev, willy@infradead.org, linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, tangyeechou@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E7F1E80011 X-Rspam-User: X-Stat-Signature: jk4tsc1rz898j8964wgraq3jq9imcy18 X-HE-Tag: 1679101117-801275 X-HE-Meta: U2FsdGVkX1+hjeBNo7+SbT180OlDLR1EoMTHS62z8L4L5q9A+oXN9q3135BZ3FKp5o4D/KXsCPXK0sxIQHjIHawYzws3UirC3GExiW+78KCU3D5bQ2S8IMbLud54txzCSIAw6dJMuNCVrBuL9LHo0SU7UgsvhR1ixehKQjXjRL7HDz9DYayp9GT4vXJxXGziECpHsvK91XkJ/zwDqXfgow9vjiApwgStEABGWg57mx1ZhJbg7u4A1b4eQgE1tJSpla1oFhyGSO5jJTNwtjiXZR7zWxdvD2jTS1c4ITxSV3+g2OZ/cQIZsWqQNWit1Q6MWTGqIvG+jlhVlv08uBJqqC6YIa5cl9fjMlM6wPcxPGUJrN+lH/VLf5JtnT6Q1kG8WC8duLKxIEL0P50oAcpZBNvIxcxZbPWIFGapJ3yjMVa91cieZ38xOlChoMdr4umzh3BrSSUzakwtp+ca+UDfrwa/hygj92Ghr+RLxkkhTemYx22AuhwrsLrfrCj3hwZbdJLVnFSlSf9png7TIBkM1z8HkTyhqXyk4uOeYEmqLmTkZkP1iWKdYZGDG0TWUuKXnuW7abixW5aMskRxX0u7Tp5JawMwrK9gFDc84e5rPDtE38bnT2fYCsWsO1bomnZSx9/aH0g+Qqn+vfoZFCWjg1xFaUnycl2hsZS0GfvK7M2YNR1yey3dk8dd5mU41tqtsiHlGU9qNtG59kHGc9bY8lmO3oKW16MIvjp3nAIGGAmDHIfWstZDl1zt27dl4e9958MiAC/ZR5pFrAFaKMQV51Qi/Q2Y+/bl4tqOQ+/oI0DBBneDMI8T1npJAKJx6NAb8hE/TY50QfrbiQJWDPRupUzijxhdOdAQyKiHDZcT3BLxdXUSzb5/biDY/20tFA+k9Ce6vjGAwEct/ZK3u+0yINciE9SeZXczE6dUapx8X2Pq7PvsL3clAJtMO29gfhmmzdGiJzFONJISdlE+SP0 IclBW6V4 zC7O7C119BPXsjnhv1Wlpz9tCvjTkF0h+aEA/CXd9/aJAyRDy5MyLFD98Hwq+0fkEg3RVUrgm0Ua7+2RLDIBZsN5xXvM8hT3WCe6wUnKjB+rZk93saxZqVP6Wb8RWjqOXzVTRUvdS35HlXT5hfD32uRr0hIUTx+mZD0BQJWUNdsMWWPfw08V1umVPRtKe3NY5NwpAgQiv4WQ34zFULKDwwLKpheBS2dSZSmluozd/kKvnvjYSMtkBt0ouyCg+zSS0RYZCJScmolRK3ougl9FoOMdvqhuMtnnssLad1wL/+dDsCiV8kROxkPrNMfUcwRfn2RMKJxnpliUJdXlkAGt9/KO1Ikky3vW1vK6ncnHPvE9VmXm5YrNR5uEH7rJ2jmm8bXjZkxhFPVaikMJ1r8MhixNQkrGdHCEwi35r X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 8, 2023 at 9:40=E2=80=AFAM Michal Hocko wrote= : > > On Thu 09-03-23 00:25:51, Yue Zhao wrote: > > This patch series helps to prevent load/store tearing in > > several cgroup knobs. > > > > As kindly pointed out by Michal Hocko, we should add > > [WRITE|READ]_ONCE for all occurrences of memcg->oom_kill_disable, > > memcg->swappiness and memcg->soft_limit. > > > > v3: > > - Add [WRITE|READ]_ONCE for all occurrences of > > memcg->oom_kill_disable, memcg->swappiness and memcg->soft_limit > > v2: > > - Rephrase changelog > > - Add [WRITE|READ]_ONCE for memcg->oom_kill_disable, > > memcg->swappiness, vm_swappiness and memcg->soft_limit > > v1: > > - Add [WRITE|READ]_ONCE for memcg->oom_group > > > > Past patches: > > V2: https://lore.kernel.org/linux-mm/20230306154138.3775-1-findns94@gma= il.com/ > > V1: https://lore.kernel.org/linux-mm/20230220151638.1371-1-findns94@gma= il.com/ > > > > Yue Zhao (4): > > mm, memcg: Prevent memory.oom.group load/store tearing > > mm, memcg: Prevent memory.swappiness load/store tearing > > mm, memcg: Prevent memory.oom_control load/store tearing > > mm, memcg: Prevent memory.soft_limit_in_bytes load/store tearing > > > > include/linux/swap.h | 8 ++++---- > > mm/memcontrol.c | 30 +++++++++++++++--------------- > > 2 files changed, 19 insertions(+), 19 deletions(-) > > Acked-by: Michal Hocko > > Btw. you could have preserved acks for patches you haven't changed from > the previous version. > For whole series: Acked-by: Shakeel Butt