From: Shakeel Butt <shakeelb@google.com>
To: Michal Hocko <mhocko@suse.com>
Cc: Yue Zhao <findns94@gmail.com>,
akpm@linux-foundation.org, roman.gushchin@linux.dev,
hannes@cmpxchg.org, muchun.song@linux.dev, willy@infradead.org,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org, tangyeechou@gmail.com
Subject: Re: [PATCH v3, 0/4] mm, memcg: cgroup v1 and v2 tunable load/store tearing fixes
Date: Fri, 17 Mar 2023 17:58:26 -0700 [thread overview]
Message-ID: <CALvZod4UjoYasn8Z4-e4NEdv9QRWiuJuJjm8+sH_xFdPTEWEoA@mail.gmail.com> (raw)
In-Reply-To: <ZAjIeTBKteZaYEEb@dhcp22.suse.cz>
On Wed, Mar 8, 2023 at 9:40 AM Michal Hocko <mhocko@suse.com> wrote:
>
> On Thu 09-03-23 00:25:51, Yue Zhao wrote:
> > This patch series helps to prevent load/store tearing in
> > several cgroup knobs.
> >
> > As kindly pointed out by Michal Hocko, we should add
> > [WRITE|READ]_ONCE for all occurrences of memcg->oom_kill_disable,
> > memcg->swappiness and memcg->soft_limit.
> >
> > v3:
> > - Add [WRITE|READ]_ONCE for all occurrences of
> > memcg->oom_kill_disable, memcg->swappiness and memcg->soft_limit
> > v2:
> > - Rephrase changelog
> > - Add [WRITE|READ]_ONCE for memcg->oom_kill_disable,
> > memcg->swappiness, vm_swappiness and memcg->soft_limit
> > v1:
> > - Add [WRITE|READ]_ONCE for memcg->oom_group
> >
> > Past patches:
> > V2: https://lore.kernel.org/linux-mm/20230306154138.3775-1-findns94@gmail.com/
> > V1: https://lore.kernel.org/linux-mm/20230220151638.1371-1-findns94@gmail.com/
> >
> > Yue Zhao (4):
> > mm, memcg: Prevent memory.oom.group load/store tearing
> > mm, memcg: Prevent memory.swappiness load/store tearing
> > mm, memcg: Prevent memory.oom_control load/store tearing
> > mm, memcg: Prevent memory.soft_limit_in_bytes load/store tearing
> >
> > include/linux/swap.h | 8 ++++----
> > mm/memcontrol.c | 30 +++++++++++++++---------------
> > 2 files changed, 19 insertions(+), 19 deletions(-)
>
> Acked-by: Michal Hocko <mhocko@suse.com>
>
> Btw. you could have preserved acks for patches you haven't changed from
> the previous version.
>
For whole series:
Acked-by: Shakeel Butt <shakeelb@google.com>
prev parent reply other threads:[~2023-03-18 0:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-08 16:25 Yue Zhao
2023-03-08 16:25 ` [PATCH v3, 1/4] mm, memcg: Prevent memory.oom.group load/store tearing Yue Zhao
2023-03-08 16:25 ` [PATCH v3, 2/4] mm, memcg: Prevent memory.swappiness " Yue Zhao
2023-03-08 16:25 ` [PATCH v3, 3/4] mm, memcg: Prevent memory.oom_control " Yue Zhao
2023-03-08 16:25 ` [PATCH v3, 4/4] mm, memcg: Prevent memory.soft_limit_in_bytes " Yue Zhao
2023-03-08 17:40 ` [PATCH v3, 0/4] mm, memcg: cgroup v1 and v2 tunable load/store tearing fixes Michal Hocko
2023-03-18 0:58 ` Shakeel Butt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALvZod4UjoYasn8Z4-e4NEdv9QRWiuJuJjm8+sH_xFdPTEWEoA@mail.gmail.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=findns94@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=tangyeechou@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox