From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E75B2C4167B for ; Wed, 8 Nov 2023 23:52:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 671538D00C8; Wed, 8 Nov 2023 18:52:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FA3B8D0073; Wed, 8 Nov 2023 18:52:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 473B98D00C8; Wed, 8 Nov 2023 18:52:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 32BBE8D0073 for ; Wed, 8 Nov 2023 18:52:07 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0535340C27 for ; Wed, 8 Nov 2023 23:52:07 +0000 (UTC) X-FDA: 81436437894.17.816D3E2 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf30.hostedemail.com (Postfix) with ESMTP id 5042F80008 for ; Wed, 8 Nov 2023 23:52:05 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=mrxtX1AF; spf=pass (imf30.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699487525; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E9/j9I5xmRGr2xQ/85BVxrHK3DvRzWkvXiC6XBWsxsE=; b=8NVi5TgMuNfJbAD+Sa5sC/ir9bobTtpkqaCOlYvhQ6npetD9hF1blOHmrf20craidb8YUe Rtk6erkBzYqC/pv5ehdGk0mYcf9TidaVz8wDgI/bkf3oMjOMabzfCPFJEsEoKa5uI4XjV+ yqTmOBvP3xOzdWQp3aMpjBJuL49BsME= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699487525; a=rsa-sha256; cv=none; b=ir0JsrS/gtPM9uJkWxT5YGBkzhLutIxtw6NOX+ij7IJJwizwouVgtKifuPD9+gSzLtwBCd ywfI3l9hsztPBHFpxI0pTPQyFvNiVgeYqqyxQXqD2OLfalWDx5sAKPDubrgKfBFDR2r+V1 bzGU5tf7kJd2BX8mILETrf/wti5XvMs= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=mrxtX1AF; spf=pass (imf30.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1cc411be7e5so29655ad.1 for ; Wed, 08 Nov 2023 15:52:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699487524; x=1700092324; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=E9/j9I5xmRGr2xQ/85BVxrHK3DvRzWkvXiC6XBWsxsE=; b=mrxtX1AFI+fWtcZ6kuCzt12i16hteWdjouYz5IP+qUzhxUNsNyV0+qsG6RHqRcp6ZX wDnv/T1aHqZQP+9c9BGul/bRu/T7G3fbCuThdxYS0k9JTidN0RygYi6c1snZi7YGqfWw 4FqPXBHXo0xgo5fxooR6QNYjczWIkpw4e3i9R473YOlL6kDmht3r89XrAuED0P6QFem3 3Ay9IoOwvEvGQmbF2zrXw6EqzYXv6IUBCjM0VbZ+fYhsJ/Eeg8q21WuGbcjfIbOcUlWL u741ae0okkPvT7TyslpUaJSH5osV6TWeaNs7T53TlvYcsSfO+Fyf6Iq/m/QHhk0sjEVp 430A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699487524; x=1700092324; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=E9/j9I5xmRGr2xQ/85BVxrHK3DvRzWkvXiC6XBWsxsE=; b=HuRDt8SZMRAGlxMSEYAQWhYdci3Ke2CvBdaqt0Ibzewhoa4ZS7gMGQJ2k0cQtfxLIi o3NA1gqilQaZd2YJ7T6UovJCSvvTZFa6cTqie22OZpVO0FU3QgFeQJEZdhpkazG2C+Jw 0PyhubFU2CB596Qzwf+UV4tLD0LMXkMOcQKJxh0uquY51bYr7uzwiCApICIMHsPKy0z7 XxdZnuQJHtDwa/zJzt2m/yQ1a8z0zyhC0KwUXF2T0ooTgKBqGxVp8oZxG163Y419fYUZ 138QepWJ819QjlsOeLDAzvxR8soYrktZXiT+KoF/Xrz0RCLdCkUSppy9KLQrwwd5p3qF 7UOQ== X-Gm-Message-State: AOJu0YxkNSIPdcYCFZus+1lgEk6bwUcjeBhO0OdRjZPNy/SVwk1upGRT IvSqZeMHTFZBqoeoYE0npO+46c9ehHaCmNyIJaLdqQ== X-Google-Smtp-Source: AGHT+IF2Rk1OnLoBlh4G5q0gviP55oQbuaIOMFh/BsYlOySzTGEITwUFg0K4+ckuaQiXzvwkDol0fP1lFjP26SgmBhA= X-Received: by 2002:a17:902:758d:b0:1cc:2c43:9061 with SMTP id j13-20020a170902758d00b001cc2c439061mr95651pll.21.1699487523896; Wed, 08 Nov 2023 15:52:03 -0800 (PST) MIME-Version: 1.0 References: <20231108164920.3401565-1-jackmanb@google.com> In-Reply-To: <20231108164920.3401565-1-jackmanb@google.com> From: Shakeel Butt Date: Wed, 8 Nov 2023 15:51:51 -0800 Message-ID: Subject: Re: [PATCH v2] mm/page_alloc: Dedupe some memcg uncharging logic To: Brendan Jackman Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Michal Hocko , Muchun Song , Andrew Morton Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5042F80008 X-Rspam-User: X-Stat-Signature: 5891op6mcxmos966swe7hd8mjoumuafb X-Rspamd-Server: rspam03 X-HE-Tag: 1699487525-764352 X-HE-Meta: U2FsdGVkX1+f9rRl0FzH19Jgwl+oqqYvOMnUBKV5SRZd1eKdNlFUx/KMhFCeFFd/1VdkiJSnpmwg8+5opbn6Ghn5uKBSt8XAGOMBdAMNCjWV7RJ/dL49Vn4lmg5Ekhq1w3WSPt3J2YDaZE3GW3pa+BM/vdYC/9F+AhlnTx5gdIJO1HFMaL9BWeqo+XqkQz244HWvHqCeKsgASFCS+2HVgUlZknbTZNxkwRjZpMXqgLqG4iIdYRWYqJXnm0c3cJe/qBcRF2Nqax1E27swpHCL14touFhBlugRHGVae0lpqcLfi+iY3x9GwRUAorf8uPOH0X9xv61G5pDPvpmUGZPLxcw5qieBsSeyYtZgx9ZP5fbkbZCJUMYhrrAGvXGTTauCpBi/Ikv4vIb4g4zIwJzfuqf456dgrG7YKhNXUiWdO68bVcEQ+facd7Fjf4zTnEWbzBZVS8l8i8dKIVvkTZcAK938djIjRpwTIS8EqTM0qdLAYFeNtMJLB0M0A2lg1x7ACxZ6zvAZUlYAFyn8L5WhIMx3YsnEBrKvyAjNqAtm01vG31RceD+jXJb2SOR3MLXijd15VmlbSkEjKmI+9ixayVayl0zbqQ9D80v32U+bBMyGG5je/Hy33YNioDxA3dk5JW2F+alAUse+J/A+Vi7ohCQlB3dOro6C9BM1ayuSLsUmDsfTM2XqOhu7UGcjjPLlyzQ42Qlycr3TAB4rWbPj0/UcZWT1hnWOszF1TNsLV5Rwme0hxQS7DMiLE4lrWGvytNa3HMfKbYrT7D2KYMoS5IBj2uLjLgcRsYxtS9WC3cAwHgVzpRyfPtzk5RFQg43KJGuPxZfRTmoJai8FJeHcCdVq9IXLeT7af3Rp+yw67qGZDOpspCMIJL8Y+tUF3MRF4Vl7KsSuL+XVwCh9JcuyM8/Co+DXz7wIckuG/EWnZAiv57yFTnnLJYFVvxASWz/MQXJ+/4mqMaMLb8bor9w SYjl+YU7 NP4NnLoK0kqz6gH24cl/5mwWsNrt3nOh4Z7r3AuuZWUWqCN0mvSLCzFu5uiQby1cES1H2YP6so6Jc/49DRO7q69qFWyAgXD/HTnD+6XHCu6Fy+NwuqfIufw4HX7AUx6FXJk8x9F7zp8EssS6e9D+KLQhomOTmFrXms/a2ZpxtflN9ADH3LQO+BqoGb1WMZwazU0cduH8qAMcyqhoGWcoA/EiG8DZpPvNYb9GsOazRiAl3ikVE7UuqCeQC4XgQ9accOVxPOjVO6fBpcmVOdiKMoWZ5ezjxAflJrHz930BrgK6mYC/MgNQyPZerofclxZPzUXX6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 8, 2023 at 8:49=E2=80=AFAM Brendan Jackman wrote: > > The duplication makes it seem like some work is required before > uncharging in the !PageHWPoison case. But it isn't, so we can simplify > the code a little. > > Note the PageMemcgKmem check is redundant, but I've left it in as it > avoids an unnecessary function call. > > Signed-off-by: Brendan Jackman Thanks for the patch. Actually the PageMemcgKmem/folio_memcg_kmem check should be in memcg_kmem_uncharge_page() and not in __memcg_kmem_uncharge_page(). Anyways, that is orthogonal to this patch. Acked-by: Shakeel Butt