From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CEF9C07E95 for ; Wed, 7 Jul 2021 20:22:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CC584619C6 for ; Wed, 7 Jul 2021 20:22:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC584619C6 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B8B236B005D; Wed, 7 Jul 2021 16:22:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B62656B006C; Wed, 7 Jul 2021 16:22:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A2ADF6B0070; Wed, 7 Jul 2021 16:22:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0194.hostedemail.com [216.40.44.194]) by kanga.kvack.org (Postfix) with ESMTP id 7EA006B005D for ; Wed, 7 Jul 2021 16:22:41 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id DF2C4824C458 for ; Wed, 7 Jul 2021 20:22:40 +0000 (UTC) X-FDA: 78336914880.06.C88108C Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by imf15.hostedemail.com (Postfix) with ESMTP id 7A868D000091 for ; Wed, 7 Jul 2021 20:22:40 +0000 (UTC) Received: by mail-lf1-f53.google.com with SMTP id a18so7409584lfs.10 for ; Wed, 07 Jul 2021 13:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hi3ITr6SouGSQjeuqThC33/t9lBaQSut2Lh+7accmC8=; b=WvflrsatifR0C1QAecIJeGdbr6flHM6sV2cF8SX6cRCr+xI0NrDl5WsaWCEb4VpLrZ 38+7Vsmi6Pjyw0lxSXilNET19LVUzwO2/jVE62gY6Bbd0OW6EDyW1Lipy0R+9QMKGum3 lsiDIvqM4gC9VIQlZx4s7xrzGk14kRIncraWnY7fnzY6Fel954Tnjy+7QNZkn2Nrrogw UiDvj3BeLLGBmjdshySJvN1FV6pUSiUJ/PEQKyPRR7vcdKDMstFoUfsdpMfaBIRj8uOk LGBW/q5bcK389MmrwxihaFmjbLNidJFRBssHJoYxAGwjdx/yg0cL8i0dYf3iklYIPgML eT/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hi3ITr6SouGSQjeuqThC33/t9lBaQSut2Lh+7accmC8=; b=C79BfNsvRzlDasUbRggepVBSHE8Z1kn16T/Agjh4blSt3VYNP+pVlIOCYCPRkAoayA oWQXQkqSw9aRNoKltmCBBlzsrsf4B+pDz+orqH3XmybjxfPQAysk4atgxvsmLtO0Pla7 UraB4Ill/UNV8iQ95QWcpuA3AT/nutOToFeRgnBvhJ1SymaE8r0YbeYHPkiB7tSaM/qr OQy5/0NbECSkTHyysuyuPVO02obSqei2f49XB1bJjLthB0kU/PQklt88FSrmcdp82ycJ dcCUqlfvTaAyTJNnAVDHK7VDDbFZBaD8ETW9ZH6p/vFd36Kk7MXnucj8aH59VyvFwAxx OO4A== X-Gm-Message-State: AOAM533EgH+NM9pQunAHKwgne+G/LUReOMFtBCH1S6Otu4tCR2+bvguE cdXvBsU7zMNa3r4IqXa6eAyugK+D7aT/QRsyt2Aj6A== X-Google-Smtp-Source: ABdhPJwF0fIfrpNN3MSAzhfkvbnU1hEac5p+VXT1iV3T/45FpdBLs0uMyCX5Yh8u2dv0LP2eGplEzO9btiLnEAMd7GE= X-Received: by 2002:a19:7418:: with SMTP id v24mr20712677lfe.117.1625689358863; Wed, 07 Jul 2021 13:22:38 -0700 (PDT) MIME-Version: 1.0 References: <563ce5b2-7a44-5b4d-1dfd-59a0e65932a9@google.com> In-Reply-To: From: Shakeel Butt Date: Wed, 7 Jul 2021 13:22:27 -0700 Message-ID: Subject: Re: [PATCH 3/4] mm/rmap: fix new bug: premature return from page_mlock_one() To: Hugh Dickins Cc: Andrew Morton , Alistair Popple , Jason Gunthorpe , Ralph Campbell , Christoph Hellwig , Yang Shi , "Kirill A. Shutemov" , LKML , Linux MM Content-Type: text/plain; charset="UTF-8" X-Rspam-User: nil Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=Wvflrsat; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf15.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.53 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 7A868D000091 X-Stat-Signature: x7tq31xns5exw4z8bra1xxd61bwc3w41 X-HE-Tag: 1625689360-97981 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 7, 2021 at 1:11 PM Hugh Dickins wrote: > > In the unlikely race case that page_mlock_one() finds VM_LOCKED has been > cleared by the time it got page table lock, page_vma_mapped_walk_done() > must be called before returning, either explicitly, or by a final call > to page_vma_mapped_walk() - otherwise the page table remains locked. > > Fixes: cd62734ca60d ("mm/rmap: split try_to_munlock from try_to_unmap") > Signed-off-by: Hugh Dickins Reviewed-by: Shakeel Butt