From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F17FC433F5 for ; Wed, 6 Oct 2021 05:21:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C8B9B611C5 for ; Wed, 6 Oct 2021 05:20:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C8B9B611C5 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 347B96B006C; Wed, 6 Oct 2021 01:20:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F7856B0071; Wed, 6 Oct 2021 01:20:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20D8D900002; Wed, 6 Oct 2021 01:20:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 147FB6B006C for ; Wed, 6 Oct 2021 01:20:59 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 7E03618030458 for ; Wed, 6 Oct 2021 05:20:58 +0000 (UTC) X-FDA: 78664863396.10.D494FBA Received: from mail-lf1-f49.google.com (mail-lf1-f49.google.com [209.85.167.49]) by imf27.hostedemail.com (Postfix) with ESMTP id 3704070148E8 for ; Wed, 6 Oct 2021 05:20:58 +0000 (UTC) Received: by mail-lf1-f49.google.com with SMTP id i24so5124113lfj.13 for ; Tue, 05 Oct 2021 22:20:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ciDVGqsYOH35J7AcMoo3IqFXoCRGKtna/4nNh2oAa8I=; b=PX0XPkQdsK6VcV1+qe5E+Ws3MuZHQRH5zK2EJhibfZ1p+ae4ZLUqE2uyBANAjRuZCx GeXpFV/AWrWBo/t32n6nw7eG4uGD/5B7/23okivlIH+KKES5dAZfgyXnQ8zz89hrnhPM liKp70d2Hxfq9gkAMHIEsKT5+fjZa7TZwmjSBJXjsXXQEkrxQdL0FD32ljWrdxHAMCbX WnJASMLr+YbRvIAuQ2AVgfQQBurUUPQzn36gJAv4Bo6RUWXkC5/e0yQ0j6zENpg0Y1xI 6hc+6ZYVIm6sWazuZZAzbzbGlbefkJHxqehgLmcH6zD4QcLJtCvSBX/YGszd1nb/k+W0 vdTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ciDVGqsYOH35J7AcMoo3IqFXoCRGKtna/4nNh2oAa8I=; b=OLa3EbIQi+ICAuCNRitR7JvudfpqzJYeN4SGKtll5DyRkjhi7bk7yX+I2SJ9g2UenI 63dD7MoWDnSvJEXvkbzsLZOEK63HsMqSXj2SZWOUcVEiY5DGzeOzCy5qYAXYVsmsC7ZA GzEH9pdgvmOfW139381nNcnVQXqYtGd7qiIbNjxDGXyHpV/EezfvUZ1HQ/CYvYdkmWsE ne7FufJSH1wZJhu3oxzEsAHOfwVPJH854mWFrMT1jcgoY5gbYWiLBHFunW098fjEkNW4 Db+70vjEWtpw0p8cS6YPDtL7lXv3Zcw3ffsvUV9fwOxr+E0heX6n2VuekyH9fMwa6EJo Ps0g== X-Gm-Message-State: AOAM532gFZzQKVmCMjtfGBdiXO32cItNtWQtgfw5X1IIhip86DYL/XtW GPdzn0bLb/ebfOHgBEMTnHn8zCxny7JVUE/puCc1sw== X-Google-Smtp-Source: ABdhPJwOOgy1WotQnWFPm8n0pGDBcluDmJgc+49p7hGhcTZ2QvP2pF5lVEYlLy0mnXHpJxuod/wIwBgpVBsKuG446WM= X-Received: by 2002:a05:6512:3b21:: with SMTP id f33mr7906462lfv.8.1633497656441; Tue, 05 Oct 2021 22:20:56 -0700 (PDT) MIME-Version: 1.0 References: <20211005202450.11775-1-longman@redhat.com> In-Reply-To: <20211005202450.11775-1-longman@redhat.com> From: Shakeel Butt Date: Tue, 5 Oct 2021 22:20:45 -0700 Message-ID: Subject: Re: [PATCH v2] mm/memcg: Remove obsolete memcg_free_kmem() To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Vlastimil Babka , Roman Gushchin , LKML , Cgroups , Linux MM , Muchun Song Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 3704070148E8 X-Stat-Signature: syhoxdeqwajba49mpc7f3yxquoqkdwyr Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=PX0XPkQd; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf27.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.49 as permitted sender) smtp.mailfrom=shakeelb@google.com X-HE-Tag: 1633497658-677300 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Oct 5, 2021 at 1:25 PM Waiman Long wrote: > > Since commit d648bcc7fe65 ("mm: kmem: make memcg_kmem_enabled() > irreversible"), the only thing memcg_free_kmem() does is to call > memcg_offline_kmem() when the memcg is still online which can happen when > online_css() fails due to -ENOMEM. However, the name memcg_free_kmem() > is confusing and it is more clear and straight forward to call > memcg_offline_kmem() directly from mem_cgroup_css_free(). > > Suggested-by: Roman Gushchin > Signed-off-by: Waiman Long Reviewed-by: Shakeel Butt