From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15527C43381 for ; Tue, 9 Mar 2021 19:39:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9D55065237 for ; Tue, 9 Mar 2021 19:39:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D55065237 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 401F78D013A; Tue, 9 Mar 2021 14:39:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E0938D012A; Tue, 9 Mar 2021 14:39:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2902C8D013A; Tue, 9 Mar 2021 14:39:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0093.hostedemail.com [216.40.44.93]) by kanga.kvack.org (Postfix) with ESMTP id 0F35B8D012A for ; Tue, 9 Mar 2021 14:39:55 -0500 (EST) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id C50B95010 for ; Tue, 9 Mar 2021 19:39:54 +0000 (UTC) X-FDA: 77901351108.03.FB33BAE Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) by imf19.hostedemail.com (Postfix) with ESMTP id 0B1EA90009F2 for ; Tue, 9 Mar 2021 19:39:52 +0000 (UTC) Received: by mail-lf1-f52.google.com with SMTP id m22so29154798lfg.5 for ; Tue, 09 Mar 2021 11:39:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O46M3IIWV4RV88W2VUWchBj7kwlQmirz9u+5Alym8yc=; b=m2G4dpRKCKk4jAg5sje4s8QPtz+nuPv9/ny7IjNDQ40seewDXWUrpQnBW2ZtvbFkdX sLuivAlg3hdtXWVYzKghMWNIet57gAxVg5Jyd4Chjk0Ss54nblyCP3DKQdjk+q8ip9uw dQaw4fDbgJqwnukPuBBi/X6uptSI19BeLBryTRWseEiZ7kDnorSJsrWLexiAEGQ/5l9Y ut0CwZo2K9aDnRu9OpC6gyYJPbdZCkq2DDo2UJzxL20MOhLH65tBairR93pWREEo5cZ0 M7ciABLzghZJ8mmp3ZdaBBnplgO7juWHIaJEDMMB5VcQR08TBNYL+JcR/VymX7c4FI57 oCdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O46M3IIWV4RV88W2VUWchBj7kwlQmirz9u+5Alym8yc=; b=aLHb989knscj0cQ59N/2Zmk8NIe5a2M//BmubR4rBeXKhG1igIgH9DmFFf7Zh5xaTa cZaEfKsqY91RH1PutrHbrCVefl7cTj2XgdV744ZP8yDnnFadK814RFt43Eh/wRIE6vxz FLt2Y7yZg2m3T0wn+DWwqiuTTiX3tkCgUwRd+QeGW8yvULJ8/ufxrTWCau0tLJsRhd1n YwE3fDC0KqfGEI4lzie7Q9ehBMqvyEOC+NkVUtEL67lPsd/0nkcDKcvqRqd+SBhIr8LG uVsre3YTx/fXQcmV/vHJoxvNu6U6E9LRfA71w4K5J4ORMzH6gWhDKYYBgL8zh3+GOA5j iGcA== X-Gm-Message-State: AOAM533YbTfTj+4crSoXrhPyO6fPZd4oxYejejGIvoLuY9G04F8VuuFU S4A8QgyG/IrCpHOBuw5bHFnMEW2KuN9MCk0zXm6wxA== X-Google-Smtp-Source: ABdhPJwZ/ZgQyM4Yah2VVD5YuOSsVe+6+Bkx02Hn3jyr7xsc0JAq6msUO432fuBOvP2pKGGrmU7IKychmWghvMBJ4rk= X-Received: by 2002:a19:e0d:: with SMTP id 13mr3559391lfo.549.1615318792567; Tue, 09 Mar 2021 11:39:52 -0800 (PST) MIME-Version: 1.0 References: <18a0ae77-89ff-2679-ab19-378e38ce2be2@virtuozzo.com> In-Reply-To: <18a0ae77-89ff-2679-ab19-378e38ce2be2@virtuozzo.com> From: Shakeel Butt Date: Tue, 9 Mar 2021 11:39:41 -0800 Message-ID: Subject: Re: [PATCH 1/9] memcg: accounting for allocations called with disabled BH To: Vasily Averin Cc: Cgroups , Linux MM , Johannes Weiner , Michal Hocko , Vladimir Davydov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 0B1EA90009F2 X-Stat-Signature: yboqcje98qg3ws5zicasrwy9i8bwgqyr Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf19; identity=mailfrom; envelope-from=""; helo=mail-lf1-f52.google.com; client-ip=209.85.167.52 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615318792-262574 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Mar 9, 2021 at 12:04 AM Vasily Averin wrote: > > in_interrupt() check in memcg_kmem_bypass() is incorrect because > it does not allow to account memory allocation called from task context > with disabled BH, i.e. inside spin_lock_bh()/spin_unlock_bh() sections > > Signed-off-by: Vasily Averin In that file in_interrupt() is used at other places too. Should we change those too? > --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 845eec0..568f2cb 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1076,7 +1076,7 @@ static __always_inline bool memcg_kmem_bypass(void) > return false; > > /* Memcg to charge can't be determined. */ > - if (in_interrupt() || !current->mm || (current->flags & PF_KTHREAD)) > + if (!in_task() || !current->mm || (current->flags & PF_KTHREAD)) > return true; > > return false; > -- > 1.8.3.1 >