From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4694CD37B0 for ; Mon, 18 Sep 2023 15:49:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B3966B03BE; Mon, 18 Sep 2023 11:49:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 464296B03C2; Mon, 18 Sep 2023 11:49:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 309F96B03C5; Mon, 18 Sep 2023 11:49:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1B8E46B03BE for ; Mon, 18 Sep 2023 11:49:51 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DF1251402AB for ; Mon, 18 Sep 2023 15:49:50 +0000 (UTC) X-FDA: 81250153740.27.5BD14D2 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by imf02.hostedemail.com (Postfix) with ESMTP id 1FD6880015 for ; Mon, 18 Sep 2023 15:49:48 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XLJ0gIKo; spf=pass (imf02.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695052189; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cDPvNTGnVzfWEnM2vQQWdbts3fJPWj+Kgd251XWPAzE=; b=f2MJVU2wJYp/exBaDAqFjP5Z9cIQ4VvHR6hKbml26QcHU05Fnqnxhpa4DSJJB+hNJquaQe aU0jK5NM45o+fNbqr6m3x9BN3zMDrnpX+tPdEQre91+8ZfCuqH7oZRfsJhP0rZ3zzepVmR TNJyFkf9j6r6kQ+iOj8P3TjeaDFSFXI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=XLJ0gIKo; spf=pass (imf02.hostedemail.com: domain of shakeelb@google.com designates 209.85.214.173 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695052189; a=rsa-sha256; cv=none; b=BCEcNBa3HOT5tMmZTezSsHxGVCBBF3nayqwn+Kz4sz+JhNBgKmlkUP76rjb+EMKrr0zWcV W/H7wgSC6/QA4VDDGkayLMR4CQ6I5haQTRlh7EEq76EOvZz0epskIaFRVrfFraVoG1nyjz AwmG2qEGq2E4JwRS90940XvtjTZzayg= Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1c0e7e3d170so230855ad.1 for ; Mon, 18 Sep 2023 08:49:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695052188; x=1695656988; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cDPvNTGnVzfWEnM2vQQWdbts3fJPWj+Kgd251XWPAzE=; b=XLJ0gIKoWGPftwYH6322kHJZcmSW26uVzxI2Hw4T80LVISIIYCitZTSZmzJn8MOKro csCVKsAFOSHUhRrd7CX7hJODBotK7opc0tz+vPPdqT8g2tyaWGQQ3d7e+mjqOoyY2bSb dO+/OLs4TeRSTj5l1IuD+l+gzXjnyTRh/ebH19iaeXYXGLze03erFlx9mX6/FjXtql7i rhGQfv5wzatp6c2m/N3JoTHBYZJfRJsuadEcPbSRn1KFwi6sQ4lMLE1fy6S0ne0nkBvN WHtmFw3drw/0kEiRPuHEHX/YRk5+f5u6SE4kw3I0b6jqYUQ1UDn2tkjpqT4UUi2fc8G5 tn1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695052188; x=1695656988; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cDPvNTGnVzfWEnM2vQQWdbts3fJPWj+Kgd251XWPAzE=; b=G2cg76V42XSpJcxWB//1sfndHUHb6oorwWa9p0QSAaVu4RPkenDjZvwLDa4jZHY3We FriE6cJjP+ue43ACbHqWTb5pmbKjGIXyS3L3ZOUZg4LuJ0d1cvbdYJTNzOiPwInX9vvp kphNcGkj5mseShJ0BRKDIE8nilGyjPoaXnLbobMYImVTK3USqEnJ7AmSylYDsh3p1Kk3 FZBDKaiHSvnEkn2s2sdJi0a0SKAEqUYy3CUz1LBHJ+yxD8ZM8yonYxoSImPDjn7FWzWK tc7Et+PZL6HXDsQQXI4vXiL30/DLD7JuS33ANXM2aiJcXYlUQbTmcl9owcYtbplc7XNI 2kqg== X-Gm-Message-State: AOJu0YzJ+44+wCQDLLeCpum0WOGtuAie0LglC1YGe3fj0j6eFEYJESGm BYHXPtq2EXBcKTNP48kcr1YkDwreIZ4WNTUlIVBbuw== X-Google-Smtp-Source: AGHT+IHX1+2Zl+SQS6wfYua3ZBYCi72FsIZkYPIqSURf8Dthf3fUhwidvKwEQ1mfTRGHNrOVqA63S2x0HPiO3faeRNk= X-Received: by 2002:a17:902:d2cb:b0:1c5:59ea:84c3 with SMTP id n11-20020a170902d2cb00b001c559ea84c3mr158871plc.21.1695052187709; Mon, 18 Sep 2023 08:49:47 -0700 (PDT) MIME-Version: 1.0 References: <20230901062141.51972-1-wuyun.abel@bytedance.com> <20230901062141.51972-4-wuyun.abel@bytedance.com> <8c470d4d-b972-3f43-9b0a-712ee882a402@bytedance.com> In-Reply-To: <8c470d4d-b972-3f43-9b0a-712ee882a402@bytedance.com> From: Shakeel Butt Date: Mon, 18 Sep 2023 08:49:36 -0700 Message-ID: Subject: Re: [RFC PATCH net-next 3/3] sock: Throttle pressure-aware sockets under pressure To: Abel Wu Cc: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Andrew Morton , Roman Gushchin , Michal Hocko , Johannes Weiner , Yosry Ahmed , Yu Zhao , "Matthew Wilcox (Oracle)" , Kefeng Wang , Yafang Shao , Kuniyuki Iwashima , Martin KaFai Lau , Breno Leitao , Alexander Mikhalitsyn , David Howells , Jason Xing , open list , "open list:NETWORKING [GENERAL]" , "open list:MEMORY MANAGEMENT" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1FD6880015 X-Rspam-User: X-Stat-Signature: 73kyo3oqmsrn6ye6fiosc5syjwkmx1gq X-Rspamd-Server: rspam01 X-HE-Tag: 1695052188-730492 X-HE-Meta: U2FsdGVkX18Cc0QIt3n+4S6L7Iiwf19BRQ/04dg58SBii7JQrcpZSJLC7nin+e2qT8vsMltqOXon76VMqm5/qT8N3xpcIJGIQAvBnr3Fb6x/W+4eYNDvGvXSfh6Hpt3N5X1t6dselIy9LSmWjpCHnNFHvnHdHk2QmAU0Fu2d5CdsVEhSMPr8S1YJ8YuK0Ajp3y81myKWVd0qx61W02uiZgq/BcoKh0eBXp1wsRP9jaJYRs5xwqSI1k6n3wUMk9n/hXveCDAG2rW2i5jTMD/WOOfkFXqMJQg+lSLgaJg4Ubx2ch8JQBbtF/TI7eE76XtjJEQDZviuCh4ENPEwcy/RDB9PWGutX7pqm53LE0JAvBY2r0YLw3uiC0ivSSO8quBS+2gJDJKgVxjQT4HctFS+j12HAutvJR7rfSZtqUkV3au8ptRrVhlNVcQrEptxTTati5omBVDfujg8c5fA8GYCyPoOZgUOmYrKvjExpTKjR1rjHHxUCuoC+ruJnxeQ4pgjUrOLlGPPkTwWMdoIu7L85CUTqot1I2tvGpWEIJQLL8bmzan9w9WFCDWo5JKVVOSC9EUsE71KeC78NFDfORJX1nkGroBpoDp9Q7CWWwjtj1wbqC/6LWFeYBppH4HurTGsPJKlpUhTgoHb2VxG38IustQg/rSnoiz4e0ZSPPcbH2BXnPUDszUNAa6dfTOm5LYp0c0EdLS4SSbGbf0Bi9aiQODm002oxtBNB3L2dJCeLLDm9XIky24S6hC2ECKU2zml1vy3lac+q3SdkKf8ueC2MIiNjCJPAbmTzOUqlDPeYRbwx4S0JgmUceI1OLSutsuoJXWeWqrN3zpMCB7Y/cpyPbw7rNk+aIK9OzlXLQ/aYE+ANBcKxxwpgjvKakkI90nI3FOf4b4HNprlAfM6L9NrVIT/+zsMK/dtu/kT7egNvTTmNfRElpUV+mG6zEzrDJ+zveizgcg2zWdtSFb6LPG 1FM61oDo lHrS5/SypTYlShRMPh0MFl0oK2oG7RsvV6P2J1UEAW0Lp7+xf6k6LrL+XqXhF7bSgCgqxTFUIf67rydqow+a+8WzPdO8LMfDHeG+TWHymTEwYbpTeFm8mhjJMqpk7e4IbedGpXUbemVJfdoPBqSaq5t3roPAjs50zRC4KeNaxwlJE3DFCyHsRJj48sqgP+aSfSDIqxVzn8O2ZStPtQMF5moQVkkhY7wPXx2HYYdIBFsr8FCniHBDxnGiAQFIrLLRaLcuDUIQzuixUY4lsFhN0MGBNleDpcKQ7F3tY7BBUlcvYMKOP0d8vDiPJtVr9I0JrnC4cck1LpHc8IQ9lsVcheTh9pGI0/sinYuFHQWNU3hjqQAw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Sep 18, 2023 at 12:48=E2=80=AFAM Abel Wu = wrote: > > On 9/1/23 2:21 PM, Abel Wu wrote: > > @@ -3087,8 +3100,20 @@ int __sk_mem_raise_allocated(struct sock *sk, in= t size, int amt, int kind) > > if (sk_has_memory_pressure(sk)) { > > u64 alloc; > > > > - if (!sk_under_memory_pressure(sk)) > > + /* Be more conservative if the socket's memcg (or its > > + * parents) is under reclaim pressure, try to possibly > > + * avoid further memstall. > > + */ > > + if (under_memcg_pressure) > > + goto suppress_allocation; > > + > > + if (!sk_under_global_memory_pressure(sk)) > > return 1; > > + > > + /* Trying to be fair among all the sockets of same > > + * protocal under global memory pressure, by allowing > > + * the ones that under average usage to raise. > > + */ > > alloc =3D sk_sockets_allocated_read_positive(sk); > > if (sk_prot_mem_limits(sk, 2) > alloc * > > sk_mem_pages(sk->sk_wmem_queued + > > I totally agree with what Shakeel said in last reply and will try ebpf- > based solution to let userspace inject proper strategies. But IMHO the > above hunk is irrelevant to the idea of this patchset, and is the right > thing to do, so maybe worth a separate patch? > > This hunk originally passes the allocation when this socket is below > average usage even under global and/or memcg pressure. It makes sense > to do so under global pressure, as the 'average' is in the scope of > global, but it's really weird from a memcg's point of view. Actually > this pass condition was present before memcg pressure was introduced. > > Please correct me if I missed something, thanks! > Please send the patch 1 and this hunk as separate patches with relevant motivation and reasoning. thanks, Shakeel