From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5B89C433ED for ; Sat, 3 Apr 2021 01:11:03 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 456FD611B0 for ; Sat, 3 Apr 2021 01:11:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 456FD611B0 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 733E76B0074; Fri, 2 Apr 2021 21:11:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BCB36B0075; Fri, 2 Apr 2021 21:11:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 55D608D0001; Fri, 2 Apr 2021 21:11:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0096.hostedemail.com [216.40.44.96]) by kanga.kvack.org (Postfix) with ESMTP id 3584D6B0074 for ; Fri, 2 Apr 2021 21:11:02 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id CBC7B8152DBC for ; Sat, 3 Apr 2021 01:11:01 +0000 (UTC) X-FDA: 77989276722.02.950BBE8 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by imf05.hostedemail.com (Postfix) with ESMTP id 13090E000102 for ; Sat, 3 Apr 2021 01:11:00 +0000 (UTC) Received: by mail-lf1-f44.google.com with SMTP id o10so9622264lfb.9 for ; Fri, 02 Apr 2021 18:11:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=f4qgLvucY0towbKBWbt2D03ufnCif8gBNVZdzFUpcrc=; b=eXrvkjPSf/fPPB1l4l26YyJ+bAarsI9LJVJvwYkGHWtyQrsOGRf/klTPoIVH1noGlc +MwmIDXs6iO8QfBebmm7/VfligvMvD6x0xgKlUKZggb2DRrgJukpGxOfy3/2sTMyReV+ VUn6XkbUPdbFHGFviNBZyhHlKwZzZabP2BFbwf72cEPY7QBmuupufoy9NMXOq3FrJVra bSFbirOr4jWNGdpexHXzmLGwJ+mwNkBlZYMqpGol7GGg7zZYAOZG/FxsQ2dc2lChTVfq OdmdXmgr7mCspUb6pwyhqJUzAfkfJc8B1PQf9oPmJ9sm8btSoSPhtGkGwDX4oS3rM2CX QYTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=f4qgLvucY0towbKBWbt2D03ufnCif8gBNVZdzFUpcrc=; b=WPfBG6O6h4y9yqHPt4hdsST8XRWy74WNRXEX2t24oen/vpwUp7QnQQbSlMddQy4O7T PIuMgKz2Kofe/jjsZlTiLCMGILsbLMCLnrGnd1J5PM0B4mBILFZxbieslPhk8YPhYPXX bHdrDgQc5P2aQUyIDL6b6uuBqAOpq3MZYvEnBOrriTNeMkfROqMGlahGRMNPEas4u5Ro 1sctIOhUbZE+PN7EFzDfdJffl6hTBB9Ib34ZpkxqrvlffPBH3uoP3nqLYQtKPdKXv31h t9iFv3OpXV8Ms7ES4eh4g3d7jj4CDM+LduZ//RBmDuwwtSEZLAeaWPeltdGKDc+PKjDv gcoQ== X-Gm-Message-State: AOAM533UDDQ1KBlVzxm2+hiX5JMFo78GCYA2t1KpRNxPmWUtNfGhdut+ zP7MY7TEBw9co9rOmSqeP9TELXr43SwNnslGrSXmPg== X-Google-Smtp-Source: ABdhPJxLcxJqp7ZTc/a+c05m05GlRq8eKjCl2BGJgLfE8Y9reNaQm2aSnDkRQnFlm9CrH7FbnMRZG94rj9BPN/UjzOI= X-Received: by 2002:a05:6512:c04:: with SMTP id z4mr10396546lfu.299.1617412259753; Fri, 02 Apr 2021 18:10:59 -0700 (PDT) MIME-Version: 1.0 References: <20210401030141.37061-1-songmuchun@bytedance.com> <5c183fe6-637f-151c-67f0-fe19a0ce3356@huawei.com> <20210402180454.c28395d38396b58659c15fcc@linux-foundation.org> In-Reply-To: <20210402180454.c28395d38396b58659c15fcc@linux-foundation.org> From: Shakeel Butt Date: Fri, 2 Apr 2021 18:10:48 -0700 Message-ID: Subject: Re: [PATCH] mm: memcontrol: fix forget to obtain the ref to objcg in split_page_memcg To: Andrew Morton Cc: Roman Gushchin , Miaohe Lin , Muchun Song , LKML , Linux MM , Xiongchun duan , Christian Borntraeger , Johannes Weiner , Michal Hocko , Vladimir Davydov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 13090E000102 X-Stat-Signature: ijwug371utpbcf96jay5f45ftc4oyiab X-Rspamd-Server: rspam02 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf05; identity=mailfrom; envelope-from=""; helo=mail-lf1-f44.google.com; client-ip=209.85.167.44 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1617412260-930973 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 2, 2021 at 6:04 PM Andrew Morton wrote: > > On Wed, 31 Mar 2021 20:35:02 -0700 Roman Gushchin wrote: > > > On Thu, Apr 01, 2021 at 11:31:16AM +0800, Miaohe Lin wrote: > > > On 2021/4/1 11:01, Muchun Song wrote: > > > > Christian Borntraeger reported a warning about "percpu ref > > > > (obj_cgroup_release) <= 0 (-1) after switching to atomic". > > > > Because we forgot to obtain the reference to the objcg and > > > > wrongly obtain the reference of memcg. > > > > > > > > Reported-by: Christian Borntraeger > > > > Signed-off-by: Muchun Song > > > > > > Thanks for the patch. > > > Is a Fixes tag needed? > > > > No, as the original patch hasn't been merged into the Linus's tree yet. > > So the fix can be simply squashed. > > Help. Which is "the original patch"? "mm: memcontrol: use obj_cgroup APIs to charge kmem pages"