From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 044EEC43460 for ; Mon, 12 Apr 2021 19:22:50 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8CE0661352 for ; Mon, 12 Apr 2021 19:22:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CE0661352 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 19AFB6B0070; Mon, 12 Apr 2021 15:22:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 14BCC6B0071; Mon, 12 Apr 2021 15:22:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F06216B0072; Mon, 12 Apr 2021 15:22:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id D0DB46B0070 for ; Mon, 12 Apr 2021 15:22:48 -0400 (EDT) Received: from smtpin37.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 8254F5C0 for ; Mon, 12 Apr 2021 19:22:48 +0000 (UTC) X-FDA: 78024687216.37.45A3351 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) by imf25.hostedemail.com (Postfix) with ESMTP id DF5D66000106 for ; Mon, 12 Apr 2021 19:22:45 +0000 (UTC) Received: by mail-lf1-f48.google.com with SMTP id r8so23119258lfp.10 for ; Mon, 12 Apr 2021 12:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Gd0dxflCaTKXdqbWxXEfT6HOfWboYzChFATjj4IIxDU=; b=KwSeQQinUU7zyo5Fv1JGk2xgxPkBqPeRGTDM5KlhEpSwkX/XmivjIkm0LJEPxZGVHO joO7arIl3VlPnxUWo8T2MkV9me/LsH/H2Z6sLalkVByWBszJ4jkA5pLzF8FjA5Andgiv wkmj7PcKXxQh2CnzxWgubF//q5lAaW/Zo4ebzkt3I4G3UaSLWfv+gGeURTDeuRncPMcn 3O7ViH/4/EWgaF0jz37FDL3lPDL5xQoguc1AfxXdRdHrUTgFccWzvfnWPfVu0lcPhkFo 31sxVTQkxdGuRuoQXfXncTjoCebtKW24RXa5qGmyOvST1FPonNKJA5Im+CL2FTRcImrM GZ8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Gd0dxflCaTKXdqbWxXEfT6HOfWboYzChFATjj4IIxDU=; b=D5j4h3W2eqHcf7FcWfMEh0coFXChoUYUVNkYNpVcdaMxBy3vArGOL+UD2P5Wiwapkk jCh7g9O8L9g9mW4r6J0zD7/PRo4piF96wQBso9rJ+ns2J+cVlrH8k1RjdKCdYORyB5La pSPWZnCtYxeboUHnXaXE7mOoqNyunKzKXNraYjPlmcmOYCfHLgMAOs+OheJlWIDmq/90 3/aU99ICTRkwoHFtDnT9Fp3ZxWywX6luXzHtjF2rXydZQWAf8P0zw1CyjXz6KG2DQTv1 2CU2ngvjdHvG5tOWJw2bdGSTxVDqxvx7rxMy7D6Ydr1bqDUdguQM6Gx47Ml+qJ6fxEiJ t1Jw== X-Gm-Message-State: AOAM530wSGB0vEKWGTKbGh45kFGdVVqm+uarvRfGMUpiyIXCqID3M9QU 0/pGsuHlcrZUNp4BeopdLW3po7dorzmdjrsngUQIFg== X-Google-Smtp-Source: ABdhPJyroaK2RiYclmz6pzbGm8fFY4sD5rXEsikqbQYegIq/wuxdQyXAuN6/b1qwvpMONbNLZwNchnmwL6/Vg/OeeBY= X-Received: by 2002:a05:6512:3703:: with SMTP id z3mr19675008lfr.358.1618255366497; Mon, 12 Apr 2021 12:22:46 -0700 (PDT) MIME-Version: 1.0 References: <20210409231842.8840-1-longman@redhat.com> <20210409231842.8840-2-longman@redhat.com> In-Reply-To: <20210409231842.8840-2-longman@redhat.com> From: Shakeel Butt Date: Mon, 12 Apr 2021 12:22:35 -0700 Message-ID: Subject: Re: [PATCH 1/5] mm/memcg: Pass both memcg and lruvec to mod_memcg_lruvec_state() To: Waiman Long Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Tejun Heo , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , LKML , Cgroups , Linux MM , Muchun Song , Alex Shi , Chris Down , Yafang Shao , Alexander Duyck , Wei Yang , Masayoshi Mizuma Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DF5D66000106 X-Stat-Signature: ee4embrciqonz4xfm3g67mjntgzntz1m Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf25; identity=mailfrom; envelope-from=""; helo=mail-lf1-f48.google.com; client-ip=209.85.167.48 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618255365-973074 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 9, 2021 at 4:19 PM Waiman Long wrote: > > The caller of mod_memcg_lruvec_state() has both memcg and lruvec readily > available. So both of them are now passed to mod_memcg_lruvec_state() > and __mod_memcg_lruvec_state(). The __mod_memcg_lruvec_state() is > updated to allow either of the two parameters to be set to null. This > makes mod_memcg_lruvec_state() equivalent to mod_memcg_state() if lruvec > is null. > > Signed-off-by: Waiman Long Similar to Roman's suggestion: instead of what this patch is doing the 'why' would be better in the changelog. Reviewed-by: Shakeel Butt