From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97908C433E0 for ; Thu, 18 Jun 2020 14:55:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3CF17208C3 for ; Thu, 18 Jun 2020 14:55:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="pRbcC693" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3CF17208C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9CD978D0029; Thu, 18 Jun 2020 10:55:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 97DCB8D0018; Thu, 18 Jun 2020 10:55:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8929A8D0029; Thu, 18 Jun 2020 10:55:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0147.hostedemail.com [216.40.44.147]) by kanga.kvack.org (Postfix) with ESMTP id 704B08D0018 for ; Thu, 18 Jun 2020 10:55:50 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E03B2180AD807 for ; Thu, 18 Jun 2020 14:55:49 +0000 (UTC) X-FDA: 76942632018.30.owl12_4006a0226e11 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id A37F81802B419 for ; Thu, 18 Jun 2020 14:55:49 +0000 (UTC) X-HE-Tag: owl12_4006a0226e11 X-Filterd-Recvd-Size: 3657 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Thu, 18 Jun 2020 14:55:49 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id w15so3631016lfe.11 for ; Thu, 18 Jun 2020 07:55:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6dqnJj0lECjZQUIylFPZhd0nKb0VZ/tVZQGVsKEkM4E=; b=pRbcC6935U5lV8EqLRLMS/rBbwozTHCWmNLsUUnX8q6t5IqwEyHjaTZrDJ03waT7ub xkj7GxRjPPGqB+LL5DE8sScJV6/dWsNLm/LeyHNcdKWJsnd/aMgX4YUvN2APoxM8rLv4 W3EDRnWRrF8w4HYQrvhJsOT0M2xQR6rlZe7vsxXtNGk1uzOXOy/Qi0doKSMHR65WVJ5R dMzX7bNeEBgH88Z29ngyXeBIAQGnpzimCXZmqPrCzXEsmy1VqTsmpqEql+6LZKWsWHUj 3drti1PdZ6eeLuiPZp7QFQb/eBSGy1BgpPjnbpbdxqcXxf+9xq0bOBs7u+O8j07mP4aB DGjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6dqnJj0lECjZQUIylFPZhd0nKb0VZ/tVZQGVsKEkM4E=; b=hBjuCxPdrYrCKETRACECUDcNOx+6sRK5t/inYkzHWAJ7tAM1R1oH+FKeCfWejeisnq JkopphGNuozJIwLWxvfqxPFJpVnnGCWf6NMGLzStzxLlRwPRNnIZCYaqUmztvxozb+9o 3inPczQrBxIGd9oUfCepLJ7x1XcrljD+d9rNfTEwVMsQJE6sh/OnmRLFGkgky27QPDLe 20dmdxPXzgUcILbpjzScUC657PKFz/c+LcQtdwdX3vAzHrwwWjhNpo/lgTqurz3nRzvB PTel0mlQ9ZjV1yCEq3VcD0KoZnUGKRB4LOnbPKqReGUcAjlakkqTUCXl+4Na0n1MN0Wb AB9Q== X-Gm-Message-State: AOAM530NFiMueUXBnaF27CRjHvPCE382ToPFO48BgxXT1ltLi10k1Pds m1OoSbQx2e+3OLVB3l+Mf49RzII4INeA5EvFnIIYyw== X-Google-Smtp-Source: ABdhPJzfDtsd2nNokfLfe5eRCVq78SAuKBGFd2B0mMG2zNcO/senzmcip6cwovel39rl1gA+VUj6u/ad46PEd4u30+8= X-Received: by 2002:a19:11:: with SMTP id 17mr2620971lfa.125.1592492147402; Thu, 18 Jun 2020 07:55:47 -0700 (PDT) MIME-Version: 1.0 References: <20200608230654.828134-1-guro@fb.com> <20200608230654.828134-6-guro@fb.com> In-Reply-To: <20200608230654.828134-6-guro@fb.com> From: Shakeel Butt Date: Thu, 18 Jun 2020 07:55:35 -0700 Message-ID: Subject: Re: [PATCH v6 05/19] mm: memcontrol: decouple reference counting from page accounting To: Roman Gushchin Cc: Andrew Morton , Christoph Lameter , Johannes Weiner , Michal Hocko , Linux MM , Vlastimil Babka , Kernel Team , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: A37F81802B419 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Not sure if my email went through, so, re-sending. On Mon, Jun 8, 2020 at 4:07 PM Roman Gushchin wrote: > > From: Johannes Weiner > [...] > @@ -3003,13 +3004,16 @@ void __memcg_kmem_uncharge_page(struct page *page, int order) > */ > void mem_cgroup_split_huge_fixup(struct page *head) > { > + struct mem_cgroup *memcg = head->mem_cgroup; > int i; > > if (mem_cgroup_disabled()) > return; > A memcg NULL check is needed here. > - for (i = 1; i < HPAGE_PMD_NR; i++) > - head[i].mem_cgroup = head->mem_cgroup; > + for (i = 1; i < HPAGE_PMD_NR; i++) { > + css_get(&memcg->css); > + head[i].mem_cgroup = memcg; > + } > } > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ >