From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B832C433F5 for ; Thu, 10 Feb 2022 22:23:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6383F6B0075; Thu, 10 Feb 2022 17:23:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5E6146B0078; Thu, 10 Feb 2022 17:23:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AE9A6B007B; Thu, 10 Feb 2022 17:23:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0231.hostedemail.com [216.40.44.231]) by kanga.kvack.org (Postfix) with ESMTP id 3C97F6B0075 for ; Thu, 10 Feb 2022 17:23:51 -0500 (EST) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0513E94FCC for ; Thu, 10 Feb 2022 22:23:51 +0000 (UTC) X-FDA: 79128298662.26.FBE006E Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by imf29.hostedemail.com (Postfix) with ESMTP id 9DDAC120003 for ; Thu, 10 Feb 2022 22:23:50 +0000 (UTC) Received: by mail-lf1-f41.google.com with SMTP id f41so5880886lfv.12 for ; Thu, 10 Feb 2022 14:23:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0hO66QIvus488NAq78feGEF3dBYxRKmF5DOdeN40y0E=; b=ifAyrepAz0/IittI3oOkEW3ly0MGafuEuH+Wv4mqyEk5J+wQSQK4XejFuQrRyABDxy cDqnh5/He67UFdvdqWpWkGAY/4DGX71VVGZtRxmYlXps/XzEIW0/YAK+lGR1Of8QoJhA dlcXq1Pjm6j94Eh2UzSeZtQSV1JIKru0Uq60Ossq66fC+6zhWOea8yR11tUdGHv33PQS QgWvXdGu9gDVM4ZDMwDCLedn7lb0suJH93kcg+bgyn+ulIlbOetxdtUDPDVAkqcwTwa4 n4LLOEvLFf2EFgZfhIIv1t/7uc9WiFYkSNxY+AH74ofOtAAxydlupol0MB9qJiSbd0mY cn/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0hO66QIvus488NAq78feGEF3dBYxRKmF5DOdeN40y0E=; b=NT4EectrJph9boW6u9kzo/WRRlAL4ex67heb64DNArBgGSWtBHddaDxV3ojQxfgvBk pUGv3rIraf2bv7Sq1HNvCCXAYHAt/q0XINwCoQD0NqFw/PMnHnf1DShzJ9DMDCxDcoFT Xz+7tSMIWM/4xWRFqS3oC+ubcUVIusDZvykWWw6TcJCsHyGyeVxWTcRIvimOdhPMbGXV brG+InphLt4IQFi/FpwclH40eJahggdHL630Pz3ou5jXApB+zMh3p7TBCiUSTtUF6U3g KLY+XTTqTnDkCiF9Dg/of/9WCe5Gy9NIvaCo9vCqDnYBavvvPgIgy6D/HZ3YiStKbE6l XrBg== X-Gm-Message-State: AOAM531RZh6FaQBAC376gmRb0QEJHFVLAJ8IpAmOF/Y/D374OkwoFM5d 3OBWEiMgA+p3rThEYFeCzLwSkEU5YjO6+mhRkn+Uxw== X-Google-Smtp-Source: ABdhPJwFiSrA1WyKAJ3QOZVAg4E0gV7YsjWEijBGwjO9wjm2Wyh1/Ocie0SCJqhwKTKi5U//VRSxTwUeqtXSwW1SiPE= X-Received: by 2002:a05:6512:230b:: with SMTP id o11mr6432078lfu.40.1644531829105; Thu, 10 Feb 2022 14:23:49 -0800 (PST) MIME-Version: 1.0 References: <20220210081437.1884008-1-shakeelb@google.com> <20220210081437.1884008-2-shakeelb@google.com> In-Reply-To: From: Shakeel Butt Date: Thu, 10 Feb 2022 14:23:37 -0800 Message-ID: Subject: Re: [PATCH 1/4] memcg: refactor mem_cgroup_oom To: Roman Gushchin Cc: Johannes Weiner , Michal Hocko , Chris Down , Andrew Morton , Cgroups , Linux MM , LKML Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=ifAyrepA; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf29.hostedemail.com: domain of shakeelb@google.com designates 209.85.167.41 as permitted sender) smtp.mailfrom=shakeelb@google.com X-Rspam-User: X-Rspamd-Queue-Id: 9DDAC120003 X-Stat-Signature: 494zamh6uw4t8qjm3aymknfqfzmsrzuk X-Rspamd-Server: rspam07 X-HE-Tag: 1644531830-373025 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 10, 2022 at 11:53 AM Roman Gushchin wrote: > > On Thu, Feb 10, 2022 at 12:14:34AM -0800, Shakeel Butt wrote: > > The function mem_cgroup_oom returns enum which has four possible values > > but the caller does not care about such values and only care if the > > return value is OOM_SUCCESS or not. So, remove the enum altogether and > > make mem_cgroup_oom returns a simple bool. > > > > Signed-off-by: Shakeel Butt > > Nice! > > Reviewed-by: Roman Gushchin Thanks. > [...] > > The only thing, I'd add a small comment on the return value here. E.g. > "returns true if one or more tasks have been successfully killed" or something > like this. > Will do in the next version.