From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6CBE5C4727E for ; Thu, 24 Sep 2020 19:45:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D70F6239CF for ; Thu, 24 Sep 2020 19:45:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="WsW29SUq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D70F6239CF Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5C2E66B005D; Thu, 24 Sep 2020 15:45:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 57268900003; Thu, 24 Sep 2020 15:45:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 461EB900002; Thu, 24 Sep 2020 15:45:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id 3201C6B005D for ; Thu, 24 Sep 2020 15:45:11 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id D81B4181AE867 for ; Thu, 24 Sep 2020 19:45:10 +0000 (UTC) X-FDA: 77298983580.04.coil07_440950127161 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id BA21580105A0 for ; Thu, 24 Sep 2020 19:45:10 +0000 (UTC) X-HE-Tag: coil07_440950127161 X-Filterd-Recvd-Size: 3297 Received: from mail-lf1-f68.google.com (mail-lf1-f68.google.com [209.85.167.68]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Thu, 24 Sep 2020 19:45:10 +0000 (UTC) Received: by mail-lf1-f68.google.com with SMTP id y2so154022lfy.10 for ; Thu, 24 Sep 2020 12:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eSsieBQidgogH93zGkfDZQP5/e21cBSfkOWDaUDT/2s=; b=WsW29SUqjJiJZddNLF2A4XcocJgaEx0BV+Vy0q1CP+GSyP5JYj9UbL6j/eyrMH/O/e JEggZ6szgy5px13yB/GvZGpvG4HFLDBI2DJe5KgA/+44PxtQ5SSHCiWnAyBTh6ppYc4d aF9ECLAcXWDweHPeCKzogJK7koWVmC0S22wughhnHvaGL6+kY1jq57WWughJSGNBs3Cn ysQHRNQMqMCf09GJiCKMPAD1OSWE3i7QV174YfyWr9n6fiPcsC9ngRZeWOD+xtB9Sfk0 Mi4VOnfvovoOv37WBRWrAqYfHnw6SI9RxuJUEKQzh1kGLtK54VrgKVemubLLRGMLEIQ7 VDdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eSsieBQidgogH93zGkfDZQP5/e21cBSfkOWDaUDT/2s=; b=MF/AIzTLOTFEmMszwtva3xX+XfBGFeXlaQkW+CaUVwbi/X/V38bwCX/OCivp89RNwb 3kOInm5CNr9JenwDNgjbqkMiNtp2X4uatObQ65tYs0TlwhyEKNUlBgot8dcd9qryWjpS /E6B0yDthA20MzppCnW40o6pAPFnF3d4iiN0GB719fET4C633k/A4blb1UrN8uEV2ZDC JQScd4T0pj4K1Adqa9unmWvUq7rUcUlTwtqtX09AG4XDbilSbwojB5jNfNzoqjh06Yvd Ocf+DwqoRG/8NV0Hdy1o54Updo8WenfqFvNhDpYyPy4h692c37LSr3YwdFWtI8riD2yN Qf3Q== X-Gm-Message-State: AOAM531E/AdhCD7FGp/+TxGOCZ1mNVL7jDm93zRKh8WjsDsMYumAEy6k Gk2RR6K8wTtEi2D9Tw+0cDkd5BpzJrBnQqIBC5K9Eg== X-Google-Smtp-Source: ABdhPJzwMf70r+Jbg5ClZuPQJVH30T0YFAgaYPUOBkG5Sek0S4eGoPy1cdQ0EaRabYdSQPBatK2KJn3ISrRr4WKNrz4= X-Received: by 2002:a19:604e:: with SMTP id p14mr131976lfk.385.1600976708381; Thu, 24 Sep 2020 12:45:08 -0700 (PDT) MIME-Version: 1.0 References: <20200924192706.3075680-1-guro@fb.com> <20200924192706.3075680-4-guro@fb.com> In-Reply-To: <20200924192706.3075680-4-guro@fb.com> From: Shakeel Butt Date: Thu, 24 Sep 2020 12:44:57 -0700 Message-ID: Subject: Re: [PATCH v2 3/4] mm: introduce page memcg flags To: Roman Gushchin Cc: Andrew Morton , Johannes Weiner , Michal Hocko , LKML , Linux MM , Kernel Team Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.021896, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 24, 2020 at 12:29 PM Roman Gushchin wrote: > > The lowest bit in page->memcg_data is used to distinguish between > struct memory_cgroup pointer and a pointer to a objcgs array. > All checks and modifications of this bit are open-coded. > > Let's formalize it using page memcg flags, defined in page_memcg_flags > enum, and replace all open-coded accesses with test_bit()/__set_bit(). > > Additional flags might be added later. > > Signed-off-by: Roman Gushchin Thanks. Reviewed-by: Shakeel Butt