From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08103C433DF for ; Thu, 16 Jul 2020 17:04:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A191D204EC for ; Thu, 16 Jul 2020 17:04:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="SmOJInW8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A191D204EC Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2BE688D001B; Thu, 16 Jul 2020 13:04:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 26F458D0005; Thu, 16 Jul 2020 13:04:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 185DC8D001B; Thu, 16 Jul 2020 13:04:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0080.hostedemail.com [216.40.44.80]) by kanga.kvack.org (Postfix) with ESMTP id 0233E8D0005 for ; Thu, 16 Jul 2020 13:04:57 -0400 (EDT) Received: from smtpin23.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 918512C89 for ; Thu, 16 Jul 2020 17:04:57 +0000 (UTC) X-FDA: 77044563834.23.page25_1112af326f03 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin23.hostedemail.com (Postfix) with ESMTP id 447E537604 for ; Thu, 16 Jul 2020 17:04:57 +0000 (UTC) X-HE-Tag: page25_1112af326f03 X-Filterd-Recvd-Size: 8646 Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Thu, 16 Jul 2020 17:04:56 +0000 (UTC) Received: by mail-lj1-f193.google.com with SMTP id q4so8772057lji.2 for ; Thu, 16 Jul 2020 10:04:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=g2kCsm/bm1ve9jG+Cs+m54b7wlSjss2b9ylTUfr3H5Q=; b=SmOJInW8UzmPU3mqjDPCmjZFhN/t2ZScfhEKYZb3jaL+M1UhR0jdgzDcrSW7i3qQYP FhShRV+wjnwoaJP1VNmeb4BKME47gsr56p2OPQm0wati9CLgyCvsGy80KwrjimucLuF7 gV0/qhIwmOB9cH0MpkgXUXNCF6NkFNwUuF8FMqLCaamd4smxNNEcZUAk/jPPmwGjvxWr E3aFdMyb+qiHFZbjT2MGpl/Yva9H4VkF5ZuYTKBEgXn+kpzvQ5WBPbd+ozFtrD3UF2Zx lneXnovYbFNNoHepJ8V37MuOgdvD7ON+QFe2Jiice5+Cvx2ZyAxhl74GwT9JOVl/loqs MA4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=g2kCsm/bm1ve9jG+Cs+m54b7wlSjss2b9ylTUfr3H5Q=; b=Ez7cz4elOSHzM6zGmoXKDKNkg7FynmkeINOBpw9ppJhllhzw38YkkVfYwrEUHNtVoK MYAq/HadsyeqqGk1HBebk2f56FyY9i7m036uEtlNVEod+IenVewsYcy1KV54YFfoTha6 tWk3JerjUP7XySIQB7+wm6D0jVlOX7tW2UBb0M8rVmMrv236ejaS059RBFGdrjPGHM38 v5cmwCGkHsHZJafHNCxykja7i1QqGsZWSQJcOdf60U8dTFCmNZZC8Tk39aX7dGTKGIL8 Dt8o6y9xr5XrNT6ApMpuN54HRbedV7NaY9McAT7J/WTHk+a+SduU2vivEuvA9HVhYLCB Bcyg== X-Gm-Message-State: AOAM533oQnOLUTU5n+V7UPTDyEKdGtLcxN3jomxco1RtVjgPuZuSUG/+ 4ofCLWyZQ1fMMK1dZMSaNMJS2ecrLgu2AUlROMlwMQ== X-Google-Smtp-Source: ABdhPJxSIIPnQxqHLZgaVWbqZ+jOLHmLZMiIPzk/5VcvReKa0rFFrDWP5flDhnZuVy7AGqysB9pz/olfwpeoIYNXTyc= X-Received: by 2002:a05:651c:10f:: with SMTP id a15mr2396471ljb.192.1594919094710; Thu, 16 Jul 2020 10:04:54 -0700 (PDT) MIME-Version: 1.0 References: <1585649077-10896-1-git-send-email-laoar.shao@gmail.com> In-Reply-To: From: Shakeel Butt Date: Thu, 16 Jul 2020 10:04:43 -0700 Message-ID: Subject: Re: [PATCH v2 0/2] psi: enhance psi with the help of ebpf To: Yafang Shao Cc: Johannes Weiner , "Peter Zijlstra (Intel)" , Andrew Morton , Linux MM , "open list:BLOCK LAYER" , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 447E537604 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000042, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 15, 2020 at 8:19 PM Yafang Shao wrote: > > On Thu, Jul 16, 2020 at 12:36 AM Shakeel Butt wrote: > > > > Hi Yafang, > > > > On Tue, Mar 31, 2020 at 3:05 AM Yafang Shao wrote: > > > > > > PSI gives us a powerful way to anaylze memory pressure issue, but we can > > > make it more powerful with the help of tracepoint, kprobe, ebpf and etc. > > > Especially with ebpf we can flexiblely get more details of the memory > > > pressure. > > > > > > In orderc to achieve this goal, a new parameter is added into > > > psi_memstall_{enter, leave}, which indicates the specific type of a > > > memstall. There're totally ten memstalls by now, > > > MEMSTALL_KSWAPD > > > MEMSTALL_RECLAIM_DIRECT > > > MEMSTALL_RECLAIM_MEMCG > > > MEMSTALL_RECLAIM_HIGH > > > MEMSTALL_KCOMPACTD > > > MEMSTALL_COMPACT > > > MEMSTALL_WORKINGSET_REFAULT > > > MEMSTALL_WORKINGSET_THRASH > > > MEMSTALL_MEMDELAY > > > MEMSTALL_SWAPIO > > > With the help of kprobe or tracepoint to trace this newly added agument we > > > can know which type of memstall it is and then do corresponding > > > improvement. I can also help us to analyze the latency spike caused by > > > memory pressure. > > > > > > But note that we can't use it to build memory pressure for a specific type > > > of memstall, e.g. memcg pressure, compaction pressure and etc, because it > > > doesn't implement various types of task->in_memstall, e.g. > > > task->in_memcgstall, task->in_compactionstall and etc. > > > > > > Although there're already some tracepoints can help us to achieve this > > > goal, e.g. > > > vmscan:mm_vmscan_kswapd_{wake, sleep} > > > vmscan:mm_vmscan_direct_reclaim_{begin, end} > > > vmscan:mm_vmscan_memcg_reclaim_{begin, end} > > > /* no tracepoint for memcg high reclaim*/ > > > compcation:mm_compaction_kcompactd_{wake, sleep} > > > compcation:mm_compaction_begin_{begin, end} > > > /* no tracepoint for workingset refault */ > > > /* no tracepoint for workingset thrashing */ > > > /* no tracepoint for use memdelay */ > > > /* no tracepoint for swapio */ > > > but psi_memstall_{enter, leave} gives us a unified entrance for all > > > types of memstall and we don't need to add many begin and end tracepoints > > > that hasn't been implemented yet. > > > > > > Patch #2 gives us an example of how to use it with ebpf. With the help of > > > ebpf we can trace a specific task, application, container and etc. It also > > > can help us to analyze the spread of latencies and whether they were > > > clustered at a point of time or spread out over long periods of time. > > > > > > To summarize, with the pressure data in /proc/pressure/memroy we know that > > > the system is under memory pressure, and then with the newly added tracing > > > facility in this patchset we can get the reason of this memory pressure, > > > and then thinks about how to make the change. > > > The workflow can be illustrated as bellow. > > > > > > REASON ACTION > > > | compcation | improve compcation | > > > | vmscan | improve vmscan | > > > Memory pressure -| workingset | improve workingset | > > > | etc | ... | > > > > > > > I have not looked at the patch series in detail but I wanted to get > > your thoughts if it is possible to achieve what I am trying to do with > > this patch series. > > > > At the moment I am only interested in global reclaim and I wanted to > > enable alerts like "alert if there is process stuck in global reclaim > > for x seconds in last y seconds window" or "alert if all the processes > > are stuck in global reclaim for some z seconds". > > > > I see that using this series I can identify global reclaim but I am > > wondering if alert or notifications are possible. Android is using psi > > monitors for such alerts but it does not use cgroups, so, most of the > > memstalls are related to global reclaim stall. For cgroup environment, > > do we need for add support to psi monitor similar to this patch > > series? > > > > Hi Shakeel, > > We use the PSI tracepoints in our kernel to analyze the individual > latency caused by memory pressure, but the PSI tracepoints are > implemented with a new version as bellow: > trace_psi_memstall_enter(_RET_IP_); > trace_psi_memstall_leave(_RET_IP_); > And then using the _RET_IP_ to identify the specific PSI type. > > If the _RET_IP_ is at try_to_free_mem_cgroup_pages(), then it means > the pressure caused by the memory cgroup, IOW, the limit of memcg is > reached and it has to do memcg reclaim. Otherwise we can consider it > as global memory pressure. > try_to_free_mem_cgroup_pages > psi_memstall_enter > if (static_branch_likely(&psi_disabled)) > return; > *flags = current->in_memstall; > if (*flags) > return; > trace_psi_memstall_enter(_RET_IP_); <<<<< memcg pressure > Thanks for the response. I am looking for 'always on' monitoring. More specifically defining the system level SLIs based on PSI. My concern with ftrace is its global shared state and also it is not really for 'always on' monitoring. You have mentioned ebpf. Is ebpf fine for 'always on' monitoring and is it possible to notify user space by ebpf on specific conditions (e.g. a process stuck in global reclaim for 60 seconds)? thanks, Shakeel