From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE474C433EF for ; Thu, 11 Nov 2021 02:05:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 472D161212 for ; Thu, 11 Nov 2021 02:05:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 472D161212 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id CF5566B00BF; Wed, 10 Nov 2021 21:05:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C7C6D6B00C0; Wed, 10 Nov 2021 21:05:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B1E1A6B00C1; Wed, 10 Nov 2021 21:05:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0222.hostedemail.com [216.40.44.222]) by kanga.kvack.org (Postfix) with ESMTP id A08E46B00BF for ; Wed, 10 Nov 2021 21:05:20 -0500 (EST) Received: from smtpin31.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 5DDE583EAC for ; Thu, 11 Nov 2021 02:05:20 +0000 (UTC) X-FDA: 78795007200.31.C4ED85C Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf06.hostedemail.com (Postfix) with ESMTP id 4BA87801A88D for ; Thu, 11 Nov 2021 02:05:10 +0000 (UTC) Received: by mail-lj1-f177.google.com with SMTP id e9so8931994ljl.5 for ; Wed, 10 Nov 2021 18:05:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=LMNluGg1oD1xxzKztNLmkE+a3kVEZIQ80t9yoqV5XOU=; b=K9B9z96JYSZNOVrwDI6C3rzyp1zxt5naT65hnzTktky4X2rUX/4C//Z9RX1wwiloYD yTu+RreHY3WWZ/ezTbbOKzlnG9NgfjNlGdjqVe5QFsz/IyPqqi/UDcrBaIH7+lPoNdwQ JlqDBpDGBq0SlH7y1GUoBOXpFh4s2qaJ1SLJTEJD9mYhrd074DAbAGNPkDcUQSp/sTHd hfHi4ba/20bg5XT4s1iIa+9fUF4HCcRUUK9buvmDMa97OxmyLVTzBWsDlh1KiH0LfT4N aH41S1MkfxsvtgfWi0haZMpErOxQivwzPsPV+3j3GFGkRTILGlUmUpsD5lYv0rvU95jp 3wiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=LMNluGg1oD1xxzKztNLmkE+a3kVEZIQ80t9yoqV5XOU=; b=rtrJGjstMcZl4lckVAL3R3T2y8rH5yacVsHISd+y+xXQF7onFFItmJPaQS3u0V4dnL YQIH+PeNuOsq/nqNK6Ybt62emAWRe8RVMO3vQ9/894ljBPvoEu3qsW9cYuMLuCRwijfg 4OHyIvjSNPrNVxToBy5AAiuQfSi5ztts6AV4uh3t4II5J7wqzJfjwXlcTOwheBtpFwxf qQImBJIlalstzEZgCbNCX9frLJJYzzLEa/FBiL8PvGW1XOhxREz+jfa8kiwIsF19QZ3y O3ExN1UEWX2sj3uleae45YXSlCO0fabrF1yc5tX805EwKz+ieqh+M6ReWl9aH8JlVHX6 VW6Q== X-Gm-Message-State: AOAM530CF4h7KXBzMyQkmDkMfi6rVbAGadomBazBtoKlY6+u3PoPLrPz Y8veaI8ZbaWKzmEDOCWbHsp1jRM2s3bc4PMJRn/NOw== X-Google-Smtp-Source: ABdhPJzC4Jp+umhzEA3lXMzej2zzbUmTLlT9e9wINZ3YQk5aDo16CUqE2DEpesPxsSM8/hXW01nfIjCtiq+kgOHc+Z4= X-Received: by 2002:a05:651c:545:: with SMTP id q5mr3475095ljp.202.1636596308510; Wed, 10 Nov 2021 18:05:08 -0800 (PST) MIME-Version: 1.0 References: <20211111015037.4092956-1-almasrymina@google.com> In-Reply-To: <20211111015037.4092956-1-almasrymina@google.com> From: Shakeel Butt Date: Wed, 10 Nov 2021 18:04:57 -0800 Message-ID: Subject: Re: [PATCH v6] hugetlb: Add hugetlb.*.numa_stat file To: Mina Almasry Cc: Mike Kravetz , Andrew Morton , Shuah Khan , Miaohe Lin , Oscar Salvador , Michal Hocko , Muchun Song , David Rientjes , Jue Wang , Yang Yao , Joanna Li , Cannon Matthews , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 4BA87801A88D X-Stat-Signature: m7qoc96ex5f9hdsbg9o161znz3eb97r9 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=K9B9z96J; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf06.hostedemail.com: domain of shakeelb@google.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=shakeelb@google.com X-HE-Tag: 1636596310-11964 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Nov 10, 2021 at 5:50 PM Mina Almasry wrote= : > > For hugetlb backed jobs/VMs it's critical to understand the numa > information for the memory backing these jobs to deliver optimal > performance. > > Currently this technically can be queried from /proc/self/numa_maps, but > there are significant issues with that. Namely: > 1. Memory can be mapped or unmapped. > 2. numa_maps are per process and need to be aggregated across all > processes in the cgroup. For shared memory this is more involved as > the userspace needs to make sure it doesn't double count shared > mappings. > 3. I believe querying numa_maps needs to hold the mmap_lock which adds > to the contention on this lock. > > For these reasons I propose simply adding hugetlb.*.numa_stat file, > which shows the numa information of the cgroup similarly to > memory.numa_stat. > > On cgroup-v2: > cat /sys/fs/cgroup/unified/test/hugetlb.2MB.numa_stat > total=3D2097152 N0=3D2097152 N1=3D0 > > On cgroup-v1: > cat /sys/fs/cgroup/hugetlb/test/hugetlb.2MB.numa_stat > total=3D2097152 N0=3D2097152 N1=3D0 > hierarichal_total=3D2097152 N0=3D2097152 N1=3D0 > > This patch was tested manually by allocating hugetlb memory and querying > the hugetlb.*.numa_stat file of the cgroup and its parents. > =EF=BF=BC > Cc: Mike Kravetz > Cc: Andrew Morton > Cc: Shuah Khan > Cc: Miaohe Lin > Cc: Oscar Salvador > Cc: Michal Hocko > Cc: Muchun Song > Cc: David Rientjes > Cc: Shakeel Butt > Cc: Jue Wang > Cc: Yang Yao > Cc: Joanna Li > Cc: Cannon Matthews > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Mina Almasry Reviewed-by: Shakeel Butt