From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4C00C433EF for ; Sat, 21 May 2022 21:35:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0BA3B8D0002; Sat, 21 May 2022 17:35:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 06A638D0001; Sat, 21 May 2022 17:35:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9B538D0002; Sat, 21 May 2022 17:35:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id DE81C8D0001 for ; Sat, 21 May 2022 17:35:10 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay12.hostedemail.com (Postfix) with ESMTP id AC1801207DF for ; Sat, 21 May 2022 21:35:10 +0000 (UTC) X-FDA: 79491055980.12.2CD5762 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf23.hostedemail.com (Postfix) with ESMTP id CF9F5140003 for ; Sat, 21 May 2022 21:34:50 +0000 (UTC) Received: by mail-pf1-f175.google.com with SMTP id 202so3508728pfu.0 for ; Sat, 21 May 2022 14:35:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6FG27lBVQnY3sW1qr+3lTil/aSlsNAs4hsByJ/IiO+o=; b=Q2lvXkm8Au5J0g4yU1+wo2VFEu1ry0wpBSOZ7q+73S3WN4WezFtKZucJH875SDJTi6 T5CXHETsQ2vlwmEZwXkIkGCnryL/12ZawPU6er9ftMQG9FPc/08GSb9/eZaBPQRBUJbZ Y32iam+NDnJ+IiJ3hkEuTBmE7FDIZc56kkBnrjqlsfO7NvJlbWa4NFZguZNgD5FsFh1c mSVAiXFqmfidCM7uzGhGxNB/iS+2oy2Rtwvh8qD5LFJoNubN6jZL4wGZhx8GYsuQnvHO enKb9QYI2eavJgYcBkkLsdGKB7Ye9LQMK3cGfh3YtLn/VCwihXZY0odav5rkygqfw98E 1dFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6FG27lBVQnY3sW1qr+3lTil/aSlsNAs4hsByJ/IiO+o=; b=um7k0ZHSxYW/6NS1pUUSPpMx/4azb8ThuMK/VoS3kKcBiNCd8dXhoqY+Ec0MgSAze9 j6Pi439p9I73aQFpzrPt20W9e0XruFtv51pTXUL7ykbV44lvzjH6Uzgv7WstuxnBWJUz GjqUXuwgr3ykj3vpJNmqM0SKh0Ftr+tWrGIPmSAu/b9k49wcouwNxjONdM7OId02Rzc4 7rQUUpvgcfvHFV1iSXiYOyXxthUS63LnK02/usdVM9oYtMCzE9ScJVnGlRjYrsMubhIB N7et7vUvvM5ZkEp77k8AXqYizyDFMZNTEp7Lr4xxIGg+O/NUlTkkpO466MErjCcD6Lh1 /EmA== X-Gm-Message-State: AOAM531wGMt5ev35WHOKeMWvb/yZZGXdXTQn7BVQFvqjI9c/ppVsUGVD oOKl7gqjGCeWFpK9AnRjJdXV5eJWnKT8hJBTQCHoHQ== X-Google-Smtp-Source: ABdhPJxt/l4bOp8SSCZDM6zebWox/h+cKICoPjL9oOZ/PSoYaM7yyml1UJAzTugs3YIo++viEP+Jmvi/5Kp7BcC1I/E= X-Received: by 2002:a63:d4c:0:b0:3f5:cc48:9fa3 with SMTP id 12-20020a630d4c000000b003f5cc489fa3mr10038056pgn.509.1653168908742; Sat, 21 May 2022 14:35:08 -0700 (PDT) MIME-Version: 1.0 References: <16f17021-61a3-c6f4-f60c-1acd3a0b66b9@openvz.org> In-Reply-To: <16f17021-61a3-c6f4-f60c-1acd3a0b66b9@openvz.org> From: Shakeel Butt Date: Sat, 21 May 2022 14:34:57 -0700 Message-ID: Subject: Re: [PATCH mm v2 5/9] memcg: enable accounting for percpu allocation of struct psi_group_cpu To: Vasily Averin Cc: Andrew Morton , kernel@openvz.org, LKML , Linux MM , Roman Gushchin , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Vlastimil Babka , Michal Hocko , Cgroups Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CF9F5140003 X-Stat-Signature: k9q819w6czs88dauamsda67atg1jhji5 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Q2lvXkm8; spf=pass (imf23.hostedemail.com: domain of shakeelb@google.com designates 209.85.210.175 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspam-User: X-HE-Tag: 1653168890-850086 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, May 21, 2022 at 9:38 AM Vasily Averin wrote: > > struct pci_group_cpu is percpu allocated for each new cgroup and can > consume a significant portion of all allocated memory on nodes with > a large number of CPUs. > > Common part of the cgroup creation: > Allocs Alloc $1*$2 Sum Allocation > number size > -------------------------------------------- > 16 ~ 352 5632 5632 KERNFS > 1 + 4096 4096 9728 (cgroup_mkdir+0xe4) > 1 584 584 10312 (radix_tree_node_alloc.constprop.0+0x89) > 1 192 192 10504 (__d_alloc+0x29) > 2 72 144 10648 (avc_alloc_node+0x27) > 2 64 128 10776 (percpu_ref_init+0x6a) > 1 64 64 10840 (memcg_list_lru_alloc+0x21a) > percpu: > 1 + 192 192 192 call_site=psi_cgroup_alloc+0x1e > 1 + 96 96 288 call_site=cgroup_rstat_init+0x5f > 2 12 24 312 call_site=percpu_ref_init+0x23 > 1 6 6 318 call_site=__percpu_counter_init+0x22 > > '+' -- to be accounted, > '~' -- partially accounted > > Signed-off-by: Vasily Averin Acked-by: Shakeel Butt