From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 703C7C433EF for ; Thu, 19 May 2022 05:43:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E43EE6B0072; Thu, 19 May 2022 01:43:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DCD256B0073; Thu, 19 May 2022 01:43:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6D3F6B0074; Thu, 19 May 2022 01:43:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B27A96B0072 for ; Thu, 19 May 2022 01:43:18 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7FBF820B00 for ; Thu, 19 May 2022 05:43:18 +0000 (UTC) X-FDA: 79481399676.24.E5CE47B Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf05.hostedemail.com (Postfix) with ESMTP id 0EF0D100005 for ; Thu, 19 May 2022 05:42:53 +0000 (UTC) Received: by mail-pj1-f50.google.com with SMTP id nr2-20020a17090b240200b001df2b1bfc40so7759731pjb.5 for ; Wed, 18 May 2022 22:43:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6z/Bc5UCAfAeTzRfuIMJWHJqH0NGV84MAGaXVzlC2gw=; b=iYklmhIxxcBAg2/vfEqx7EfCepTuDYi24pzQZ93iZPutwkc+6GNmiuWkRp4WSUW1ya f/jfz/Se1RPPSr78BVC2yxVHvo+u/ri3lBc67M9oXg9qkAJOo7O5E//zEJ2LbV1GkhZs CbBSsrRrh99IMN8FJB7Y+n1CoWRLQKbzzKDYetu4vJPPbfVNPn5PDJhiCjqFBIcV+jbY yjHTuITb9PGP6NBOf1aoOOfBWmJPl0/Ic4kCxNcIPALoEg9CwyWzGXEXerzi5uPx7nhX 745qUbJI7IX6gxT3jJCXA77uajMX2tNeZM9/dGV9iA0ED0FTiHB3VKCFrrPZAFz/qG4V mtNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6z/Bc5UCAfAeTzRfuIMJWHJqH0NGV84MAGaXVzlC2gw=; b=dTkmwwcTLu7kWJqeAF9L3b97HEf7Kk9aiwKXD34po7kd2OZF8VXKiceSC/V3TEXc9K o7qV4kpftIgEXn/ADvo4bTQhfD6AB5dggGenwXbMu8VlcBkw1E5CXVUkABa1f9/WPbZ/ igMxXoUGTPebYXRNeUJ7vPsI9JGcp4sawJ+DJy46nfVZYnnN2kIOkovwlXxTLj+Cn6wZ WZNnnOY70Fhz3XkRVqStQnVdZDqkaPsa3T6E3vKnraDYGmSDa0Qag1WMhCWzQgUlfXJL O/3PtDli0DtPOmBLi01VYHJoBHv75Z3WyJS667rbNYpUsRrfLMuUr9KLPgB1IbfvZsp2 OmeQ== X-Gm-Message-State: AOAM530SqeuSGw+IhITJWbTvRxR3pHjUVFA2hh/o65fngI3Ow2/FMnzr KDIqZxJutWczu6BJo6jkTG2onVnI2Wdgw4atc5QGCQ== X-Google-Smtp-Source: ABdhPJwVrFgLJ/iOPmvarT2Xzx/jUomRSAH5rMsUBTKCfWAyxNrNKIq+GvtzXJtlJ8wYWG2H/jQ8POCBdgYFz8vIuXI= X-Received: by 2002:a17:902:b094:b0:15c:dee8:74c8 with SMTP id p20-20020a170902b09400b0015cdee874c8mr3193505plr.6.1652938996847; Wed, 18 May 2022 22:43:16 -0700 (PDT) MIME-Version: 1.0 References: <20220517164713.4610-1-kristen@linux.intel.com> <9c269c70-35fe-a1a4-34c9-b1e62ab3bb3b@intel.com> In-Reply-To: <9c269c70-35fe-a1a4-34c9-b1e62ab3bb3b@intel.com> From: Shakeel Butt Date: Wed, 18 May 2022 22:43:05 -0700 Message-ID: Subject: Re: [PATCH] x86/sgx: Set active memcg prior to shmem allocation To: Kristen Carlson Accardi Cc: linux-sgx@vger.kernel.org, Dave Hansen , Jarkko Sakkinen , Dave Hansen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Johannes Weiner , Roman Gushchin , Linux-MM , Michal Hocko , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0EF0D100005 X-Stat-Signature: xcbourhjuz9rn36sbsijfei8hstzags4 X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=iYklmhIx; spf=pass (imf05.hostedemail.com: domain of shakeelb@google.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=shakeelb@google.com; dmarc=pass (policy=reject) header.from=google.com X-Rspamd-Server: rspam09 X-HE-Tag: 1652938973-956010 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: (Fixing the CC list and sending again) On Tue, May 17, 2022 at 09:47:13AM -0700, Kristen Carlson Accardi wrote: > [...] > +int sgx_encl_alloc_backing(struct sgx_encl *encl, unsigned long page_index, > + struct sgx_backing *backing) > +{ > + struct mem_cgroup *old_memcg; > + int ret; > + > + old_memcg = sgx_encl_set_active_memcg(encl); This function is leaking memcg reference. Please change sgx_encl_set_active_memcg() to sgx_encl_get_mem_cgroup() or something which will return the memcg with the refcount elevated. Then use set_active_memcg(returned_memcg) here. > + > + ret = sgx_encl_get_backing(encl, page_index, backing); > + > + set_active_memcg(old_memcg); mem_cgroup_put(returned_memcg) here. > + > + return ret; > +}